| Message ID | f0391316-ab30-4664-96ac-03445ab2aeba@moroto.mountain |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel+bounces-54992-ouuuleilei=gmail.com@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id
ma11csp1525213dyb;
Tue, 6 Feb 2024 05:09:21 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IEl5dBRvjIjGwRh344pRcWx3RB4ZK6Cu5auVGowsByY67hTqcq6s4LrgYb3R8o4YDJdJI4l
X-Received: by 2002:a05:651c:19a4:b0:2d0:8b59:a3ed with SMTP id
bx36-20020a05651c19a400b002d08b59a3edmr1718343ljb.37.1707224961181;
Tue, 06 Feb 2024 05:09:21 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1707224961; cv=pass;
d=google.com; s=arc-20160816;
b=OLBiIdPATYbP6bCsADLPwMRejTmppcMOhGQvaooiVgnLkrluSj64niFtL8PKop3JMN
iB+wY3CA+yguxJ+51zBcbjUU+FwcmvznJPNSh7YFaKkukRL6BRwA64Gt8LMdkyYHO7to
xKHqepc/SgwARH2i0YeIQLmNVtsGIp1p7iClVf/gKVBviEeT8DkFCY2/OxDdDI3ssRbg
a+qC0y5ugX7Dqx2sOLNSQMy51gbz//Y2v71OiMPLHLzFKOvPlQjisM0nlwhDVYSN1fb3
9JLNJVwLneITkVetQmP7+bL1mkQz097yLZh92C581v1+mG5owvKJ0BBIaK8Jd9JYGILP
HH/w==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=content-disposition:mime-version:list-unsubscribe:list-subscribe
:list-id:precedence:message-id:subject:cc:to:from:date
:dkim-signature;
bh=qpw7KIB9SDLyg6r6DS+MT6bxeqqIfgw6wlcljwHw/7Y=;
fh=Ge7Q9/0BPoYiYT0PawVl0ipiVQMFA7CZbhmwFjmexbc=;
b=VlJFyMYd9NSueP4fEYCn9gKjBmwbUif9+pu2AdgHRoD6eCbjkU1waQxlKhV0oJHSA9
wrrqmZSsOw+xKxWc6oIY7uijTTt4sd3tUwnGCMQxcgdR6LqyvZciS8Mr/iosl1IyYSfK
IGQ5xD2yyD8aYLjQ3F649sJYgoq4xbHI+7T/sMGwe2Si6wp/p/rUZrvAdeqD63xCHkr2
LkeIkBrNkXIj2CR7C0nmtsEP0HHOGOtmEtIpa8ta6XD2iQ1H2bClLJTQX0uU2KshcbA8
2cka3YYzwKAvL+jzxOfGNCyux79VrfQBTqFO1qJDzG4VzK/W3TpDvEYbKI1cdjWVDdA5
zDFw==;
dara=google.com
ARC-Authentication-Results: i=2; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=GqOVmpyS;
arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass
dkdomain=linaro.org dmarc=pass fromdomain=linaro.org);
spf=pass (google.com: domain of
linux-kernel+bounces-54992-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:4601:e00::3 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-54992-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
X-Forwarded-Encrypted: i=1;
AJvYcCXiWItJv/KUVDgacc2ibkDv7L3SQqP7z7gqyM71m8bSe/CF4RslU9G8BlvNKMfwkrRwu6teB/4DQIp9oxgBeTrQ+/q76g==
Received: from am.mirrors.kernel.org (am.mirrors.kernel.org.
[2604:1380:4601:e00::3])
by mx.google.com with ESMTPS id
n10-20020aa7c44a000000b0055c0cd8db38si1046895edr.629.2024.02.06.05.09.20
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 06 Feb 2024 05:09:21 -0800 (PST)
Received-SPF: pass (google.com: domain of
linux-kernel+bounces-54992-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=GqOVmpyS;
arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass
dkdomain=linaro.org dmarc=pass fromdomain=linaro.org);
spf=pass (google.com: domain of
linux-kernel+bounces-54992-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:4601:e00::3 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-54992-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by am.mirrors.kernel.org (Postfix) with ESMTPS id C461A1F259B8
for <ouuuleilei@gmail.com>; Tue, 6 Feb 2024 13:09:20 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id D7BAA130E41;
Tue, 6 Feb 2024 13:09:02 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b="GqOVmpyS"
Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com
[209.85.167.46])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69E1512FF76
for <linux-kernel@vger.kernel.org>; Tue, 6 Feb 2024 13:08:58 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=209.85.167.46
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1707224940; cv=none;
b=Mc88W2U8F7UGwlGDmDZmiw9d82pr7hoo0lApq43p/vw9x2jLuNiP0VW1HM7+f49OdEbrjKojIVYFiD2Ie8LA6H7b8Lu45Wei4qrUzJmF6vYnuCCVRNipKsLMT24JJWR5FD+EsvhelkqLEnP5YROk5cmFnqV+4KbLZbG++Kvw8rc=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1707224940; c=relaxed/simple;
bh=LMvw7ZapEqNLS9EY1kyMAKXzGH0Bt6b0N6T6aTC0hjY=;
h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type:
Content-Disposition;
b=UAlxMj8buplWUbCtAGJS83ZiDHNKAZG3ixnKttlb4PyH8GH9AsDtTanRbcp8IP8XOIOg2+vUZH2i9pjubLk4Lt/kzlR2bBoSnC4Yjinqil1fQ0p72tbptSZcwp9qH5yz/EocIUgsd6gNs+UPuHBfV5WFMjbOqNXmf+Hv/tHdD7E=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org;
spf=pass smtp.mailfrom=linaro.org;
dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org
header.b=GqOVmpyS; arc=none smtp.client-ip=209.85.167.46
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=linaro.org
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=linaro.org
Received: by mail-lf1-f46.google.com with SMTP id
2adb3069b0e04-511490772f6so3077973e87.2
for <linux-kernel@vger.kernel.org>;
Tue, 06 Feb 2024 05:08:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1707224936; x=1707829736;
darn=vger.kernel.org;
h=content-disposition:mime-version:message-id:subject:cc:to:from:date
:from:to:cc:subject:date:message-id:reply-to;
bh=qpw7KIB9SDLyg6r6DS+MT6bxeqqIfgw6wlcljwHw/7Y=;
b=GqOVmpySBNx2/SauyhOoO08nVrWpOuaQM17SYefrxN+TBOgSI1EtW+5sSLqOlV3KdA
RCqAZbFFFWRamj8MFp42E3GGtQ59wLmLLPgsyaHnagOEEZnBH9UFuzFR33LiwEuaEu+s
f7jNBdK2VGMa+lefDAKMbN4uEurRF6K9Y4sVaRzO30t3nHBA0clTTjnl/EqSNF0MyT5m
ga23vBX3hlnQKJS7b/zQpoi+vIBl16CkmjTGgxCA7iEBZx7bBDXmN8gLab4/HHTGAFSu
SF+0bNVHdBYg3S+I946if7xAOtM9EOhZfUrAON+N2jk+HCyJIF2TzZQ64RSWqmIIoeAR
/TMg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1707224936; x=1707829736;
h=content-disposition:mime-version:message-id:subject:cc:to:from:date
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=qpw7KIB9SDLyg6r6DS+MT6bxeqqIfgw6wlcljwHw/7Y=;
b=q4mOtp+jdhCfMGfK7GeMNDluDzQcWXk1yropI9mYF9OEOiLG9W1/sDxljRVqexy7EN
hO/uUiFmFVL378zxM+dzWB/aQwBfyPgC81YyyDNbxqVqTtw8ShtoRHaGp6AUDT6zdCwa
XiQmeebTYmtGn4WC55iZ/jM3mEsfeXrdZyLDr/p5rKOzIxfoBEZIm+KOrvAKgMvu50Tj
7Ueg+6eAyEm536J3dEcv5thHsnEfNnIB4JiX4uob09FYdl9mtqrK0OtOWzRKfJ5B0Y+m
etw2fvf4d7Hdo7h5fTRsr1yY0eewWKnyG7L48KVH7BQJ5ML8pHEiXALKIQhHyeL5P65I
FPeA==
X-Gm-Message-State: AOJu0YwFzYIh6CXd0GUioblO1rHtkczuJh6T4sCDIcMqu4AMmfN4cWUD
reqx+rkWc7L1ITtBelmfvknKVbkewIfpYNXNUxR1wOCvvw5O/Z9dO0Td8HkYxIU=
X-Received: by 2002:a05:6512:49d:b0:511:5411:1144 with SMTP id
v29-20020a056512049d00b0051154111144mr1522178lfq.14.1707224936479;
Tue, 06 Feb 2024 05:08:56 -0800 (PST)
X-Forwarded-Encrypted: i=0;
AJvYcCV1kdRpRxa7551jyeZut7+dRRqYEjtBtwSA2JsotGvkOvTm6mCBlGpnHpehfGak1mZE8mcq6/UMldKAZztANJBjUemhrvgacLFFxwSfYqBx6Y/KMPmETVR1yalhuTtKnaSVgZ/7i5M1rgVtbTCpB0B+hirV0Rqfdrgp1Qsgbkn2Q4mBtnYJYlSF//crcBlkW7qxDpLtAs4fJ28x+UclDVIsblNMk3jaPBZpgQuBvBm9IvjCxvi/ScA/YWUSQXMEMbS+SA4vqHgPFSdSvgAdD3LdffSCSma53K2/PyLdtnF7paoT4ndU387TkTqCnZ5N8+qlR4ZQxt90RL4I7ngPqTv6oeYDY3dY+Bv0uZpQGQY=
Received: from localhost ([102.222.70.76])
by smtp.gmail.com with ESMTPSA id
cu16-20020a170906ba9000b00a2a61b9c166sm1135601ejd.33.2024.02.06.05.08.55
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 06 Feb 2024 05:08:56 -0800 (PST)
Date: Tue, 6 Feb 2024 16:08:52 +0300
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Cc: Kalle Valo <kvalo@kernel.org>, Johannes Berg <johannes.berg@intel.com>,
Gregory Greenman <gregory.greenman@intel.com>,
Alon Giladi <alon.giladi@intel.com>,
Mukesh Sisodiya <mukesh.sisodiya@intel.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH] wifi: iwlwifi: return negative -EINVAL instead of positive
EINVAL
Message-ID: <f0391316-ab30-4664-96ac-03445ab2aeba@moroto.mountain>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Mailer: git-send-email haha only kidding
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1790155120935807089
X-GMAIL-MSGID: 1790155120935807089
|
| Series |
wifi: iwlwifi: return negative -EINVAL instead of positive EINVAL
|
|
Commit Message
Dan Carpenter
Feb. 6, 2024, 1:08 p.m. UTC
The '-' character is missing in -EINVAL.
Fixes: fc7214c3c986 ("wifi: iwlwifi: read DSM functions from UEFI")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/net/wireless/intel/iwlwifi/fw/uefi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/fw/uefi.c b/drivers/net/wireless/intel/iwlwifi/fw/uefi.c index fe6d0141cd5b..3c4c99eed110 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/uefi.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/uefi.c @@ -679,7 +679,7 @@ int iwl_uefi_get_dsm(struct iwl_fw_runtime *fwrt, enum iwl_dsm_funcs func, u32 *value) { struct uefi_cnv_var_general_cfg *data; - int ret = EINVAL; + int ret = -EINVAL; /* Not supported function index */ if (func >= DSM_FUNC_NUM_FUNCS || func == 5)