From patchwork Tue Feb 13 18:07:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 200541 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp715411dyb; Tue, 13 Feb 2024 10:08:37 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXKUSAkcPAUMoTNuXOeKJlyir9O0GDbxqKmlcnmDwoBrinYkTT7C5t7LrF9dLP4GwHj8NXW0zjxpG+l2zvyg1pq8QDGDA== X-Google-Smtp-Source: AGHT+IGHX/Ax1o1XBpeRTtR5yGOd/Fy0N9j8SIOHI96zZw8HwJIqz2H6wrgHDATZp2/43mjtJh94 X-Received: by 2002:ac2:54b9:0:b0:511:6798:64a3 with SMTP id w25-20020ac254b9000000b00511679864a3mr207075lfk.34.1707847717150; Tue, 13 Feb 2024 10:08:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707847717; cv=pass; d=google.com; s=arc-20160816; b=neOmEh3c4V5bSwrjMrJ+4ZP5HvMxJ6Phx/Mo/JdUsb2JGSX2zTzjW60v8LhXtmRyvz 5wr5ZOp43vB9G7jye9hiiFgy6net0sWvgwrYWSIvXycKgd7h5TpOqXlTCybhhEIwuGwv W/ctCGbWAUpWn6L+pYYL3t5pi56GiiiIP+R89+nMxUD8qTo7dDJR0tyeZIyfbF/e5mYs oK2Tt16E7pvEZlugSZK+NE1cNtK28f9CXrtFiY/q66Wxp1P2EWol9WpWuDFHjuALh4xF 0HrjceDm13Ye9RHZi6oI8UkCiC/qdUbf4kroJyQLjM1MqfVJwlJOoefITJ/O+y8RPRlK r3AQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-disposition:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:message-id:subject:cc:to:from:date :dkim-signature; bh=7nvXkv/btphQ8MW54HksmzNQa+3jvkr/X94Oa7LChw8=; fh=FBg28ZdFGskPfo2VDwO2fTgpFL92LjslncKnODH1X4o=; b=oq9oVCGPKbrblcGC8dsohTPUz59D0TSPMNTkUguH/0md68yAExPk1onbDoWJs14J2u Fs2VSJgI9MMz7ZddEaP0g5BDvQmo67JXMFmXcm4KF2YJO3VVRZNCbLta1WWbUydB+PPT 884ks22RCAC+I2uQ2Z76mBQUw7Qf6I5ZNwmljOOAfBiSJTBGYtul4VgAjmUnY2wbvuSi MynvYau4FghSHTGtaFEZ5nuJ6kmC+tdcLqBETc700vknfUpCm7GRTPnLN4zrPBJKdvoP PP54uYLFfnbBgHOlVqRcsfiKINn8vKtpZG7/NM3E8XgdrtGzvwwVNOaC0h5Spbjew/gI mnlg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PBMCa0sX; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-64055-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64055-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=2; AJvYcCW3jvyn/h1jvl/PKEznF0F3XkOW/vyOlfmdcqvwV8hvfyxZLHB5xqHuYxoKRGRnUSBXj4BEgtOooV5BE6gVsCWrXdvGnQ== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id n11-20020a170906b30b00b00a3cf04c5dafsi1087029ejz.198.2024.02.13.10.08.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 10:08:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-64055-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PBMCa0sX; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-64055-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64055-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8FB1E1F2468E for ; Tue, 13 Feb 2024 18:08:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EA9E96087C; Tue, 13 Feb 2024 18:07:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PBMCa0sX" Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD0F6605BA for ; Tue, 13 Feb 2024 18:07:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707847672; cv=none; b=BOr/UiR8squ+TPox64Q4VIygsYaB+yjg6aWr9uN0o+g3NHmV2ASNqsTHCT/MphmyGx+XUY5HYVLHZPM4rb5qi9oZ+j0O6lr7pir1FKf6iEVVjcGhkuhWESifpG0baa5OMhWUgHnnEjQEHufu6wqMjZpgAx9F2gR5IsVHX8iVInw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707847672; c=relaxed/simple; bh=GCgeemHEMjZObr29TItNfoPRYs3mnZZ8ua3W5kWq4mY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=RM7XH2azJeJaXWiVSKYj812hgvwL2l8cUaaK9YY5hd6VPI69zYGMvGvG4yYl+JxStYie5Y+1hCLPrVb/gsh9SgqXjKoCGr0vXUL50w64cxuZ2c0RUciCjAjT8vVZ1iZUqF5Wj9yMu+UxedfUENUMCO9LW2jCoGRa2Z+e+FS/aas= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PBMCa0sX; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-55a5e7fa471so6117919a12.1 for ; Tue, 13 Feb 2024 10:07:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707847669; x=1708452469; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=7nvXkv/btphQ8MW54HksmzNQa+3jvkr/X94Oa7LChw8=; b=PBMCa0sX68glYuVtRESYoGSy5EYLyelv1inhXuWb2nqhHbhRa6+qB6CzCozLvEguq1 kDxy3kLIyfvmCvKbE4ZTkKlm7A3XbkbTRSxR4NOMOxEiRJ2GyaOgejcVKvj3gDV3BvFb SECW2+G4I35sfl0vP5OjHcp060Q/QLOXFZhj99I78jcQEHXz3njEOpwGVFvo1Jy+BsxH aft7GnkCspwYbV40KJIpgkdQIC5E6yQjcX3sqSHZ27Pe15Kh6ftWbldAREA5YWvPHV3r mK6gz6yhLYf5aDHXkzXGuZFsGPPfshCPds2+hcRcXsumua8jmkcW5s+tRIn0x50s01gE +C+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707847669; x=1708452469; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7nvXkv/btphQ8MW54HksmzNQa+3jvkr/X94Oa7LChw8=; b=BNEV52/mlspph1rHSJQQedgHzVYAZVRk9h5tEWAsEXbt5RnzJkmrSruzEP2HNfyzdb 31B+XUDMVXe/cygeNzAgwG3OPta3LMoCIFAPddwmI1dmQeHXB9HI2nNnVW/pnm9AlY5E D9aqEjYJqaBT4cZs1xTYG6NiD0/nGf6VtXPDOe1R3RhNOzlOQIt2Nsh92gc8CDeUDEKi bxn35Tkp0ua1HqbnUT6ID17cMavsE6Pw5b8tj9PTE7bBHpRwsjks62rVhi5aZ9r6aYzJ XGmQ5fsuW2RPjsTJLIl2mCvJMG15jZXhQgQHa0Wad1m8mGNZAwA35KP045q3UOKfRVZ3 BkHQ== X-Forwarded-Encrypted: i=1; AJvYcCWbYwunLJa4LyCRdzf/aSPwqAMu8rL/A8K5eUr8RQlJhz90WG7VrgydMAUGYFj/KEOcf5/w0JsJDDXiUI9i9xLGPbKli+X7yC6zlQaz X-Gm-Message-State: AOJu0Yx6jQyeg9HSuf+2RAIhfXFc01eaLNqhHWy9I5lNGxEVkzeYL8bD vOtL8d6v9SDtct4EGrQ91aeqXkS8vKbuP0YAvJN3iJpBebopg1AF94+XcYaWMJs= X-Received: by 2002:aa7:d752:0:b0:562:1083:b7d7 with SMTP id a18-20020aa7d752000000b005621083b7d7mr311615eds.3.1707847668986; Tue, 13 Feb 2024 10:07:48 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWrsKCNbf/H0BamORPHywycyrYJdRpP/MwEAylAwHFCf+pPW5AVS441po4B7fqyI8k9/YOXHdY3yHcze2IpAwPjUOYk7MRBB6D9Fxz9CMUHR8WPiocNWVasnjrrivezy6GFP8RMbcBCR1aRJNgi11vYB7EsWJTmMCro51Cq4t/HpNAE7aXCG4ys7jrY7/TeKL1iX76vc5SwjnwOCL4tp6gnko4= Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id fk7-20020a056402398700b00561a443a393sm2498874edb.92.2024.02.13.10.07.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 10:07:48 -0800 (PST) Date: Tue, 13 Feb 2024 21:07:45 +0300 From: Dan Carpenter To: Thangaraj Samynathan Cc: Mark Brown , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] spi: mchp-pci1xxxx: release resources on error in probe() Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790808127647584936 X-GMAIL-MSGID: 1790808127647584936 Call pci_release_regions(pdev) before returning on this error path. Fixes: 3e7cfd6ad29a ("spi: mchp-pci1xxxx: Add support for DMA in SPI") Signed-off-by: Dan Carpenter --- From static analysis. Not tested. drivers/spi/spi-pci1xxxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-pci1xxxx.c b/drivers/spi/spi-pci1xxxx.c index a99db6163aec..969965d7bc98 100644 --- a/drivers/spi/spi-pci1xxxx.c +++ b/drivers/spi/spi-pci1xxxx.c @@ -776,7 +776,7 @@ static int pci1xxxx_spi_probe(struct pci_dev *pdev, const struct pci_device_id * ret = pci1xxxx_spi_dma_init(spi_bus, spi_sub_ptr->irq); if (ret && ret != -EOPNOTSUPP) - return ret; + goto error; /* This register is only applicable for 1st instance */ regval = readl(spi_bus->reg_base + SPI_PCI_CTRL_REG_OFFSET(0));