From patchwork Fri Dec 22 22:50:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 182798 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp1371814dyi; Fri, 22 Dec 2023 14:54:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IFWKDA2AOnw04xb0QM7X1aCMq3WoRgF6shUg0HpNb1z9HkdvEHvWXH2OOcUrfHlm2Use8DL X-Received: by 2002:a05:6a00:2af:b0:6d9:93f1:dfe1 with SMTP id q15-20020a056a0002af00b006d993f1dfe1mr789169pfs.5.1703285657243; Fri, 22 Dec 2023 14:54:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703285657; cv=none; d=google.com; s=arc-20160816; b=LiQa/rDeQch8883Ji/bDt1N88eeO7UgQI1jwZ8toUCQpt+JOqs2Azhrp+t9hcfYqol KeY8e83dHFdKXPh8wJ5uVTiFKTIQoSJhhq7nnuHsY95x/7uNq4YytqRcUs8tI/A77pjy uigi2Z8YwuHBBGdqrris1l9H8FWP/1Y78vQQz4wzwsS4ZeiM0mv4tShWh0e3Lwp7Qm5N ld9adckyahm67KStnL0R4vJ8ipFDkdPTDB0mXV76CfTCznMEds0oJaWOP6dfXaCzQIAl WDJ4Pl1TrZJ3H8BLOrpk+1FokM3Z4gwxwwim5D2H1Xws73mGMOpS/8V+rqMM4og+csGo bZyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=XjuM9OCJRDwjYrfDyUzbBy8oQyOLp1qPzrmWQx0dTGM=; fh=/7k3G5kYgdzNREH7N5X6ApKxsFgwBo/+qx/r7G5UAw8=; b=PIQHzcdbF9t5+rRFg67hGC8UXbd7CS6kdbUMshekrWoe4Cm+EJ9j/hQGolmKuhWw84 1BOJX0q2I9NEP/KEzPWMDWnBvhY9KUEZZz2EJM58olG/Ffbr0IfBXa9AIRLVPjrCAh1T bR662ecGAn6Cm7iMQMPfeKtSEiVyzomSTkcM+nNc96nV5FJMbaHUlICbct7ELevSzw8K DKsyJVXnWPtgutYmmo4kmEhJNmYuUC1Ip7YVbvp3ncpMRbyUhWGy+uHjaUOLZJJAsZip XasVzvwt1dYu+9tr6MnKpg+Lpk3R4ra9rWx8eSsq7GttNGcus3+/heXpfRKEL470EaAw xmrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10101-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10101-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id cj22-20020a056a00299600b006d99b0fc958si395503pfb.155.2023.12.22.14.54.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 14:54:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-10101-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10101-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10101-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 08CC7B23E2A for ; Fri, 22 Dec 2023 22:54:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1063E3987B; Fri, 22 Dec 2023 22:51:28 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0981F381BE for ; Fri, 22 Dec 2023 22:51:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rGoML-0005Zb-AE; Fri, 22 Dec 2023 23:51:13 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rGoMJ-000quy-IS; Fri, 22 Dec 2023 23:51:12 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rGoMK-000Ff8-1s; Fri, 22 Dec 2023 23:51:12 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thomas Gleixner Cc: Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 02/13] irqchip/imx-intmux: Convert to platform remove callback returning void Date: Fri, 22 Dec 2023 23:50:33 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1784; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=4EOrr+KkEGskg0P1J9XoWIGL8rKAKsaZhlgGBH5sOgo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlhhK5wCvDc6ILPQThuf+7sez3z1TdJh7yxJ24I 1sfizwPvvyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYYSuQAKCRCPgPtYfRL+ TurYB/9xFiFUgWxcVzchQkEssIjqdO3bOh0+LZnN5kDZlcdcvByn6cNaEDhBNexJcJBzYHNqcnv 4Y4PM8PpVw07Bq2T3PpWwyP50Qnqx+hAL8ULOFvYY8FSL88chdUC5ERpkqPXXwugOuInqnoMzIE m/3922hXTJ7IZIxDJbL/0aXIGWbdsZPI9l1GNAXPCSgdvgMNKqXNiRTQ0yv5xDEzZ+ZbJ77DJwS u5rQ2hFjE6rmzQ11yq66KKK8onKBiJgc6JtsTX4FCuMXJuv3OQQXFh7P0Tltq7CCLd/rixwmIjJ +xfL9Fwyh4PYJRDuPXh8xuwM2kJ4rSYwz06GqW4YRIk9exUk X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786024461383709780 X-GMAIL-MSGID: 1786024461383709780 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/irqchip/irq-imx-intmux.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/irqchip/irq-imx-intmux.c b/drivers/irqchip/irq-imx-intmux.c index aa041e4dfee0..de292bde058f 100644 --- a/drivers/irqchip/irq-imx-intmux.c +++ b/drivers/irqchip/irq-imx-intmux.c @@ -282,7 +282,7 @@ static int imx_intmux_probe(struct platform_device *pdev) return ret; } -static int imx_intmux_remove(struct platform_device *pdev) +static void imx_intmux_remove(struct platform_device *pdev) { struct intmux_data *data = platform_get_drvdata(pdev); int i; @@ -298,8 +298,6 @@ static int imx_intmux_remove(struct platform_device *pdev) } pm_runtime_disable(&pdev->dev); - - return 0; } #ifdef CONFIG_PM @@ -359,6 +357,6 @@ static struct platform_driver imx_intmux_driver = { .pm = &imx_intmux_pm_ops, }, .probe = imx_intmux_probe, - .remove = imx_intmux_remove, + .remove_new = imx_intmux_remove, }; builtin_platform_driver(imx_intmux_driver);