diff mbox series

[v3,6/6] sched/debug: Dump domains' sched group flags

Message ID ed1749262d94d95a8296c86a415999eda90bcfe3.1688770494.git.tim.c.chen@linux.intel.com
State New
Headers
Series Enable Cluster Scheduling for x86 Hybrid CPUs |

Commit Message

Tim Chen July 7, 2023, 10:57 p.m. UTC 
  From: "Peter Zijlstra (Intel)" <peterz@infradead.org>

There have been a case where the SD_SHARE_CPUCAPACITY sched group flag
in a parent domain were not set and propagated properly when a degenerate
domain is removed.

Add dump of domain sched group flags of a CPU to make debug easier
in the future.

Usage:
cat /debug/sched/domains/cpu0/domain1/groups_flags
to dump cpu0 domain1's sched group flags.

Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
---
 kernel/sched/debug.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Valentin Schneider July 10, 2023, 8:33 p.m. UTC | #1 
On 07/07/23 15:57, Tim Chen wrote:
> From: "Peter Zijlstra (Intel)" <peterz@infradead.org>
>
> There have been a case where the SD_SHARE_CPUCAPACITY sched group flag
> in a parent domain were not set and propagated properly when a degenerate
> domain is removed.
>
> Add dump of domain sched group flags of a CPU to make debug easier
> in the future.
>
> Usage:
> cat /debug/sched/domains/cpu0/domain1/groups_flags
> to dump cpu0 domain1's sched group flags.
>
> Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>

Reviewed-by: Valentin Schneider <vschneid@redhat.com>
diff mbox series

Patch

diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
index 1637b65ba07a..55b50f940feb 100644
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -389,6 +389,7 @@  static void register_sd(struct sched_domain *sd, struct dentry *parent)
 #undef SDM
 
 	debugfs_create_file("flags", 0444, parent, &sd->flags, &sd_flags_fops);
+	debugfs_create_file("groups_flags", 0444, parent, &sd->groups->flags, &sd_flags_fops);
 }
 
 void update_sched_domain_debugfs(void)