From patchwork Fri Oct 6 19:05:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 149384 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp537853vqo; Fri, 6 Oct 2023 12:05:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEsPVA/SgD6zNotyQEJXqU3kElKWZEocRGVHlwk09hQAnXlFVFDqpC9FnT47Gl0btzzuwAY X-Received: by 2002:a05:6a00:1781:b0:690:2e46:aca3 with SMTP id s1-20020a056a00178100b006902e46aca3mr11114288pfg.25.1696619145792; Fri, 06 Oct 2023 12:05:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696619145; cv=none; d=google.com; s=arc-20160816; b=dik7XtaEoRu4s9ZF7BJW6HEgS13pYRufa1JPEbGsMv7wayMWw53Umxd1ivCLZaoAxV Nj6MhtfLFyUywHJiEnHWJOMloSQLZ4eozhuO8SmOhkzpXyWk1pE5y07nn716iaR2EnQu NatQdlBVwqGYOzhamvszyPQ8HmloD1FepgjZl+li1/f18Ex1PQZevoqphusbyaL16bZK V1s5wzb7UpCoxNDzI0CTP7x/6h0X9TuPgfAg1jYblNy+mXQxfz48+10ZzgMCVZ3AgV51 DKAtYb8ARxYZK1bQsJj9a8yh1+EUdc8FjPAoWXpt7VPrvXKpfq8q8xj26Ro2N93ijnL2 1u9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=frWFn5a7WskkCNBBns5qHFEWZyzl6mTq0HND4RnFXso=; fh=Sw1rtAM+hKyOoOQVYiiLzcdjc4spg79Z/tN6UmWUAKs=; b=UCZVz6LJMUN5njd50x1VAaRK4xruytGafLcDp5A57mVwWR2DOUDvzPImENFPSMISG0 Jm444hbHlTvxR6jcTe11b4pJoc/QJOl/G8I/hTSeytL4iRMbR38xsitjDMnr4gsuusKG bxW5i83CEtHa7b0BqMkxv8mSPjlK3BkMVcI8un2rIGMj1Jxq/EaADBmua6K4mYUZdcwF lp/CSp7F9sbnJrwxTPBN+IKQHTeO3S9b/u1t7HT2nWjtjbx6SYyRCq+NGpM1BLsv9Wos V73FFr/xfZjUBRmm2gMZQ+Veb3Fn10BuGjYck6pJpsL27QtAO+yYHEMafPMoOhvKnukZ gqqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=mwVDpUvx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id cr12-20020a056a000f0c00b00690f0a78ecesi1968525pfb.315.2023.10.06.12.05.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 12:05:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=mwVDpUvx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 2A053802645C; Fri, 6 Oct 2023 12:05:29 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233352AbjJFTFV (ORCPT + 18 others); Fri, 6 Oct 2023 15:05:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233109AbjJFTFO (ORCPT ); Fri, 6 Oct 2023 15:05:14 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F099DF for ; Fri, 6 Oct 2023 12:05:11 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-9ae65c0e46fso98998366b.0 for ; Fri, 06 Oct 2023 12:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696619109; x=1697223909; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=frWFn5a7WskkCNBBns5qHFEWZyzl6mTq0HND4RnFXso=; b=mwVDpUvxDlAVx81FARIDNZ6YeAJXsET5mQygZV42hsVULI+tnRewgM8ndkhttzhhuR APSErj734lGk8yzUY3mVqSjI41/C/mk6ca5LQIgNUvVm2gVRgmJgDPp6DrRBMjcTtmpz w0e8+mxbsuOHqVF4r0UqHB9DiTKpjIIElzHj/0XKOBFQ9Mpnw0k6kS1tHxDRey4L/92X kyFueZ7F0iARtPj6+R2aQj41HTJVdqV5nZMLuJJAFAgcWLETKDRKxjwwKWYl0fC7diVk qhNfWCQQ3yKd5Yq77aQXjlDrZjY9DVQHBJgoSuN3iUALoavoQfTo8ftQX3uod/uRNmBV WWWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696619109; x=1697223909; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=frWFn5a7WskkCNBBns5qHFEWZyzl6mTq0HND4RnFXso=; b=cpU6u6L5yjeeqYvqoEgUIDnir3+DLqm78S7REP6v/vVHqozFxz2QV7zY0Ze8E5opkR llsvXDp5FUwVN9dHxC2XqI44ulZ7P/oyvPRkX1aKIoo1bGqiDDobyRfo8NjI1/OkwEkf /dQnXvfrKTZqCMwOUFVwokrItcvMNsoPH09xnKPOKHFdXZlTyh0lMPEzDxPBmOWOcFGG I+lgO71dE7x7yr7Ighl6Y/JgTWozqgE4kmqr0r8aNFE1z+Y3hM8IGtRyDM4D1bkopzR4 wsqJmUlx4z21zFjLTfm4UDP5jMM8KTuiuaYqsyPFwPmMAtWtuOkjGBHVzweu2zE8LseL QlVA== X-Gm-Message-State: AOJu0Yy+hdtIA2z8FcKd0nf+pcWf5q5itI2p67IR9s111QSRz5JEGkg0 XmlvN2HKY35bdJ+bqkPwFJY= X-Received: by 2002:a17:906:2255:b0:9a1:be9b:c935 with SMTP id 21-20020a170906225500b009a1be9bc935mr7672676ejr.0.1696619109546; Fri, 06 Oct 2023 12:05:09 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p579356c7.dip0.t-ipconnect.de. [87.147.86.199]) by smtp.gmail.com with ESMTPSA id lf8-20020a170906ae4800b00992e14af9c3sm3326901ejb.143.2023.10.06.12.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 12:05:09 -0700 (PDT) Date: Fri, 6 Oct 2023 21:05:07 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 05/10] staging: rtl8192e: Remove constant variable ps_force Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=3.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 06 Oct 2023 12:05:29 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779034117852402685 X-GMAIL-MSGID: 1779034117852402685 Remove constant variable ps_force as its value is always 0. The equation results accordingly. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 1 - drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index 4b2ee1684dac..d4e998cfbefc 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -263,7 +263,6 @@ struct r8192_priv { short promisc; short chan; - bool ps_force; u32 irq_mask[2]; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c index a4da11627199..44a9fe831849 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c @@ -181,8 +181,7 @@ static bool _rtl92e_ps_set_mode(struct net_device *dev, u8 rtPsMode) { struct r8192_priv *priv = rtllib_priv(dev); - if (!priv->ps_force) - priv->rtllib->ps = rtPsMode; + priv->rtllib->ps = rtPsMode; if (priv->rtllib->sta_sleep != LPS_IS_WAKE && rtPsMode == RTLLIB_PS_DISABLED) { unsigned long flags;