From patchwork Wed Jan 10 15:42:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 186938 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp875072dyi; Wed, 10 Jan 2024 07:44:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IG6/y57Yc/RhxKtFB6b4x8ZgCcspMsoaghEnHl07rMS0Phh8+Xpyzhvj3vySwrFgdJ/pwAE X-Received: by 2002:ac8:7d49:0:b0:429:9b76:489 with SMTP id h9-20020ac87d49000000b004299b760489mr1478302qtb.82.1704901475495; Wed, 10 Jan 2024 07:44:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704901475; cv=none; d=google.com; s=arc-20160816; b=hZ2K2JRmZWGBVSuxVmLQc+LAk5T6pM9tcg0zHiYsKbJYfWH6NcPH94UMln8TE7awA7 RkKM0uQk+BDkfeScD2G31HT9OvC6LhpdKsjkn7CZ3l1Nu2supAPBHFY0JHodVufBe0fW MNLJQm4c0rpP0U1wUgUYjQ/+15d9kZHbZJkRrDycGTuC29to00Y0nKCDYNkYHkIXhrx7 P06w3qv7Cmpj7XDCiqQankWGENFYjngGj22Xst64f0kEbnxv4oPJr4+brIH+Ex0+gd19 YHDYAgy7FTP75BQf22sURQTXWyJwEv+X1FeTBRNtyl5vmuRLA52U/i38ub07dm8bJwOD r9MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=ZpCOY1I+Xccp2Ej5iBGu1LfLkwUl+hojRrQKkS0gkuk=; fh=SqPi9dDHXtQdEcWVPls+hhXQkWQrXyuO3Tueytp7Eac=; b=WSruvLXVAniarXWbmIE7cOAeReXSaLM6Vh2LtqibeHafgepZTcW5t1/XLMTWlrs1kw NaEWx18Sb9DVHhuhUinRSWg0IMaVJZTHcXoEhnfqh/d1KFk2ptXt7y2tgHVeW3xIsYZV zw1zrNOyIBbfuSz8GGufYvtN3RlNNyGggOIuMrj72MYpufSRj804wo8zjrIrE3lvyJH/ nC4HAVmsxgXQTCcBKiVN0caGvKQOtlkN4/IF9ex2VaFv/XNp2zLA3BT5iorMU5ZD8DiN 8ehuviWvRHwpAnVcNku8Kil/25HjpiBz+ZdvFD0ffyz8ChqcxYeirK6vv21Qjjcw/5oG RE7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-22443-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22443-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id cr11-20020a05622a428b00b004299966ab82si4251640qtb.391.2024.01.10.07.44.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 07:44:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-22443-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-22443-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-22443-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4B0301C262F9 for ; Wed, 10 Jan 2024 15:44:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EB0D54CDF0; Wed, 10 Jan 2024 15:43:26 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6953D4BABE for ; Wed, 10 Jan 2024 15:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNajS-0007JI-A4; Wed, 10 Jan 2024 16:43:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rNajR-001jUb-B5; Wed, 10 Jan 2024 16:43:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rNajR-006c4L-0s; Wed, 10 Jan 2024 16:43:05 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/7] macintosh: windfarm_pm112: Convert to platform remove callback returning void Date: Wed, 10 Jan 2024 16:42:49 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1592; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=EDHxRAEtSZEx4PMN+NHAvrn9dvdslr8ymxAgEO6mM54=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlnrr6o9vZrpebD10MOZdZmw5FqvDRtlGuQv/Ny lxuC0t+3OuJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZZ66+gAKCRCPgPtYfRL+ Tp7yB/44+RH1GGupIvmLoyJcQ16OpEyinOqC00OpPqyfAfbw3z9vVNi/5wuWHkgslkcesPpl8Ja efsFt7RPCCjg8rdtgPd4oW1Yf+6msVDzFuDp2fQ/yLPyaUhv4k2h74bYqoRkXhblqA3PNkGAjYa +s44DBpjCinsW2hbVAA15PG2s5LSIDJ5n4hVIf5/b7TwHJKi4mvgNpP6tk6zm2wDmb84SIztiVe k9dQKxbdZPgP6b1tKyasQ4ZjfKS7SnGJwH001v1DeS1AYBrD8322Skl6B6gC4DLZcW36LIfgnMO ppZKVTjOgghEXntnJ1uLoichovITKRqWsC4jJ8PhtoVc3wOK X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787718769578027290 X-GMAIL-MSGID: 1787718769578027290 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/macintosh/windfarm_pm112.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/macintosh/windfarm_pm112.c b/drivers/macintosh/windfarm_pm112.c index d1dec314ae30..876b4d8cbe37 100644 --- a/drivers/macintosh/windfarm_pm112.c +++ b/drivers/macintosh/windfarm_pm112.c @@ -662,16 +662,14 @@ static int wf_pm112_probe(struct platform_device *dev) return 0; } -static int wf_pm112_remove(struct platform_device *dev) +static void wf_pm112_remove(struct platform_device *dev) { wf_unregister_client(&pm112_events); - /* should release all sensors and controls */ - return 0; } static struct platform_driver wf_pm112_driver = { .probe = wf_pm112_probe, - .remove = wf_pm112_remove, + .remove_new = wf_pm112_remove, .driver = { .name = "windfarm", },