From patchwork Thu Mar 9 10:12:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arseniy Krasnov X-Patchwork-Id: 66753 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp214609wrd; Thu, 9 Mar 2023 02:38:22 -0800 (PST) X-Google-Smtp-Source: AK7set++4tMgKZW0wfz6xzSiAoSkrXB2IB+wrWW7US45+Vq3qjQw57TCmIxZUhPiEj5bD3M71Puo X-Received: by 2002:a17:90b:4f47:b0:235:82d0:3a36 with SMTP id pj7-20020a17090b4f4700b0023582d03a36mr22954309pjb.41.1678358302143; Thu, 09 Mar 2023 02:38:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678358302; cv=none; d=google.com; s=arc-20160816; b=Y0SFGMQCM5uELe54ZM1WIjyRR4dSBgg66H9JfH+9xF+M3WCGFgoxzgG7mJTnueLlJl ynN1xZ1qIVEDXogzSJYoKe7oXQOHEM/0AuZ4E7lxgNhxbT3nKT/xYD9MxEYOTeguD2ni i/CA9Qn3Z8MOeDKLGu06BhE6ckstxjGTht7EX+5MWJN0tLftQN+aHm01YbDOuhsiibHU PdbdQtLL9GhQDN88bbU0MpGqMI0HXwHj8/6GAvIJHhNpQdHvPGNTCZU3D/8/Va3UPcT5 feIJfQNCU94yGrftoblTY6AShTS7eBn9SVbxyZpILourjMR7TeoL/K32dCKZxN4i3N4j zI4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:subject:from:cc:to :in-reply-to:content-language:user-agent:mime-version:date :message-id:dkim-signature; bh=pEUT86ikon0sBC2KSBuNIGLhBhGsTeozoRveheVlr4Y=; b=HvuN++eryoX/F5L+aisSdYKfuEoeyBY02yhDFhinWyoBwR88Le5XkALhimVFFC7q3Y yK3BlIkyl51J1GGyQRXbQhzk/s0qMG/RjuIkpbRLS1KxqJ2UTKnfmggriAvynsV5mRo4 rXDDViEUcYyi8SChgukryNjNjDLHKRvCtYdSVYcwiKB5sHBHfNTb6dLvkvrqWzC6O3Ml gDm6qKlZlC707fj5eouQ7I16PO0zjvsOb79kJYSJgobndoK/q6oPlWn4Nszjlr8+m8jM OB+IZfeACb3W/8k4iCRLPJkU3CEKjp95maWODw4IT5V2onwjhUMcfcFljdNZHLegRdS2 HjrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=r7xIN1aI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l6-20020a17090a598600b002192eb3532bsi1906441pji.116.2023.03.09.02.38.09; Thu, 09 Mar 2023 02:38:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=r7xIN1aI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229817AbjCIKRR (ORCPT + 99 others); Thu, 9 Mar 2023 05:17:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231381AbjCIKQ5 (ORCPT ); Thu, 9 Mar 2023 05:16:57 -0500 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBA61EB89D; Thu, 9 Mar 2023 02:15:59 -0800 (PST) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id A911F5FD38; Thu, 9 Mar 2023 13:15:49 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1678356949; bh=pEUT86ikon0sBC2KSBuNIGLhBhGsTeozoRveheVlr4Y=; h=Message-ID:Date:MIME-Version:To:From:Subject:Content-Type; b=r7xIN1aIeFVncexr7O9vq3lT3Yp6jfhNFezQpoVfUsCnEEW67fBB6RthuzpWTAB/8 cA5KG/Ig38O6ypd7baQxpmnwu0Q0/wm4RnvzJJFS/Ile2fRBstzc/NUflyp9p1oYmC rFOoRU3rcCBb9KiuZ71MNbADrDlphpnT3lM8lq9HQJzahar7g3zdN8DH4SBrao2JRL eJtqrmYaL8trWLPcp3GQpcNBaOW6VYqb1InqGy7rLDJvmbPgIgbBi3NW002vLrscxF sn8SLtIymetqF8/rwOVIa2Fk4j6Ktpc1QIXsjH4WZ5n5K0PcU8+RReSjfqdGVn4BcE 6U/McRUC5a5gg== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Thu, 9 Mar 2023 13:15:49 +0300 (MSK) Message-ID: Date: Thu, 9 Mar 2023 13:12:42 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US In-Reply-To: <0abeec42-a11d-3a51-453b-6acf76604f2e@sberdevices.ru> To: Stefan Hajnoczi , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bobby Eshleman CC: , , , , , , From: Arseniy Krasnov Subject: [RFC PATCH v3 2/4] virtio/vsock: remove redundant 'skb_pull()' call X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH01.sberdevices.ru (172.16.1.4) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/03/09 05:43:00 #20927523 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759886234758605963?= X-GMAIL-MSGID: =?utf-8?q?1759886234758605963?= There is no sense to update skbuff state, because it is used only once after dequeue to copy data and then will be released. Signed-off-by: Arseniy Krasnov --- net/vmw_vsock/virtio_transport_common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c index 618680fd9906..9a411475e201 100644 --- a/net/vmw_vsock/virtio_transport_common.c +++ b/net/vmw_vsock/virtio_transport_common.c @@ -465,7 +465,6 @@ static int virtio_transport_seqpacket_do_dequeue(struct vsock_sock *vsk, dequeued_len = err; } else { user_buf_len -= bytes_to_copy; - skb_pull(skb, bytes_to_copy); } spin_lock_bh(&vvs->rx_lock);