From patchwork Fri Dec 15 13:59:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 179306 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9294961dys; Fri, 15 Dec 2023 06:02:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IHJvg4RblerKfZgwNkSxB1sXWPL/0FWD3CsFInef4ztXOeL4lmV15IHpunYQSpg+xfeZVxh X-Received: by 2002:a05:6a21:3284:b0:18f:fe5a:8bb7 with SMTP id yt4-20020a056a21328400b0018ffe5a8bb7mr15008519pzb.24.1702648925207; Fri, 15 Dec 2023 06:02:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702648925; cv=none; d=google.com; s=arc-20160816; b=OwW+/eevjKXvjcvIuI0GV10CaCS2iv7CyjbPAb+t3UNwvEh/KhFspSUnq/v17lyqq0 jkkOsK3Kk78J/bZLKPJn1DAHhYFmvY1MR06x1vCOFyfD2E2V9Bu2Ca69oGUz1pCVsMp8 T7DHQIg3bcrrGuuQ/SHBcGDQoe1S9COUWoiTMXzmRt7rWOVTmChPBKeGHvi7eKvlSFCT qhGWgkNgRZ9RAyfzZWDcQPhCYkCAy2o3aW56JPMaYyLTiWAEOTBQgTqVcxbh5XEnUrGi 2Y9EYyQUecIf7scDZ0ip24dLggPrTazgA6sSFKtt4dgKTvmAArB3hycP037tRc8+wBYs okAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=TAZJc/+xwIskJrZvGHIDnJUjZag7wjuy3W0Mr7EqaEc=; fh=yY0p6r9TqiQ7YWvi8qfnuiO1YPt0Ex1ckNvhVavPlhU=; b=0nRdL+yBzE+JCUmUAqwqaIYt8OdScxSfPKDAA5cAFYohNkyTmmXx7bWj/uwrx8WTHq t3sgRIltCjRsx99utBaKrdicU2xZFCjR7YWpQo5W7YycAsc2MJ+IL4JUqYLlJ1d+BJ1V UkP0LghMSt9BR4IeUp6uw6DEuo2+FcWJWN+nkaCM6rVWC4tjAYcRkVyi/cN1WEj5O64p jQ2gkHoTDsJ/R4Nd69V9Q9boa6GRcOXKkub9M0ci9LVv94++p1n9HBHRu6dWqjD01rzi pD0ovghIzBLCYtStT2NxPxAQzu+mZ6eV7GXWUQabIEiECWbzjnxw9TvgTgd7+vhFGiqY y/ww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-1059-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1059-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id h10-20020a63e14a000000b005c67bb15866si13222640pgk.52.2023.12.15.06.02.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 06:02:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1059-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-1059-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1059-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7EFE7285A0B for ; Fri, 15 Dec 2023 14:01:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9DA2B34CD3; Fri, 15 Dec 2023 13:59:40 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7B763066A for ; Fri, 15 Dec 2023 13:59:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rE8iu-0002lL-Sz; Fri, 15 Dec 2023 14:59:28 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rE8it-00G2ZG-QJ; Fri, 15 Dec 2023 14:59:27 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rE8it-003cC2-GP; Fri, 15 Dec 2023 14:59:27 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Will Deacon , Mark Rutland Cc: Shuai Xue , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/18] perf: alibaba_uncore_drw: Convert to platform remove callback returning void Date: Fri, 15 Dec 2023 14:59:01 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1930; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=9FC259Rv6/1RNxYI95FF5rVsM1/6UsMv70AkNQrVF1Y=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfFulZf+lV8nfqy5ovLYczr2QJtaFXTDh+Ik2H irgtecLXjeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXxbpQAKCRCPgPtYfRL+ TrhnCACSDh21/DkEFLG9vdQ8DL85RDI9U9NJtmDImJCs1mt5MmHxD7nUcmXvAVxOW7SkVdNhReG MScmbD3s1L3D/usi78y8fSzSfTv4jqbCYRQrcMPStisxaxQjSlq/OwsfE7GBURPUjjT2Z6sffjr eWr+Qy1P5EcqPhiaTqlejucbGrR0qOJhppx1mkE0RpCoa/l9DOzrOZ6qK0jZ37TzjEJJL3TMO4B bkVE35ZkgAYM3iL6ovK3PXvy7NFhp5aFzjDiO0AzgVj5aWiPT/DTjl8NGF4fo2AiOgeUuVud0HO ynbJpiHs8g8kvs17Bxg+eqZj/Lp51b0Fbcr+sBs4YlBfHz7M X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785356799726905592 X-GMAIL-MSGID: 1785356799726905592 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/perf/alibaba_uncore_drw_pmu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c index 19d459a36be5..a9277dcf90ce 100644 --- a/drivers/perf/alibaba_uncore_drw_pmu.c +++ b/drivers/perf/alibaba_uncore_drw_pmu.c @@ -729,7 +729,7 @@ static int ali_drw_pmu_probe(struct platform_device *pdev) return ret; } -static int ali_drw_pmu_remove(struct platform_device *pdev) +static void ali_drw_pmu_remove(struct platform_device *pdev) { struct ali_drw_pmu *drw_pmu = platform_get_drvdata(pdev); @@ -739,8 +739,6 @@ static int ali_drw_pmu_remove(struct platform_device *pdev) ali_drw_pmu_uninit_irq(drw_pmu); perf_pmu_unregister(&drw_pmu->pmu); - - return 0; } static int ali_drw_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node) @@ -795,7 +793,7 @@ static struct platform_driver ali_drw_pmu_driver = { .acpi_match_table = ali_drw_acpi_match, }, .probe = ali_drw_pmu_probe, - .remove = ali_drw_pmu_remove, + .remove_new = ali_drw_pmu_remove, }; static int __init ali_drw_pmu_init(void)