From patchwork Tue Nov 1 13:49:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deepak R Varma X-Patchwork-Id: 13674 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2978170wru; Tue, 1 Nov 2022 06:52:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5rzyIFVaErp2npfX+AOm7blPH8AX7EGu1//o05ugHx4s/7WNAJQNWKyel8cBwU14S417DY X-Received: by 2002:a17:907:210f:b0:78d:20f7:1294 with SMTP id qn15-20020a170907210f00b0078d20f71294mr128043ejb.442.1667310736557; Tue, 01 Nov 2022 06:52:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667310736; cv=none; d=google.com; s=arc-20160816; b=NEbnam3Y1UpcYEtxcz0jdZO7iETmg3pBzKVd1yfMc8Tg2UNYIOGOrMvcyBtUzFZgcq 8lVVOU3UDQ8+HSXUbaUQZnUqaivA9rXr8lIwXfaQGuNlt4hbw/qZTAqUP46S8AYMuuIQ Me0pbKE3zoIpcpwIYoFD8w4IX7325oONo1hENBLIC4mC6fwGhhzYi1LFr2eLGy1pd5z0 RERoZcoHZUKiUTlV+JXMvQwo7Ynrks3ZFgI1tknZNC6Qrj3pqWWwv36Dy39lAy/EYpXD GGwnixGveN8ZAl432tkqU9sVFZLKBPrPWERXJdA3t6Ay+yhPGf7DMkzOomGTAkaoRtZE vDfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=U38kfOh0JF0Y92GZMH6SvzrXPNiYnJlLsEK4J5eBLgI=; b=uQ5z5wVYZ9xjx+L+NgIL1YZMwMXNKIsMfXjf5O7lybIcQ1Xxg593X7jHzlv26js8PE qoGLF0aS2ISaxlZ34fXV/aE3YjyCbnQhtBG05UvS3JjalzkmoUQs5yLSOgDjKwpHq8ox EmTjnKSsL5nCvrmyEcqjKI6dL0nfXmYmMQramUzxCIXgryQL++Fp+EpZx4AiW1ddD62m Pd+YKcEuO7uIdPUHxGoNF4L0cQAzpzE+o0sv7HVjv6AY4UtdsipUpbR3d2XL7hr+S9H6 RYVN71X7Dnx6n0IM5oFNEgtt6+eCA+D+Kv3pMjegj2wtQsqYgtDPrYbJag7edkSPUmfE deMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=KaFOj9jQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qq17-20020a17090720d100b007a0b8eead9fsi9043642ejb.60.2022.11.01.06.51.52; Tue, 01 Nov 2022 06:52:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailo.com header.s=mailo header.b=KaFOj9jQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229528AbiKANuK (ORCPT + 99 others); Tue, 1 Nov 2022 09:50:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbiKANtz (ORCPT ); Tue, 1 Nov 2022 09:49:55 -0400 Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CFE41C121 for ; Tue, 1 Nov 2022 06:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1667310573; bh=YqDTb9YthK+f5gOGsv+KgABsraC6uIX0b8maMGYNFJM=; h=X-EA-Auth:Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=KaFOj9jQ8iO9FyTZo+JvYbqOsfuKwJhsUd8pflLTJ+7lm/zZJ9LW0/ohu4NAUzFD4 zA1uUt+ssNH5ppvove9WZ2fvE8YhgaGUES7//DNpZhuWBsl3ixMrQbXP+LKvusGan3 Xc/532AKC16p5M2RjtftgXSRv3JVLUgllE1C5ABM= Received: by b-5.in.mailobj.net [192.168.90.15] with ESMTP via [213.182.55.206] Tue, 1 Nov 2022 14:49:33 +0100 (CET) X-EA-Auth: XE2K7QgmM9ENyzefGEIHGiLeNNWaodO0XceUBUiw1lnmYFPJbnJ3xq6xR5z83375JTmC4NM2pLOGPu2b1kV5xflX/vLhdMXr Date: Tue, 1 Nov 2022 19:19:30 +0530 From: Deepak R Varma To: outreachy@lists.linux.dev, Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/7] staging: wlan-ng: Remove unused struct wlan_ie_ibss_parms references Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748302023108324788?= X-GMAIL-MSGID: =?utf-8?q?1748302023108324788?= Pointer reference to struct wlan_ie_ibss_parms is added as a member variable to 2 structures; However, these references are never used. Remove such unused struct references. The cleanup also renders the struct useless; so remove it as well. Issue identified as part of coccicheck based code analysis. Suggested-by: Dan Carpenter Suggested-by: Pavel Skripkin Signed-off-by: Deepak R Varma --- Changes in v2: 1. Include additional code clean-up opportunities and combine changes in a patch set based on impact areas. 2. The patch changes are compile tested only on X86 arch. drivers/staging/wlan-ng/p80211mgmt.h | 9 --------- 1 file changed, 9 deletions(-) -- 2.34.1 diff --git a/drivers/staging/wlan-ng/p80211mgmt.h b/drivers/staging/wlan-ng/p80211mgmt.h index d95ffe0097e9..816b25641f5a 100644 --- a/drivers/staging/wlan-ng/p80211mgmt.h +++ b/drivers/staging/wlan-ng/p80211mgmt.h @@ -253,13 +253,6 @@ struct wlan_ie_cf_parms { u16 cfp_durremaining; } __packed; -/*-- IBSS Parameter Set ---------------------------*/ -struct wlan_ie_ibss_parms { - u8 eid; - u8 len; - u16 atim_win; -} __packed; - /*-- Challenge Text ------------------------------*/ struct wlan_ie_challenge { u8 eid; @@ -298,7 +291,6 @@ struct wlan_fr_beacon { struct wlan_ie_fh_parms *fh_parms; struct wlan_ie_ds_parms *ds_parms; struct wlan_ie_cf_parms *cf_parms; - struct wlan_ie_ibss_parms *ibss_parms; }; /*-- IBSS ATIM ------------------------------------*/ @@ -424,7 +416,6 @@ struct wlan_fr_proberesp { struct wlan_ie_fh_parms *fh_parms; struct wlan_ie_ds_parms *ds_parms; struct wlan_ie_cf_parms *cf_parms; - struct wlan_ie_ibss_parms *ibss_parms; }; /*-- Authentication -------------------------------*/