From patchwork Sun Dec 17 14:29:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180021 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp733925dyi; Sun, 17 Dec 2023 06:33:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IETjCek8eBtXnmnHijo9LF/Ocb6oB2lMCHVaUM5Z9GW7jpZnOSfnenJd/hLQhk2pZ+IvRVS X-Received: by 2002:a50:c05b:0:b0:54f:53b1:c941 with SMTP id u27-20020a50c05b000000b0054f53b1c941mr8334729edd.13.1702823613341; Sun, 17 Dec 2023 06:33:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702823613; cv=none; d=google.com; s=arc-20160816; b=JiaB6aDodMXyjA3qWensnK2Hh7F1raoh97QQfaL59nWRvExeuygdii9/pEkJtIRr/M XJpfQIQIlHEjAMSzW0fKxzThkmxt+W83BPrE36KqD2BVIIK3VbCznsu+Yfw3jTx+OJ2N ZseUytBYoTwZW26EUqRaW9SelZZ0fkzl9/ipO8IFzHYGVFxFr4Kl/uN32R5Rwjffv0XJ e8oBT4mv4z7dn09gil99hfo6VAQDmHKd30ViYf4peG2/pKkTL6hCd1pSoPtEDP4bQJJb Y9IqV51KGOU3l8I5PVLA69sKj+lSCAFPhhP3s/hoeJs1J2/AmIof4blaVzaFHNXi0hWc qQGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=3uBhiKvZagbLxIz0w4bC3hU9WRIKGIveBFnPISMeu7c=; fh=JUqUf23jQJn4VKsudodbKzldZ54PJMgJVUGsstYEUqY=; b=0Sk8mK6V1spqVgn+aPQaYgUPGPx+V3glRBgUIwwOxYsmI3HKiYcBH9egDUpC0rj+2f AemX70a2wY8HDDGfNFGBd9O5liXpLIMQ0Hu3BzePCUNEFOmsnvkrUGevpNACfB92xNU5 HnLMAvEO0cYC/6z+u8QO3TT/EGpPbAealVhi7re4mDZXc/PReU5AyyJcD2tZdvvPmiSr Z1uP0TUTOl4EamIHKsge0Kkxl0vcgulW+xOYSNzD0arYyHUeMjuGd7n3SYlBVCssbYO8 arAcArzNL/i9FJ5++LbF3j1M6FwMwSf2EYl+XOON8AqEv5xsm3tEqh96W+YFT3lUfONi PXpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2635-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2635-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id h3-20020a056402280300b0054ca260d79asi9263346ede.248.2023.12.17.06.33.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:33:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2635-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2635-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2635-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B2EF81F22540 for ; Sun, 17 Dec 2023 14:33:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 93D984AF9F; Sun, 17 Dec 2023 14:30:30 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E42045957 for ; Sun, 17 Dec 2023 14:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9e-0006VL-T4; Sun, 17 Dec 2023 15:30:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9c-00GUhA-95; Sun, 17 Dec 2023 15:30:04 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9b-004hyw-W6; Sun, 17 Dec 2023 15:30:04 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Florian Fainelli , Broadcom internal kernel review list , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 02/15] memory: brcmstb_memc: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:28 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1775; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=SpMi1wg6uau+YqEvL4zWCt8cnKaO+rNdF1rNrAv67zI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXHmWa9sJ09D5q7RteC6J2eSV0osYkFrjnhH GFnMTS5CiKJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8FxwAKCRCPgPtYfRL+ Tv08B/9jWNWVJdwg3eqyaHMspo0t4LNc4AS+YH6ZaFbvzn9MbVijqfopM3kx8fgJ91XdeKYJORL LWTgeid/MeA++pW7lAKZZtW+GHuRnndT8NgbXy2NyM8se82jcfVKSFGRDiom/MEqvPQPeTmNzqp j7SvQ0Igl8YTs0dWfgpfwe+xT1vFFp6Bkx3qfRdZXbT0pBAeTNhpHuzJNwDLo6xhKL3A3qZ548v go+HQS7OwjXD/22sZvYqQd8Qk9SQf+d22Atn3maaigOFc/shB+x0EE3Ez2J1jGC6MwfSCKiOP6o w28Sfrrobm7lWlTnMgH++7AwU+o+p4YZojmCgkVxFaxhsZ5s X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785539972907325282 X-GMAIL-MSGID: 1785539972907325282 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/memory/brcmstb_memc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/brcmstb_memc.c b/drivers/memory/brcmstb_memc.c index a6ea51996522..ea9213f7152e 100644 --- a/drivers/memory/brcmstb_memc.c +++ b/drivers/memory/brcmstb_memc.c @@ -152,13 +152,11 @@ static int brcmstb_memc_probe(struct platform_device *pdev) return 0; } -static int brcmstb_memc_remove(struct platform_device *pdev) +static void brcmstb_memc_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; sysfs_remove_group(&dev->kobj, &dev_attr_group); - - return 0; } enum brcmstb_memc_hwtype { @@ -284,7 +282,7 @@ static DEFINE_SIMPLE_DEV_PM_OPS(brcmstb_memc_pm_ops, brcmstb_memc_suspend, static struct platform_driver brcmstb_memc_driver = { .probe = brcmstb_memc_probe, - .remove = brcmstb_memc_remove, + .remove_new = brcmstb_memc_remove, .driver = { .name = "brcmstb_memc", .of_match_table = brcmstb_memc_of_match,