From patchwork Tue Jan 24 22:04:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 47924 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2396821wrn; Tue, 24 Jan 2023 14:12:16 -0800 (PST) X-Google-Smtp-Source: AMrXdXuS0v21FYccdQ7D2HVOZHqd/hubzEF7Xm8Zpz4gA6+rGLoD1cX2fHJPgpWZHpGqOQ3JUEkA X-Received: by 2002:a17:907:5014:b0:7cd:ffd:51f2 with SMTP id fw20-20020a170907501400b007cd0ffd51f2mr27656529ejc.57.1674598336421; Tue, 24 Jan 2023 14:12:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674598336; cv=none; d=google.com; s=arc-20160816; b=irQJ0iUp62TzC0J5I27cVzaJb/hL+4T/czKRRZi0Dn8NkX9+IKlpBm95ugu8EwKpTa DrpQVWvoDKloD2I/c/+uA9Bx0saI8n8cutxRiRyWJTCI8icQagHZI9f8yiUz2KSYKW2g 7pH4hxMRtk2qXGNH49RgtaC1xpYzyJuhJabXkF29z4rVuonqV8uEDHr4R9oHqRNwZlyb dScklritR8Y4q8/ixZXxeox0/A1e9Bkx7N2F0c/a/z98K6ixpRWrvcJ36d19Nvhk1Fqx u6xcATKD3d6IV0QnvJWPQsxuBBste5v5DAWI+Y983+sF88UCl2+mhdqApq78XAIP5D0J mTpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=NDxe4oIJJSUOqPRwp3G0IGOgJo50hIDpNvcK0HbcW+I=; b=Ug2oiyKClun96KJ3I7D2MDkwTzo2VZOJL5Oh0B/MbFbbkl/DjPQ+PhkvibWx7GCmFR 7gwdIKYjfD1Dl1GkhQ81s9BY740rtPqazbdmI1BbXTG17/sqiYFpUvTP2OeHbXm75JqG gOaVSIJY3MO1lyX7c0Z89YhZ8a/7H0o1GsESG4spyZtJCBZAF8KPnYDsuO/BedT+iVSj C76Z1Zis8P5bAQ6R+w1ZXkkt4XtJkn6raboI5cRoiA2eh7EQY+pfE+FmQgN5xgY8zScb EVPKUQsfje4QEieMHxnB9K6scOMKmKDCCp5q3Au/KXXYKX2L5Hl68mvUKrdnqJrunB/5 nzDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WBkvXYXk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fc5-20020a1709073a4500b0087786d721d9si3210532ejc.408.2023.01.24.14.11.51; Tue, 24 Jan 2023 14:12:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WBkvXYXk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235146AbjAXWFI (ORCPT + 99 others); Tue, 24 Jan 2023 17:05:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235140AbjAXWFE (ORCPT ); Tue, 24 Jan 2023 17:05:04 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51F4D5140D for ; Tue, 24 Jan 2023 14:04:45 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so39169wmb.2 for ; Tue, 24 Jan 2023 14:04:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NDxe4oIJJSUOqPRwp3G0IGOgJo50hIDpNvcK0HbcW+I=; b=WBkvXYXkvoKDXytnJfUU8oWA+parU/KCWf/I5sg/p3eClZPsxIvW7DeUIiwOvH4Fj3 YlCE0XCIY1laBfVZPEPVSalqFcfhOSB+YDt14gYlwJ0M4e8zOjXdpdEhi6w9yJDn+CPo Er42ROETd++Gt9iprGqRzUYfy6e1IX+kVPp98lJz8C8iRn/bn7k7ZGIN1M/1hExJitRQ G9RhNts8dN939D3TP93LgjGPuZ0DTwjXh0CyW0KRsn2dNQK0pcovmQNqZ651WyL3X/OF /84Kv89aQwLEfWXz5zqHeVFjwEdPHnlyyTUkibhbbrLuSPPG5GOCx2Wnejt9PySD3ZLk yuMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NDxe4oIJJSUOqPRwp3G0IGOgJo50hIDpNvcK0HbcW+I=; b=n0jM+M1+gadKlndfPa8aARkMjlDoLlwvWOQdC/7GUGwoo/K7/f43ocpzNdk09mC7/D AgxVp4taZg5mUAGLRrYWWgvg2FtavCGNygxc0sK7sqOefZ1IqqQBRLTzim5Iw8zYz888 8qEyP5byBTArcWezo5XCZ8TrJEx3uIFWDHYvWnGq5R1hHQDIEdfzN8R6s6nReDdle/hW mUR5nGImqQsifD1UfkJ+RGqRQIRig8QLW0SvBcFOF793rp6A1P04rSTL/MkBY4bY408G NZ2KmwPX/e8W4cUMfr5JKDRksXbls6RwkzwQ5LEqKdZCYXzXge3sV6EVrZ1dk5aQcH2J WAoA== X-Gm-Message-State: AFqh2kp4m6oxeqVhQsczrR8EtfRhQ7IB/nE0WPiuqknZxuw6kkEl+HhT RLGnjIed2mEOnhi9I4XZaUGnUHhPots= X-Received: by 2002:a05:600c:1695:b0:3da:f452:a975 with SMTP id k21-20020a05600c169500b003daf452a975mr6480278wmn.1.1674597873237; Tue, 24 Jan 2023 14:04:33 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935ca5.dip0.t-ipconnect.de. [87.147.92.165]) by smtp.gmail.com with ESMTPSA id j8-20020adff008000000b00297dcfdc90fsm2825015wro.24.2023.01.24.14.04.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 14:04:32 -0800 (PST) Date: Tue, 24 Jan 2023 23:04:30 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 10/11] staging: rtl8192e: Remove unused variables txbeac.., txman.. and txcmdp.. Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755943624816939517?= X-GMAIL-MSGID: =?utf-8?q?1755943624816939517?= txbeaconerr, txmanageokint and txcmdpktokint are initialized and increased but never read. Remove dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 8 +------- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 --- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 4cc90425fa4c..2c5edda74e73 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -2139,11 +2139,7 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) goto done; } - if (inta & IMR_TBDER) - priv->stats.txbeaconerr++; - if (inta & IMR_MGNTDOK) { - priv->stats.txmanageokint++; _rtl92e_tx_isr(dev, MGNT_QUEUE); spin_unlock_irqrestore(&priv->irq_th_lock, flags); if (priv->rtllib->ack_tx_to_ieee) { @@ -2155,10 +2151,8 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) spin_lock_irqsave(&priv->irq_th_lock, flags); } - if (inta & IMR_COMDOK) { - priv->stats.txcmdpktokint++; + if (inta & IMR_COMDOK) _rtl92e_tx_isr(dev, TXCMD_QUEUE); - } if (inta & IMR_HIGHDOK) _rtl92e_tx_isr(dev, HIGH_QUEUE); diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index f8b2201ea288..c6a4ac6ce959 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -184,9 +184,6 @@ enum reset_type { struct rt_stats { unsigned long received_rate_histogram[4][32]; - unsigned long txbeaconerr; - unsigned long txmanageokint; - unsigned long txcmdpktokint; unsigned long txbytesmulticast; unsigned long txbytesbroadcast; unsigned long txbytesunicast;