From patchwork Fri Dec 22 22:50:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 182801 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp1371929dyi; Fri, 22 Dec 2023 14:54:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IHYsVi1EPxnx2re09iBgvjATbxgMHOMCaYl3QCWxMU9yuhjZsc9xbaGf05TgNSKmKWWppaw X-Received: by 2002:a05:6870:648d:b0:204:48fe:46b with SMTP id cz13-20020a056870648d00b0020448fe046bmr2217886oab.77.1703285673437; Fri, 22 Dec 2023 14:54:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703285673; cv=none; d=google.com; s=arc-20160816; b=K1wNQvfV7TuQsq8+3jnsB5bFc0fyrNQxd7GMk7CaG0f8GyQ7u6s1XNsA86Sz2kZJGU amHlGEDYoSV0rzg+CSX17MhjoioW971hrwvrECpIJa+NKV5FOnPX4IQ6MfxvY1W//nOB ZRD8qUcpc2KgtiVzFO+s9e95JmT+XRA0OOhAhA8N6P92F58pdUYJV28fIIW9QmgiTRM7 /htOG+1qfOU/THgOjjZW52MuYc/DkE671xfmUZrv+VhU1EAhtgbOmv2i9p3EmBK43lO1 GCsoO3jN9mjmqc+mMpcp5non0zjoV1BV7dBDxZ2Vo8O2TzXdIu59d3T/iQo2wD/JKZqW ojCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=3Ob5a0YlomnMvZeb0ia8NW63hfkpeCkHBDIfOIGOs3w=; fh=3Ssjc9RSp5YBCDiXN3Xojrn4Aeyci/39VCtTXbItKyo=; b=XOH2EmdQ4hX92J11kJph24DBpmNCokllI+yY28Job7QnqexreNabsutKb6rTVgv7Az xX8tLn+UBjHxLC9hmMSdGMn+82/lCHHHOwj2cgvBtOMLwuHxuS8rDcd0fJHixGa/F1eS 9qcsUvGEH+Pv3jkPEQSd4cn05IpxxUPh6XYre2ZUJw0KX7fe47uUNvZv/BEFbnNVe6lW m3iPfYMYXM2b0f+sLZBKe4J1XuQ1o19F61w8XtK/mFrAEEGr52n1HLY8t7U9t7o1YGLh usXsa8iMp5tDjRmFgsndpWqV6+G3CJMUBpLLEFBY8vQcqpKy7/IVRre7sFOM47dL8Knk iDpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10103-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10103-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id bw37-20020a056a0204a500b005cdaa16ac24si3984622pgb.238.2023.12.22.14.54.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 14:54:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-10103-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10103-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10103-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 41F38281622 for ; Fri, 22 Dec 2023 22:54:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D98323A8F5; Fri, 22 Dec 2023 22:51:28 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF4E62E84F for ; Fri, 22 Dec 2023 22:51:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rGoMM-0005cI-Bt; Fri, 22 Dec 2023 23:51:14 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rGoMK-000qvH-JV; Fri, 22 Dec 2023 23:51:13 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rGoML-000FfS-1y; Fri, 22 Dec 2023 23:51:13 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thomas Gleixner Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 07/13] irqchip/mvebu-pic: Convert to platform remove callback returning void Date: Fri, 22 Dec 2023 23:50:38 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1815; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=YEdXLtjjB7MdLkwVRjWTzbmlfH5H3E2yBwtLiqFjuN8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlhhK/qY6qVh1CQvCesFeEHW82L2SThLnfZpHqn YQVEAd4ZOmJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYYSvwAKCRCPgPtYfRL+ ToKsB/0YopidcAoPuZVZY8pzovI6MHDYU0tVfCD6UxIrJpBC2C6kFSoxYL7QN8up16WNvLYE2lR f1gTuaISvFVhWpGshqK81Awjdo4FwaBqZQMEgvVWG3niOKVIZ9WRi+DhoFSh0/uml6a3+Q3YZ5V zopiut6A9xnm6NHJuXcB08ukkBF1uFnSPgEnCk0tZs027gIymP93N83affj48eHQLFkzr74/Qhs gjiH+VFZ3cr4ae03XZq4s5kGp4pL2TS/Y1qVlDNxCQD6OtPxGjNIeo6Rj8xNBL5dr58IANxom1A 1uMIbpQ1Hk3z7J/0DZVCkbhf0PcGbknLCaPIJx0rR6vyLuc1 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786024477902191039 X-GMAIL-MSGID: 1786024477902191039 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Gregory CLEMENT --- drivers/irqchip/irq-mvebu-pic.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/irqchip/irq-mvebu-pic.c b/drivers/irqchip/irq-mvebu-pic.c index ef3d3646ccc2..57e3f99b61f5 100644 --- a/drivers/irqchip/irq-mvebu-pic.c +++ b/drivers/irqchip/irq-mvebu-pic.c @@ -167,14 +167,12 @@ static int mvebu_pic_probe(struct platform_device *pdev) return 0; } -static int mvebu_pic_remove(struct platform_device *pdev) +static void mvebu_pic_remove(struct platform_device *pdev) { struct mvebu_pic *pic = platform_get_drvdata(pdev); on_each_cpu(mvebu_pic_disable_percpu_irq, pic, 1); irq_domain_remove(pic->domain); - - return 0; } static const struct of_device_id mvebu_pic_of_match[] = { @@ -185,7 +183,7 @@ MODULE_DEVICE_TABLE(of, mvebu_pic_of_match); static struct platform_driver mvebu_pic_driver = { .probe = mvebu_pic_probe, - .remove = mvebu_pic_remove, + .remove_new = mvebu_pic_remove, .driver = { .name = "mvebu-pic", .of_match_table = mvebu_pic_of_match,