diff mbox series

[next] dt-bindings: power: supply: Revise Richtek RT9467 compatible name

Message ID dc8873c3125f7aa6f84dc7b33a44bf00907e0814.1675853673.git.chiaen_wu@richtek.com
State New
Headers
Series [next] dt-bindings: power: supply: Revise Richtek RT9467 compatible name |

Commit Message

ChiaEn Wu Feb. 8, 2023, 3:14 a.m. UTC 
  Revise RT9467 compatible name from "richtek,rt9467-charger" to
"richtek,rt9467"

Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger")
Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
---
 .../devicetree/bindings/power/supply/richtek,rt9467-charger.yaml      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski Feb. 8, 2023, 8:04 a.m. UTC | #1 
On 08/02/2023 04:14, ChiaEn Wu wrote:
> Revise RT9467 compatible name from "richtek,rt9467-charger" to
> "richtek,rt9467"

Missing full stop.

Please explain why.

> 
> Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger")
> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>

Best regards,
Krzysztof
Rob Herring Feb. 8, 2023, 11:51 p.m. UTC | #2 
On Wed, Feb 08, 2023 at 11:14:24AM +0800, ChiaEn Wu wrote:
> Revise RT9467 compatible name from "richtek,rt9467-charger" to
> "richtek,rt9467"
> 

Reported-by: Rob Herring <robh@kernel.org>

> Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger")
> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> ---
>  .../devicetree/bindings/power/supply/richtek,rt9467-charger.yaml      | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
Sebastian Reichel Feb. 13, 2023, 8:53 p.m. UTC | #3 
Hi,

On Wed, Feb 08, 2023 at 11:14:24AM +0800, ChiaEn Wu wrote:
> Revise RT9467 compatible name from "richtek,rt9467-charger" to
> "richtek,rt9467"
> 
> Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger")
> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> ---

Is there a new version of this fixing the issues pointed out by Krzysztof?
Also I think the filename and $id should be changed to richtek,rt9467.yaml
in addition to the compatible change.

Thanks,

-- Sebastian

>  .../devicetree/bindings/power/supply/richtek,rt9467-charger.yaml      | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/richtek,rt9467-charger.yaml b/Documentation/devicetree/bindings/power/supply/richtek,rt9467-charger.yaml
> index 92c5706..9176808 100644
> --- a/Documentation/devicetree/bindings/power/supply/richtek,rt9467-charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/richtek,rt9467-charger.yaml
> @@ -25,7 +25,7 @@ description: |
>  
>  properties:
>    compatible:
> -    const: richtek,rt9467-charger
> +    const: richtek,rt9467
>  
>    reg:
>      maxItems: 1
> @@ -65,7 +65,7 @@ examples:
>        #size-cells = <0>;
>  
>        charger@5b {
> -        compatible = "richtek,rt9467-charger";
> +        compatible = "richtek,rt9467";
>          reg = <0x5b>;
>          wakeup-source;
>          interrupts-extended = <&gpio_intc 32 IRQ_TYPE_LEVEL_LOW>;
> -- 
> 2.7.4
>
Krzysztof Kozlowski Feb. 14, 2023, 8:14 a.m. UTC | #4 
On 13/02/2023 21:53, Sebastian Reichel wrote:
> Hi,
> 
> On Wed, Feb 08, 2023 at 11:14:24AM +0800, ChiaEn Wu wrote:
>> Revise RT9467 compatible name from "richtek,rt9467-charger" to
>> "richtek,rt9467"
>>
>> Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger")
>> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
>> ---
> 
> Is there a new version of this fixing the issues pointed out by Krzysztof?
> Also I think the filename and $id should be changed to richtek,rt9467.yaml
> in addition to the compatible change.

Yes, indeed.

Best regards,
Krzysztof
ChiYuan Huang Feb. 15, 2023, 3:34 a.m. UTC | #5 
H, Krzysztof/Sebastian:
On Tue, Feb 14, 2023 at 09:14:37AM +0100, Krzysztof Kozlowski wrote:
> On 13/02/2023 21:53, Sebastian Reichel wrote:
> > Hi,
> > 
> > On Wed, Feb 08, 2023 at 11:14:24AM +0800, ChiaEn Wu wrote:
> >> Revise RT9467 compatible name from "richtek,rt9467-charger" to
> >> "richtek,rt9467"
> >>
> >> Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger")
> >> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> >> ---
> > 
> > Is there a new version of this fixing the issues pointed out by Krzysztof?
> > Also I think the filename and $id should be changed to richtek,rt9467.yaml
> > in addition to the compatible change.
> 
> Yes, indeed.
> 
From the current discussion, there're things to be fixed.
1. In bindings, change compatible property from 'richtek,rt9467-charger' to 'richtek,rt9467'.
2. Rename 'richtek,rt9467-charger.yaml' to 'richtek,rt9467.yaml'

Anything else? like as changing source code filename from from 'rt9467-charger.c' to 'rt9467.c"?

And we'll submit a new patch to fix it days later.

Thanks.
> Best regards,
> Krzysztof
>
ChiYuan Huang Feb. 15, 2023, 3:45 a.m. UTC | #6 
Hi, Krzysztof/Sebastian:

On Tue, Feb 14, 2023 at 09:14:37AM +0100, Krzysztof Kozlowski wrote:
> On 13/02/2023 21:53, Sebastian Reichel wrote:
> > Hi,
> > 
> > On Wed, Feb 08, 2023 at 11:14:24AM +0800, ChiaEn Wu wrote:
> >> Revise RT9467 compatible name from "richtek,rt9467-charger" to
> >> "richtek,rt9467"
> >>
> >> Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger")
> >> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> >> ---
> > 
> > Is there a new version of this fixing the issues pointed out by Krzysztof?
> > Also I think the filename and $id should be changed to richtek,rt9467.yaml
> > in addition to the compatible change.
> 
> Yes, indeed.
> 
From the current discussion, there're things to be fixed.
1. In bindings, change compatible property from 'richtek,rt9467-charger' to 'richtek,rt9467'.
2. Rename 'richtek,rt9467-charger.yaml' to 'richtek,rt9467.yaml'

Anything else? like as changing source code filename from 'rt9467-charger.c' to only 'rt9467.c"?

And we'll submit a new one to fix it in these two days.

Thanks.

> Best regards,
> Krzysztof
>
Sebastian Reichel Feb. 15, 2023, 1:15 p.m. UTC | #7 
Hi,

On Wed, Feb 15, 2023 at 11:34:40AM +0800, ChiYuan Huang wrote:
> H, Krzysztof/Sebastian:
> On Tue, Feb 14, 2023 at 09:14:37AM +0100, Krzysztof Kozlowski wrote:
> > On 13/02/2023 21:53, Sebastian Reichel wrote:
> > > Hi,
> > > 
> > > On Wed, Feb 08, 2023 at 11:14:24AM +0800, ChiaEn Wu wrote:
> > >> Revise RT9467 compatible name from "richtek,rt9467-charger" to
> > >> "richtek,rt9467"
> > >>
> > >> Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger")
> > >> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> > >> ---
> > > 
> > > Is there a new version of this fixing the issues pointed out by Krzysztof?
> > > Also I think the filename and $id should be changed to richtek,rt9467.yaml
> > > in addition to the compatible change.
> > 
> > Yes, indeed.
> > 
> From the current discussion, there're things to be fixed.
> 1. In bindings, change compatible property from 'richtek,rt9467-charger' to 'richtek,rt9467'.
> 2. Rename 'richtek,rt9467-charger.yaml' to 'richtek,rt9467.yaml'
>
> Anything else? like as changing source code filename from from 'rt9467-charger.c' to 'rt9467.c"?

No, the source code can remain unchanged. But you also need to change
the $id line (line 4) in 'richtek,rt9467-charger.yaml' after renaming
file.

-- Sebastian
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/supply/richtek,rt9467-charger.yaml b/Documentation/devicetree/bindings/power/supply/richtek,rt9467-charger.yaml
index 92c5706..9176808 100644
--- a/Documentation/devicetree/bindings/power/supply/richtek,rt9467-charger.yaml
+++ b/Documentation/devicetree/bindings/power/supply/richtek,rt9467-charger.yaml
@@ -25,7 +25,7 @@  description: |
 
 properties:
   compatible:
-    const: richtek,rt9467-charger
+    const: richtek,rt9467
 
   reg:
     maxItems: 1
@@ -65,7 +65,7 @@  examples:
       #size-cells = <0>;
 
       charger@5b {
-        compatible = "richtek,rt9467-charger";
+        compatible = "richtek,rt9467";
         reg = <0x5b>;
         wakeup-source;
         interrupts-extended = <&gpio_intc 32 IRQ_TYPE_LEVEL_LOW>;