From patchwork Tue Feb 14 03:18:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baolin Wang X-Patchwork-Id: 56651 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2743917wrn; Mon, 13 Feb 2023 19:57:27 -0800 (PST) X-Google-Smtp-Source: AK7set9He4JPY6eGV/NUgRtajU34PyLuhl3jngRTpX+/swIheP2Vic/B+DndqTSlQKV63EebWAdj X-Received: by 2002:a17:906:c28a:b0:889:d998:1576 with SMTP id r10-20020a170906c28a00b00889d9981576mr1192011ejz.66.1676347046946; Mon, 13 Feb 2023 19:57:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676347046; cv=none; d=google.com; s=arc-20160816; b=H0c1NbWMowoZ/RXUtCxKoIxdIhbGYq7jMIUqKqTFQHXnL3klNRtL9jpmg+Iqg7sVpM iPFpRkEjgv/qR3RdABFVlZyaOU1IQkyfuLw3phGkVkQKol1XdBlrrgZGmp+DYdMBTjuA KTJm4QFTX+TgEbquI4byz4m3Dw2kokQq7FYeyQhS2jDZdddPJa8wD7m9fqRfDgKToqwa xir0quJwOg3LalxioA27ZdbMQSg/sH9UElMxAeLxbA4/HU5YVetZmpsAXRBKaTBFryeB Cg9jb5Y1E9A7qO+vP76gBuVSpqUTcytA4SDnZqWfujkRhvMV+xxd3BJSA209dS5p9+2l 7I9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=IZQcyJjFlkQ044twydhzOb1ViDGQSIC6qjIfQyHiSiA=; b=lTsMeOnSVApVqWIBA7zT6G2Qu0Ggu1eNC1Gr6/JqTubTHsTlplOpWJqI7Onx9PrQJa xm1vjGD6qz9rm6K/WYnHAFRfyiykNvj23ueoob5VnJ2FPWZqd104K3naZTRZxXnfCpIR oE5FIFOz8Ysp6o6PBguyvZsSx0axGKzVX8/6ffCb7BsE+TCwj8Q5fLQWa3RiJ484OvDn Ktgi5sEUc9vGkj5XrkYloE7gGIZKxYvGTCcnKXdFplBbuzrxIJipLT+sSRQ4HKUyW8po MHrRuj6hw3fgQt8YtibnQl9Rt8+Ni1lZGRedjRBkZv8ZmeUN4uX8JrXi8G9j9Y8+gIpE TRZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mr4-20020a170907828400b00878442d9d38si15355183ejc.512.2023.02.13.19.57.03; Mon, 13 Feb 2023 19:57:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230232AbjBNDSg (ORCPT + 99 others); Mon, 13 Feb 2023 22:18:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231381AbjBNDSc (ORCPT ); Mon, 13 Feb 2023 22:18:32 -0500 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C783D4694; Mon, 13 Feb 2023 19:18:31 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0VbdtbCo_1676344708; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VbdtbCo_1676344708) by smtp.aliyun-inc.com; Tue, 14 Feb 2023 11:18:28 +0800 From: Baolin Wang To: akpm@linux-foundation.org Cc: torvalds@linux-foundation.org, sj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, baolin.wang@linux.alibaba.com, damon@lists.linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] mm: mempolicy: check negative error of isolate_hugetlb() when failed to isolate a hugetlb Date: Tue, 14 Feb 2023 11:18:08 +0800 Message-Id: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757777281268365038?= X-GMAIL-MSGID: =?utf-8?q?1757777281268365038?= Better to check the negative error of isolate_hugetlb() when failed to isolate a hugetlb page, which makes the code more clear. No functional changes. Signed-off-by: Baolin Wang --- mm/mempolicy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 0919c7a719d4..e3d87b21516b 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -609,7 +609,7 @@ static int queue_folios_hugetlb(pte_t *pte, unsigned long hmask, if (flags & (MPOL_MF_MOVE_ALL) || (flags & MPOL_MF_MOVE && folio_estimated_sharers(folio) == 1 && !hugetlb_pmd_shared(pte))) { - if (isolate_hugetlb(folio, qp->pagelist) && + if (isolate_hugetlb(folio, qp->pagelist) < 0 && (flags & MPOL_MF_STRICT)) /* * Failed to isolate folio but allow migrating pages