From patchwork Tue Dec 5 12:26:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 174024 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3391409vqy; Tue, 5 Dec 2023 04:26:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IGynygccoZwB4F+Ff7hoCPnvScgiT29Bj9qYs5RydvW4tP/Y0hph3jr8NHQRL01XDrVOZVj X-Received: by 2002:a17:902:c412:b0:1d0:b6ca:e485 with SMTP id k18-20020a170902c41200b001d0b6cae485mr2331517plk.128.1701779208400; Tue, 05 Dec 2023 04:26:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701779208; cv=none; d=google.com; s=arc-20160816; b=aHsyKMOapRZSDJctn15+rvuKvv9qoL9O4tdIu5ZJQbfY/Odmka9B8R689aOmm2vxnM ENDBbYNpssN0JvhbS3rlXKhgQQrq+pOMXgxym+LzCjfnMVy/YAJTTSveAD8MHTVLu6zi oBfqhhe+m2hXujkzuuLIep60L7av8PhAk1GUj9tOXrjof/NCeYLWcIpKUPJ/gIJYi5G5 4h+3uRNzsOXMmYc0Q8WEEBPXkjCtlEaA8+O6tQMo9mCKkKf4HscSf0QUrgj0patswzT+ PX5k4dKiGT9JMihgrThvw2EHTtFFHS2mfAmeguhmflgbPnoKOS2Vn0rbAEZGoKV48D7w OqBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=NENcXo3LEuAaluIyX7atY27CioG9wbywkjeF/WfJjUY=; fh=SV7jp/N4w5H/WguTuPXZpem2ktA8CMnlzZDNo6r9whw=; b=vbLOQRIxN5uXhDorbHwL9EVNGOYLZ4qsHxvgZ8SQRQvo5BNatgtNxbxqj2Dmu2YpdG A7cYVb1INztzeEEOIKVrzVz4vWhFbIQZtx8QiXAvhEICC/6BYPanCB8X1s301lQ3NJCW lt/pbc2OuGtqMsYHs35zf2yko+Emc6hMO0HWVvaXibHc0FTj9ySyg+n5Teh9Z6YMNWpt R1699EnHGgoSVo4ymZWUCSwKy3QZ88UinvSVzqDzmpoKdpllz6OF+MrD/+RA+qB7jPAj lrTKefVV03zXUvNhabU90J2SkfsEX2IWZUuPJqY3dT9jS7UVMjz97FY0hRBzOCxXynau if2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id y9-20020a170902b48900b001cffb969691si9217864plr.222.2023.12.05.04.26.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 04:26:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 6A16680C5FA5; Tue, 5 Dec 2023 04:26:47 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235157AbjLEM0g (ORCPT + 99 others); Tue, 5 Dec 2023 07:26:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231897AbjLEM0c (ORCPT ); Tue, 5 Dec 2023 07:26:32 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 655CAC9 for ; Tue, 5 Dec 2023 04:26:38 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAUVY-0005YB-DY; Tue, 05 Dec 2023 13:26:36 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAUVY-00Djv9-0j; Tue, 05 Dec 2023 13:26:36 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rAUVX-00EhQy-OG; Tue, 05 Dec 2023 13:26:35 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 7/8] regulator: virtual: Convert to platform remove callback returning void Date: Tue, 5 Dec 2023 13:26:22 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1830; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=1OKfIPBeDkKIREgYV7LXbr/0td99Z79KwgLwoughZ/c=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlbxbuOE/46ozZYuwEBtuuizP6Db361dH5Sjxp+ Slow9GJVjeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZW8W7gAKCRCPgPtYfRL+ TmwIB/wJ6YpQ2ODQNk1jeVFJkg/vHO2WmI6bTHeiE1UEBDv3ANOfLiYCgutRQsfrDuzLocHJtF0 AEs1cdzNB5wQY5HtKvILN9fDWyidpJPwtG3Zygn1MHiEiOjmSsA364LJdS+hviBCGw+Xsa9B0FN zbCqA6olDtPyDCvo2C0Kz6oA3NH9Jlknhxqk03o2q8ayvEoCIvKf7I8uRHOYBuOTxiwRsz9/vrl qVeJhH4DGsPUz9jt36MBGXgfZYIe4PWb/oonaWO2mWv1oxl6FM2lCtHk5cYxViy0kpVtWb0D+YA V00SHr+iaR43hrxfthWVFdCA4uFAJLxNBVwubf0D8mG4w51T X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 05 Dec 2023 04:26:47 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784444835181860963 X-GMAIL-MSGID: 1784444835181860963 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/regulator/virtual.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/virtual.c b/drivers/regulator/virtual.c index d5a160efdae6..0a0ee186c6af 100644 --- a/drivers/regulator/virtual.c +++ b/drivers/regulator/virtual.c @@ -345,7 +345,7 @@ static int regulator_virtual_probe(struct platform_device *pdev) return 0; } -static int regulator_virtual_remove(struct platform_device *pdev) +static void regulator_virtual_remove(struct platform_device *pdev) { struct virtual_consumer_data *drvdata = platform_get_drvdata(pdev); @@ -353,13 +353,11 @@ static int regulator_virtual_remove(struct platform_device *pdev) if (drvdata->enabled) regulator_disable(drvdata->regulator); - - return 0; } static struct platform_driver regulator_virtual_consumer_driver = { .probe = regulator_virtual_probe, - .remove = regulator_virtual_remove, + .remove_new = regulator_virtual_remove, .driver = { .name = "reg-virt-consumer", .probe_type = PROBE_PREFER_ASYNCHRONOUS,