From patchwork Fri May 12 07:53:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 92987 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp4926372vqo; Fri, 12 May 2023 01:04:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4/fBXk6GW2gfHreBg6mDcgbiZgS98vEJADXqXB96QJxRqTeUprOm4p190ojl5uYWpKv5vb X-Received: by 2002:a05:6a20:7489:b0:f2:9378:814a with SMTP id p9-20020a056a20748900b000f29378814amr30384773pzd.49.1683878644768; Fri, 12 May 2023 01:04:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683878644; cv=none; d=google.com; s=arc-20160816; b=tovY7svkLu5O0j/Z+Rn8sGRLmPgzgoO32qV+hfwXZiXpuaYgAMXWC0EsKyXsvkAtSY FMddbYOSwPWZjga2P15aTAPUhkHsn07lMTE+bbzXQ/zpOSJgtMyzJvpIXAiBjDu8uvVq 8ihceSoInLeJm+gS9zBSC0MHVQ193Q/iRCf4zsfbTnLuyLJ+34thrnC6RPNOwfQ/aM7L BTokbhn2OeS3s/TzM7TwId9qSUQiG3alWDbXEBkcG8bW5txZKcxxv2qbOY8wxxBKkHIZ dWReDl4CbZAZ7jx7f9u9hL2l4Qib9CsUUrWhBfdL3gIicuBPOPwMfX/BcaICOzLr2blw oojA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=r+fkvnw5qJK8Z9ZsEdDbVAibOHT/dgf1NL+n5A0kE4I=; b=o7EJjCgZ+edm16N8pMKcaoLaM1Zh3E010Ssr6oqUkn/+U93leGeH0sddC1a2u7+3Kf MezwdEGeYz9j39YC6LE8/Draajrz+Exps/tEC3kUJstL4dSBTnDAZzG53btqMr2i49wJ 6OVfko3H8YqHLzAGLVCG2fQ/08QrKyh3/5dqVDi0kMc3wX678sqrto7NSp5v78Yl/MOV 1f2TOXVTRnIINF2/FFWOSv0jYf73ozOrncqwVFVynjuHohklPL9bbPMiEg5PjJl7r32V jahJlOf/zOa2wljS0x0xS8L0xDDSmXB4TOMekEZ9BuVx0nHQwaAmszCQHIbuTa8IMrY2 rudA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=P2el5kc0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bv187-20020a632ec4000000b0050fb1a00d3dsi8530942pgb.46.2023.05.12.01.03.50; Fri, 12 May 2023 01:04:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=P2el5kc0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240376AbjELHyQ (ORCPT + 99 others); Fri, 12 May 2023 03:54:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240374AbjELHx6 (ORCPT ); Fri, 12 May 2023 03:53:58 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25E64106FD; Fri, 12 May 2023 00:53:31 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2ac80da3443so105629231fa.0; Fri, 12 May 2023 00:53:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683878010; x=1686470010; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=r+fkvnw5qJK8Z9ZsEdDbVAibOHT/dgf1NL+n5A0kE4I=; b=P2el5kc09GmR4TELHXaLBONDRptaapBZXgUK3wEKkHoAPmtY9J2Qc1yr8KUR/4u5HP dnNBqWE0Pa2xaUIy4VJKr+uWa9bVH1jW7m4y/iSTDrl8wBvUhrRt5ePLB2XiEo61eS3l JKOtVi8/7GNe2+m7JMSU9goRVv+YB0MfD5rt9s7GRkkXloLQV1Hgj6paBsYn3Rk/d0nC ysMD5oN0iiYk111epYMERRDTCBq8z/fRrtOgCqssglyPDBHQmujNsmVViI18VbXN7AFl QAdKY8B16cLejoIMDgTb37tCb1/DZnJbcvBmOo0PCN7qZuJFUupLFsRrgddkzk4WFYnG a9lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683878010; x=1686470010; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r+fkvnw5qJK8Z9ZsEdDbVAibOHT/dgf1NL+n5A0kE4I=; b=M30ogO3oM2xaPhYftT+PQ8K80B0odPDxBNWsriN0gGAOPGTUZwiuvr3C3mGROQJwFX vIXLaejj7XoqrlV/TWsJiuotXG7lcB82eXIn2Lpcvou7o+7TMdzA3HuR+n2wNKF9wUnd KnTQk7xXnvdCUR6yGzdt6vo9fwoH9gPsbJqPLE5VR4Ij1BHaGzC7U1px7Azm+lLLMaQF SUuucEnWx6JARCEdgiqr67J0fU5JEKA7CxH7TM+Jd1YrEiwRdM/Iv8QkzYNIjdSYTrWe aiK6qctAvu8Ou8j6HMXXPrZRW5Vv0QEwgMgLQ2X+zGHORFR68zEeb3fVphlKXYCcCGQ3 06kw== X-Gm-Message-State: AC+VfDwi2Akw+8Twd7qYw/lO3JlLbGy+H4H02WlcuVSPGMkx4S1bLSsC wFgrnFArQd+GMGIXfldxDvY= X-Received: by 2002:a2e:7004:0:b0:2ac:8e5a:1054 with SMTP id l4-20020a2e7004000000b002ac8e5a1054mr3988058ljc.0.1683878009870; Fri, 12 May 2023 00:53:29 -0700 (PDT) Received: from fedora (62-78-225-252.bb.dnainternet.fi. [62.78.225.252]) by smtp.gmail.com with ESMTPSA id l18-20020a05651c10d200b002aa4713b925sm2691194ljn.21.2023.05.12.00.53.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 May 2023 00:53:29 -0700 (PDT) Date: Fri, 12 May 2023 10:53:25 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Wolfram Sang , Matti Vaittinen , Jonathan Cameron , Lars-Peter Clausen , Akhil R , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org Subject: [PATCH v3 2/3] i2c: i2c-smbus: fwnode_irq_get_byname() return value fix Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765674733922941328?= X-GMAIL-MSGID: =?utf-8?q?1765674733922941328?= The fwnode_irq_get_byname() was changed to not return 0 upon failure so return value check can be adjusted to reflect the change. Reviewed-by: Sakari Ailus Reviewed-by: Andy Shevchenko Signed-off-by: Matti Vaittinen --- Depends on the mentioned return value change which is in patch 1/2. The return value change does also cause a functional change here. Eg. when IRQ mapping fails, the fwnode_irq_get_byname() no longer returns zero. This will cause also the probe here to return nonzero failure. I guess this is desired behaviour - but I would appreciate any confirmation. Please, see also previous discussion here: https://lore.kernel.org/all/fbd52f5f5253b382b8d7b3e8046134de29f965b8.1666710197.git.mazziesaccount@gmail.com/ Another suggestion has been to drop the check altogether. I am slightly reluctant on doing that unless it gets confirmed that is the "right thing to do". --- drivers/i2c/i2c-smbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c index 138c3f5e0093..893fe7cd3e41 100644 --- a/drivers/i2c/i2c-smbus.c +++ b/drivers/i2c/i2c-smbus.c @@ -129,7 +129,7 @@ static int smbalert_probe(struct i2c_client *ara) } else { irq = fwnode_irq_get_byname(dev_fwnode(adapter->dev.parent), "smbus_alert"); - if (irq <= 0) + if (irq < 0) return irq; }