From patchwork Wed Sep 13 14:08:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 138813 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp1113675vqx; Wed, 13 Sep 2023 07:10:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEd/gghvlhMhAVg0JvOQ2Jr2v95Ys9c5w0ja5T5yvlkJrueld/abC/0u62rNHYjw3y8ORif X-Received: by 2002:a05:6808:1054:b0:3a7:a299:1203 with SMTP id c20-20020a056808105400b003a7a2991203mr2211822oih.22.1694614243422; Wed, 13 Sep 2023 07:10:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694614243; cv=none; d=google.com; s=arc-20160816; b=PICnUrCAaMJoYzBQnIZ/rNFdjDBhpz7QL0i9Ghvg5hdEi8cDXGY7erXX+k1pAlK7GA sB61V8Lp/UWOP+v4fgD/vHNu+fY0jQ7gK32G1excBnQrZRfoAkiJqK5FjWSXkzEJOLfE /lU5MpW2chyfEk0Nj5XGcIC3thpBLJxz1TW5gFI4t/5veNKDfnHGp9kAhrzBuwwbaBrF wtFlP1y+tNqUrv2dFt/McMWjM0b7uayhDnOBQJ1i2VjuufWFB//NE9Bhn6W57qqUEV62 /aZ4LFFMzodpJ5pBBB0RphoFuDEsdpnb4b4Ng9bSsJgduq2Po4xzdNhy2yk5Y9vUjldG MY9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ZfhCwpHUZ2SrRNDMXEYjVlYmiCGm8jnC+5gqflXrEow=; fh=fKMC3BTGjlLXl5EvEhzqt3WHCynqYJKK7wAqLAOkWUw=; b=ACDY3z1QWWkFIjarWKPhFOdx446bN1PZosiJRxr7jd4Mur20AK5ITeoRUReel05otU CDPpvsSUoPQCpa+mJVFMAxrsFgkwJszcMooWn3oO8PejbOgwnhfKCT773TScxQhqHIR3 0vtj6J4CwTUQU0cgRpn/f50uu7WWrfneutnWMgekBx+UfRG4feJYAl05aTvoi/WehSOj 4/LfZV0cAcwuVLZUw0SSc8MWtnZS4iLViMROsbDzZ7gBYQccvJC7CwxcykgY/L/pNLK5 gtXw/mPMbnbYU+LVvhmuo+IXZ456rHBOEBEpgAr6Xi61NmZmaEQjAP/Vqrdi8nedpwoG 4OjA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id j63-20020a638042000000b0056c297d1640si8114452pgd.528.2023.09.13.07.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 07:10:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 8BCF181DDBF4; Wed, 13 Sep 2023 07:09:26 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241330AbjIMOJN (ORCPT + 36 others); Wed, 13 Sep 2023 10:09:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241246AbjIMOIz (ORCPT ); Wed, 13 Sep 2023 10:08:55 -0400 Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [IPv6:2a02:1800:120:4::f00:13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 547431BCE for ; Wed, 13 Sep 2023 07:08:50 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:f674:9611:cd05:f25a]) by baptiste.telenet-ops.be with bizsmtp id lS8n2A00E3fvA4V01S8nqH; Wed, 13 Sep 2023 16:08:48 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qgQXd-003csZ-Tn; Wed, 13 Sep 2023 16:08:47 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qgQXv-00FV5R-88; Wed, 13 Sep 2023 16:08:47 +0200 From: Geert Uytterhoeven To: linux-m68k@lists.linux-m68k.org Cc: Arnd Bergmann , Finn Thain , Michael Schmitz , Philip Blundell , Greg Ungerer , Joshua Thompson , Sam Creasey , Laurent Vivier , linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH v2 26/52] m68k: apollo: Add and use "apollo.h" Date: Wed, 13 Sep 2023 16:08:16 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Sep 2023 07:09:26 -0700 (PDT) X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776931825161809618 X-GMAIL-MSGID: 1776931825161809618 When building with W=1: arch/m68k/apollo/dn_ints.c:43:13: warning: no previous prototype for ‘dn_init_IRQ’ [-Wmissing-prototypes] 43 | void __init dn_init_IRQ(void) | ^~~~~~~~~~~ Fix this by introducing a new header file "apollo.h" for holding the prototypes of functions implemented in arch/m68k/apollo/. Signed-off-by: Geert Uytterhoeven Acked-by: Arnd Bergmann --- v2: - Add Acked-by. --- arch/m68k/apollo/apollo.h | 4 ++++ arch/m68k/apollo/config.c | 3 ++- arch/m68k/apollo/dn_ints.c | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 arch/m68k/apollo/apollo.h diff --git a/arch/m68k/apollo/apollo.h b/arch/m68k/apollo/apollo.h new file mode 100644 index 0000000000000000..1fe9d856df30354c --- /dev/null +++ b/arch/m68k/apollo/apollo.h @@ -0,0 +1,4 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +/* dn_ints.c */ +void dn_init_IRQ(void); diff --git a/arch/m68k/apollo/config.c b/arch/m68k/apollo/config.c index 7afefb0191504d4e..e161ecd76035862d 100644 --- a/arch/m68k/apollo/config.c +++ b/arch/m68k/apollo/config.c @@ -17,6 +17,8 @@ #include #include +#include "apollo.h" + u_long sio01_physaddr; u_long sio23_physaddr; u_long rtc_physaddr; @@ -27,7 +29,6 @@ u_long timer_physaddr; u_long apollo_model; extern void dn_sched_init(void); -extern void dn_init_IRQ(void); extern int dn_dummy_hwclk(int, struct rtc_time *); static void dn_dummy_reset(void); #ifdef CONFIG_HEARTBEAT diff --git a/arch/m68k/apollo/dn_ints.c b/arch/m68k/apollo/dn_ints.c index d97251fe0ab83045..ba96a92f8f18f00a 100644 --- a/arch/m68k/apollo/dn_ints.c +++ b/arch/m68k/apollo/dn_ints.c @@ -5,6 +5,8 @@ #include #include +#include "apollo.h" + static unsigned int apollo_irq_startup(struct irq_data *data) { unsigned int irq = data->irq;