diff mbox series

[01/30] net: usb: Use kstrtobool() instead of strtobool()

Message ID	d4432f67b6f769cacdabec910ac723298964e302.1667336095.git.christophe.jaillet@wanadoo.fr
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: Oliver Neukum <oliver@neukum.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, =?utf-8?q?Bj=C3=B8rn_Mork?= <bjorn@mork.no> Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET <christophe.jaillet@wanadoo.fr>, linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 01/30] net: usb: Use kstrtobool() instead of strtobool() Date: Tue, 1 Nov 2022 22:13:49 +0100 Message-Id: <d4432f67b6f769cacdabec910ac723298964e302.1667336095.git.christophe.jaillet@wanadoo.fr> In-Reply-To: <cover.1667336095.git.christophe.jaillet@wanadoo.fr> References: <cover.1667336095.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Remove strtobool() \| [00/30] Remove strtobool() [01/30] net: usb: Use kstrtobool() instead of strtobool() [02/30] wifi: Use kstrtobool() instead of strtobool() [03/30] irqchip: Use kstrtobool() instead of strtobool() [04/30] scsi: target: Use kstrtobool() instead of strtobool() [05/30] nvdimm: Use kstrtobool() instead of strtobool() [06/30] nvme: Use kstrtobool() instead of strtobool() [07/30] usb: core: Use kstrtobool() instead of strtobool() [08/30] usb: gadget: Use kstrtobool() instead of strtobool() [09/30] ACPI: sysfs: Use kstrtobool() instead of strtobool() [10/30] clocksource/drivers/arm_arch_timer: Use kstrtobool() instead of strtobool() [11/30] greybus: svc: Use kstrtobool() instead of strtobool() [12/30] input: Use kstrtobool() instead of strtobool() [13/30] platform/chrome: Use kstrtobool() instead of strtobool() [14/30] powercap: Use kstrtobool() instead of strtobool() [15/30] video: fbdev: omapfb: Use kstrtobool() instead of strtobool() [16/30] cifs: Use kstrtobool() instead of strtobool() [17/30] initramfs: Use kstrtobool() instead of strtobool() [18/30] module: Use kstrtobool() instead of strtobool() [19/30] kernel/params.c: Use kstrtobool() instead of strtobool() [20/30] mm/damon: Use kstrtobool() instead of strtobool() [21/30] mm: Use kstrtobool() instead of strtobool() [22/30] Bluetooth: hci_debugfs: Use kstrtobool() instead of strtobool() [23/30] test_firmware: Use kstrtobool() instead of strtobool() [24/30] arm64: cpufeature: Use kstrtobool() instead of strtobool() [25/30] KVM: arm64: vgic-v3: Use kstrtobool() instead of strtobool() [26/30] s390/ipl: Use kstrtobool() instead of strtobool() [27/30] KVM: x86/mmu: Use kstrtobool() instead of strtobool() [28/30] x86/xen: Use kstrtobool() instead of strtobool() [29/30] driver core: Use kstrtobool() instead of strtobool() [30/30] kstrtox: Remove strtobool()

Commit Message

Christophe JAILLET Nov. 1, 2022, 9:13 p.m. UTC

  strtobool() is the same as kstrtobool().
However, the latter is more used within the kernel.

In order to remove strtobool() and slightly simplify kstrtox.h, switch to
the other function name.

While at it, include the corresponding header file (<linux/kstrtox.h>)

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
This patch is part of a serie that axes all usages of strtobool().
Each patch can be applied independently from the other ones.

The last patch of the serie removes the definition of strtobool().

You may not be in copy of the cover letter. So, if needed, it is available
at [1].

[1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/
---
 drivers/net/usb/cdc_ncm.c  | 3 ++-
 drivers/net/usb/qmi_wwan.c | 5 +++--
 2 files changed, 5 insertions(+), 3 deletions(-)

Comments

Jakub Kicinski Nov. 2, 2022, 3:27 a.m. UTC | #1

On Tue,  1 Nov 2022 22:13:49 +0100 Christophe JAILLET wrote:
> This patch is part of a serie that axes all usages of strtobool().
> Each patch can be applied independently from the other ones.
> 
> The last patch of the serie removes the definition of strtobool().
> 
> You may not be in copy of the cover letter. So, if needed, it is available
> at [1].
> 
> [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/

Please repost this patch separately. Patch bots and CIs will not test
partially received series.

diff mbox series

Patch

diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 8d5cbda33f66..6b5f24f28dd1 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -43,6 +43,7 @@ 
 #include <linux/ctype.h>
 #include <linux/etherdevice.h>
 #include <linux/ethtool.h>
+#include <linux/kstrtox.h>
 #include <linux/workqueue.h>
 #include <linux/mii.h>
 #include <linux/crc32.h>
@@ -318,7 +319,7 @@  static ssize_t ndp_to_end_store(struct device *d,  struct device_attribute *attr
 	struct cdc_ncm_ctx *ctx = (struct cdc_ncm_ctx *)dev->data[0];
 	bool enable;
 
-	if (strtobool(buf, &enable))
+	if (kstrtobool(buf, &enable))
 		return -EINVAL;
 
 	/* no change? */
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 26c34a7c21bd..30d733c81ed8 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -13,6 +13,7 @@ 
 #include <linux/ethtool.h>
 #include <linux/etherdevice.h>
 #include <linux/if_arp.h>
+#include <linux/kstrtox.h>
 #include <linux/mii.h>
 #include <linux/rtnetlink.h>
 #include <linux/usb.h>
@@ -343,7 +344,7 @@  static ssize_t raw_ip_store(struct device *d,  struct device_attribute *attr, co
 	bool enable;
 	int ret;
 
-	if (strtobool(buf, &enable))
+	if (kstrtobool(buf, &enable))
 		return -EINVAL;
 
 	/* no change? */
@@ -492,7 +493,7 @@  static ssize_t pass_through_store(struct device *d,
 	struct qmi_wwan_state *info;
 	bool enable;
 
-	if (strtobool(buf, &enable))
+	if (kstrtobool(buf, &enable))
 		return -EINVAL;
 
 	info = (void *)&dev->data;