From patchwork Wed Dec 27 21:02:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183564 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1666064dyb; Wed, 27 Dec 2023 13:04:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfL/M80I5snEow9TUJWIa8JwbW608sQOjwIBhNQop5Weny0Sc0K6IXQISP4dECzDz6Eh+C X-Received: by 2002:a05:6102:1608:b0:466:8c56:1b1c with SMTP id cu8-20020a056102160800b004668c561b1cmr4357414vsb.54.1703711077275; Wed, 27 Dec 2023 13:04:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703711077; cv=none; d=google.com; s=arc-20160816; b=ThpLQvgsO+WQh4YJ6DFzJA3Jm+oB0dfVxQ2qheOIOurmemLHE27eRzcIMIFV33FwuL QME7+3J3Wx5SA8aHgTqFXNzbOUWATjh6jtTDEgJTu8e7WvWMiVZCKJNDZqDUcwfPdhSG gXQlGHIFN0ozHvloamKPLH6uRLAT7kfwoB3QO5KoPDq2vSrlyjdFXy//UlukhbQ92Iu1 f6UrI0Oqg8m/Sl9PkSfuB/rTtOTJDGZuxkRRVnYPsNwj6Sipazb/N9ZjGX2S8a/0o2mC PwdBGgruF8V0KOe7emHYdPLFwfDa3BJYBussP2o8wP1fkAhan84ghvgQZ79FeoPrVJkz kznw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=OYB6aitYDAPiSyvPp01lKGipULN/YvBNiq+jSKtU9JQ=; fh=mOffzU9vuesIBf+gb20MIMY8nstF/xFjIQFKIx9KM34=; b=gICKB6hPquuADgAxQwQDTVzn5nwVJHUiac34CJZDW32RwBKo0dNEDq9xbmrZYn2o/z OwH9cBI/NeRGu6aGzYTCKEucDENcaBNPSj/2uyF6l5ZhLS6XBYMQCyukFuCCke2eLfL2 XNISHuTMxcyHqR+6vyDZE0FAnYCkmQBrktPZhErdQ/C4m4+walIkukDBfg0SJI2NhzV1 kSiLGy7n51L+drsoq36Ap1emiQ4QQTavhmvkwHfp2STIZUtcV8y6JStj6aL9oA8NTUx1 12/qRbRWkAx7T8BDujtKVgSrZyM4YlsL1C5CZ+EcI/VMfAmnbAWN2yyESPmKwIvMSzII saPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12265-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12265-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id p23-20020a67e957000000b00466f68c4b6bsi909482vso.621.2023.12.27.13.04.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 13:04:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12265-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12265-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12265-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 0DA4C1C226C6 for ; Wed, 27 Dec 2023 21:04:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1671149F7D; Wed, 27 Dec 2023 21:03:05 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C397481BB for ; Wed, 27 Dec 2023 21:03:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIb3L-0000tA-SH; Wed, 27 Dec 2023 22:02:59 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIb3K-001wFR-BB; Wed, 27 Dec 2023 22:02:59 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIb3L-001ZW0-1A; Wed, 27 Dec 2023 22:02:59 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jassi Brar Cc: Michal Simek , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 12/12] mailbox: zynqmp-ipi: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 22:02:40 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1705; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=2b4lUlitkOljYy3sRlFRPbTFvrd9xaqPFryNUK1ZN6s=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljJDzqFtl2kmovE8iqyRfcBJPoRlc6qiRy4eJR F/jvpWQQLmJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYyQ8wAKCRCPgPtYfRL+ TquyB/438vvpPAS3YP4QZzU/Aul2i7Mo5ML2J494dFbYViAl7ltgPfwkDcmca92QlWMEgpAV5VJ 0Yz+wQ4sKk2dWxYStXrFjG9Tniz39LdfLE8wxN7CY6gZ0YYN4kQOYzxQ88/KhvJhCqcsR1L20uu v6y5zySpr2H55+n20BfVMLgJ7NjH7/wmJl2ljlB7J/hDAykGUaA6UN1qk/CYrpcGZiVrr5QeMJE TuwlgdrzNYzx896y0DL9yWRv5PhOM523C9tHqBl1tC4zyWIFTeFR1Lxr+LiEQEcH6Quta3/fz7A z2bSAusqvyIraXRkdrL/bHAFB+Didj4tkwikvO/HJUZX+a3O X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786470546492688137 X-GMAIL-MSGID: 1786470546492688137 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Michal Simek --- drivers/mailbox/zynqmp-ipi-mailbox.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c index 7fa533e80dd9..610a92f9c0b2 100644 --- a/drivers/mailbox/zynqmp-ipi-mailbox.c +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c @@ -688,19 +688,17 @@ static int zynqmp_ipi_probe(struct platform_device *pdev) return ret; } -static int zynqmp_ipi_remove(struct platform_device *pdev) +static void zynqmp_ipi_remove(struct platform_device *pdev) { struct zynqmp_ipi_pdata *pdata; pdata = platform_get_drvdata(pdev); zynqmp_ipi_free_mboxes(pdata); - - return 0; } static struct platform_driver zynqmp_ipi_driver = { .probe = zynqmp_ipi_probe, - .remove = zynqmp_ipi_remove, + .remove_new = zynqmp_ipi_remove, .driver = { .name = "zynqmp-ipi", .of_match_table = of_match_ptr(zynqmp_ipi_of_match),