From patchwork Sat Jul 22 20:07:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 124375 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp987711vqg; Sat, 22 Jul 2023 14:27:50 -0700 (PDT) X-Google-Smtp-Source: APBJJlGFMIdfN3IH0EYta5IVkeUC64n59O7kSzBXFAiL/bStt2FMePoEBqIhoSGkZpnwN5naKIDC X-Received: by 2002:a17:906:5a53:b0:994:5457:269e with SMTP id my19-20020a1709065a5300b009945457269emr5900472ejc.0.1690061270529; Sat, 22 Jul 2023 14:27:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690061270; cv=none; d=google.com; s=arc-20160816; b=VdUcTTZ4+dPwsVC/z/vjP0eAhgU0Vvib/itVZ8jBMZgA77GY0OnqOQP0VedkuZKhHg uWEkutOEjlUPibIQJCkPfGSA0+pR+tmEd91++d2byHw5HHKkP4D6o1+GJfI66cGPqut3 IfDMO4TvLgyRtKb6yH3elO0e/BPd6fFxszK1dJLvZJswkoKZUdcr4gHouaCCZnOCh9k/ j8z4EYP2pJMfROImko3FNJYNALP8enEWIODAat34iRmnx50zcQc0EwvTwZTT3hOG1PkQ UY9o+xz6cd1c7NLF+cPQGLvii4g+9sHl+XEpEN6+6Gf9yrJItWbc56e+KA3uSxGPdFy2 ieJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=7S4ycyHIMkZJiLKQzCPxeyh+eo13SBWOIVq3MxxljJ4=; fh=fHKaArVFDNGuCprxZ4P7753ZBBnilkZuwaWujQCbTxM=; b=MQ9nfYjCZJ0lE5tot5RjyG7kkZqaYp4z4vlwV1g89Xesfuv4HtFY0BiNkPnIkk4U9O 8dVUfUtFaLQ+bZNX7liX4PzVXmqOxFH/CoJq0JPqj946F9AbhGcOMPo38WCa6vHKuQkH LyLb5i2c3vVW4DId1lC/ub5gN4KA0BsVpYRSVB1kqTOH5IxQgbmNis0l+spaackHMLMD AOnB1HaE5UGPwDvx2abiRH7E8Gf7fGUr02RFMR0Out4A/gZGkZdcLaGfaYzEPOGsNZ7T kTy543K4bCAYDMEkhlrtgDKdqZoHEDyAnY/n39BOlvG7ULaLh5IIr+MdldvG7bZ9l50n Onww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=H1cITbJG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m24-20020a170906235800b009893fe84e74si4186239eja.484.2023.07.22.14.27.27; Sat, 22 Jul 2023 14:27:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=H1cITbJG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229833AbjGVUHq (ORCPT + 99 others); Sat, 22 Jul 2023 16:07:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbjGVUHn (ORCPT ); Sat, 22 Jul 2023 16:07:43 -0400 Received: from smtp.smtpout.orange.fr (smtp-30.smtpout.orange.fr [80.12.242.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B3CB2137 for ; Sat, 22 Jul 2023 13:07:39 -0700 (PDT) Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id NIsyqCllLulAmNIszqCc5G; Sat, 22 Jul 2023 22:07:31 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1690056451; bh=7S4ycyHIMkZJiLKQzCPxeyh+eo13SBWOIVq3MxxljJ4=; h=From:To:Cc:Subject:Date; b=H1cITbJGrQCdw/dC2WdazoyVY0mrYULO1Vall8mjmOZhUf2HpWZfD5DXrHO7Fn447 iY3GHjnyT2VmoVdqX5leLbMcYQnneDP9YXuVSUKXMTUtiqDNTKVMS5T7Ki5SK2BOmi QRef6/MoHPpVKxzX+YnsLQdwSUYSUZ2FKJjF+2cn/z/VEHHKzXFzWMgX0gMqsrkdZ3 x403vWMINEMsctZ55M0vSjPQ7iDnes1FYWLJwL77q3Wuum82zXi94W+cvARrsWfGrJ vAMGUCVychN9LGChTN1g0SOTA5QWooUmDW19fCFBSlB8ec//PDWhefBwKbFsNQBF4q 9D9y0+LtrieXQ== X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 22 Jul 2023 22:07:31 +0200 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: Alexander Shishkin , Maxime Coquelin , Alexandre Torgue Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH] stm class: Use struct_size() Date: Sat, 22 Jul 2023 22:07:26 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772157686450406217 X-GMAIL-MSGID: 1772157686450406217 Use struct_size() instead of hand-writing it, when allocating a structure with a flex array. This is less verbose, more robust and more informative. Signed-off-by: Christophe JAILLET --- It will also be helpful if the __counted_by() annotation is added with a Coccinelle script such as: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?h=devel/counted_by&id=adc5b3cb48a049563dc673f348eab7b6beba8a9b --- drivers/hwtracing/stm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c index 534fbefc7f6a..2195310ab81c 100644 --- a/drivers/hwtracing/stm/core.c +++ b/drivers/hwtracing/stm/core.c @@ -863,7 +863,7 @@ int stm_register_device(struct device *parent, struct stm_data *stm_data, return -EINVAL; nmasters = stm_data->sw_end - stm_data->sw_start + 1; - stm = vzalloc(sizeof(*stm) + nmasters * sizeof(void *)); + stm = vzalloc(struct_size(stm, masters, nmasters)); if (!stm) return -ENOMEM;