mbox series

[GIT,PULL] Btrfs fix for 6.4-rc8

Message ID cover.1687283675.git.dsterba@suse.com
State New
Headers
Series [GIT,PULL] Btrfs fix for 6.4-rc8 |

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-6.4-rc7-tag

Message

David Sterba June 20, 2023, 6:24 p.m. UTC 
  Hi,

one more regression fix for an assertion failure that uncovered a nasty
problem with stripe calculations. This is caused by a u32 overflow when
there are enough devices. The fstests require 6 so this hasn't been
caught, I was able to hit it with 8.

The fix is minimal and only adds u64 casts, we'll clean that up later. I
did various additional tests to be sure. Please pull, thanks.

----------------------------------------------------------------
The following changes since commit b50f2d048ecf1512ff85128ea4153bceb0e60590:

  btrfs: scrub: fix a return value overwrite in scrub_stripe() (2023-06-14 18:30:30 +0200)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-6.4-rc7-tag

for you to fetch changes up to a7299a18a179a9713651fce9ad00972a633c14a9:

  btrfs: fix u32 overflows when left shifting stripe_nr (2023-06-20 19:10:31 +0200)

----------------------------------------------------------------
Qu Wenruo (1):
      btrfs: fix u32 overflows when left shifting stripe_nr

 fs/btrfs/volumes.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

Comments

Linus Torvalds June 20, 2023, 7 p.m. UTC | #1 
On Tue, 20 Jun 2023 at 11:30, David Sterba <dsterba@suse.com> wrote:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-6.4-rc7-tag

I think you forgot to push the tag.

I see 'refs/heads/for-6.4-rc7' in your repo that contains the commit
you mention, but no corresponding signed tag.

                Linus
David Sterba June 20, 2023, 8:06 p.m. UTC | #2 
On Tue, Jun 20, 2023 at 12:00:35PM -0700, Linus Torvalds wrote:
> On Tue, 20 Jun 2023 at 11:30, David Sterba <dsterba@suse.com> wrote:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-6.4-rc7-tag
> 
> I think you forgot to push the tag.
> 
> I see 'refs/heads/for-6.4-rc7' in your repo that contains the commit
> you mention, but no corresponding signed tag.

Ah right, sorry, now pushed.
pr-tracker-bot@kernel.org June 20, 2023, 10:53 p.m. UTC | #3 
The pull request you sent on Tue, 20 Jun 2023 20:24:01 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-6.4-rc7-tag

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/4b0c7a1ba09386e26cf9e55cd375af8e0f48662e

Thank you!