From patchwork Mon May 8 12:36:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Konstantin Komarov X-Patchwork-Id: 91110 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2121750vqo; Mon, 8 May 2023 05:37:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ75hkZJiXYcV/gfpSoIRwi9rM57AzsCUuOv1zZg7HIt+siLOfpmdWDdBm8BapAURnwlOORp X-Received: by 2002:a17:902:f80a:b0:1a2:749:5f1a with SMTP id ix10-20020a170902f80a00b001a207495f1amr15471176plb.26.1683549468197; Mon, 08 May 2023 05:37:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683549468; cv=none; d=google.com; s=arc-20160816; b=jmxZNxNZ1c5KkVliM0VcHIQUtZoOzF/8ZoxJJgFq1lZqpJJ20Vm5QtVLmpNlQO8RBx UJ3L5n9jhtKOEwc0AM0+iubHk1EweCyK9na8fSQJDCFYCHMPMWeL8Hrk7QsDqKMDXg6e 1hAeEBRuUMCF4xQ8OiOCRy5XGnL/joeRvjwqHt1gktBNtM94vSxd0GKVJBXY4VKFri2Q cMLI41WR1dlrEzuudf1abnTrJUWFlO5UuMH+JksgVTIlXl5ikLoEyOtsNFiuH0MXpFQa AqVidGJlOVWiGwZMHsTEwxeIheiHRgVxbiNxDkhFDqGOL+VCfRo1Z1+7tu49rzUpECv5 QX3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature:dkim-signature; bh=h5cbTykc9cuI68jfwGBg6SVUQfDSQ4DeVKUgsn+zaao=; b=H/qcWWkBMxwy6hxhihCmreqYcc0lOEc1aNP79IQ/JV5mr3CSKBgbEKYq+WR7/0PZ8p tZ3MfHejY8olfVfm7sAvYw9PLx66BE+NZw+81+8wRnjgtpdJ/iPEmnN/rlV6MzNPdUjp OLLvRxzf/T/3Xzd7CmdU3p8jlgOVCyktjIh3XmkLVmaYKOjXhQZMpcVrafcRKhhI9fkd Ru89tX0w+nWQiIdaguKWvthQi7qyoopdc4TBIHJ9aY310wC/c9hljxCPRfMgdqK2IT/9 q5Pyu7g9XUSV9skFR70tiUOJvyj04LQ4iW4PDaDnd9mZNPLcDnKvtx//Awh2fgXZADfa Uq8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paragon-software.com header.s=mail header.b=IrRYPMph; dkim=pass header.i=@paragon-software.com header.s=mail header.b=hm7oaKhj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=paragon-software.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h15-20020a17090aa88f00b00226e01736f8si25192412pjq.109.2023.05.08.05.37.32; Mon, 08 May 2023 05:37:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@paragon-software.com header.s=mail header.b=IrRYPMph; dkim=pass header.i=@paragon-software.com header.s=mail header.b=hm7oaKhj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=paragon-software.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233847AbjEHMgz (ORCPT + 99 others); Mon, 8 May 2023 08:36:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233918AbjEHMgo (ORCPT ); Mon, 8 May 2023 08:36:44 -0400 Received: from relayaws-01.paragon-software.com (relayaws-01.paragon-software.com [35.157.23.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4986D391BE; Mon, 8 May 2023 05:36:39 -0700 (PDT) Received: from relayfre-01.paragon-software.com (unknown [172.30.72.12]) by relayaws-01.paragon-software.com (Postfix) with ESMTPS id 8DF8E21C3; Mon, 8 May 2023 12:31:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paragon-software.com; s=mail; t=1683549110; bh=h5cbTykc9cuI68jfwGBg6SVUQfDSQ4DeVKUgsn+zaao=; h=Date:Subject:From:To:CC:References:In-Reply-To; b=IrRYPMph4pWjLaHDypU5B9Y9R8yzwcToPVA1MQT0qienyTf8C7Jc/lyXDBRspjxm3 xBjgaKNCbXDoM4ITCj4bNnfrFkSulkmJlrN1KvGcO16aiOWNnJ/YQhrWutKP5hdwFd f+Js0zqSZmcLd9I6q7WK31VNpe0aZbd0Rtd1hXRM= Received: from dlg2.mail.paragon-software.com (vdlg-exch-02.paragon-software.com [172.30.1.105]) by relayfre-01.paragon-software.com (Postfix) with ESMTPS id 3F15B2191; Mon, 8 May 2023 12:36:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paragon-software.com; s=mail; t=1683549397; bh=h5cbTykc9cuI68jfwGBg6SVUQfDSQ4DeVKUgsn+zaao=; h=Date:Subject:From:To:CC:References:In-Reply-To; b=hm7oaKhjn6FnPfk/UtGsGFWrGvBA3FZap6DH8mF8yNUveTW8HtyndqQPBPLq0ejLy WPcBcwjAY7MnJdaxo42FUMZr12HEfrb37EbjxJ54u171P56ki/U8JhYVPTp1BxIE9j NoRKwmUiiObDkS0+UUxS6B5laYvBTH6CFeDXKSLc= Received: from [192.168.211.146] (192.168.211.146) by vdlg-exch-02.paragon-software.com (172.30.1.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Mon, 8 May 2023 15:36:36 +0300 Message-ID: Date: Mon, 8 May 2023 16:36:36 +0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH 02/10] fs/ntfs3: Fix ntfs_atomic_open Content-Language: en-US From: Konstantin Komarov To: CC: Linux Kernel Mailing List , References: In-Reply-To: X-Originating-IP: [192.168.211.146] X-ClientProxiedBy: vobn-exch-01.paragon-software.com (172.30.72.13) To vdlg-exch-02.paragon-software.com (172.30.1.105) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765329567424090126?= X-GMAIL-MSGID: =?utf-8?q?1765329567424090126?= This fixes xfstest 633/696. Signed-off-by: Konstantin Komarov ---  fs/ntfs3/namei.c | 15 +++------------  1 file changed, 3 insertions(+), 12 deletions(-) -                    finish_open(file, dentry, ntfs_file_open); +                  finish_open(file, dentry, ntfs_file_open);      dput(d);  out2: diff --git a/fs/ntfs3/namei.c b/fs/ntfs3/namei.c index 9736b1e4a0f6..343bce6da58a 100644 --- a/fs/ntfs3/namei.c +++ b/fs/ntfs3/namei.c @@ -422,19 +422,10 @@ static int ntfs_atomic_open(struct inode *dir, struct dentry *dentry,       * fnd contains tree's path to insert to.       * If fnd is not NULL then dir is locked.       */ - -    /* -     * Unfortunately I don't know how to get here correct 'struct nameidata *nd' -     * or 'struct mnt_idmap *idmap'. -     * See atomic_open in fs/namei.c. -     * This is why xfstest/633 failed. -     * Looks like ntfs_atomic_open must accept 'struct mnt_idmap *idmap' as argument. -     */ - -    inode = ntfs_create_inode(&nop_mnt_idmap, dir, dentry, uni, mode, 0, -                  NULL, 0, fnd); +    inode = ntfs_create_inode(mnt_idmap(file->f_path.mnt), dir, dentry, uni, +                  mode, 0, NULL, 0, fnd);      err = IS_ERR(inode) ? PTR_ERR(inode) :