Message ID | cbf47824fc726440371e74c867bf635ae1b671a3.1669126766.git.nickyc975@zju.edu.cn |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2232354wrr; Tue, 22 Nov 2022 06:28:01 -0800 (PST) X-Google-Smtp-Source: AA0mqf5AdtfhZ06KJXGNxEaijwzagccW2U3w/ngFECBwHk8ybm+A/ZIqamykH1Fi0oo4SPkkBbST X-Received: by 2002:a05:6a00:3204:b0:574:31bb:a576 with SMTP id bm4-20020a056a00320400b0057431bba576mr673637pfb.46.1669127281310; Tue, 22 Nov 2022 06:28:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669127281; cv=none; d=google.com; s=arc-20160816; b=Zvz8k55jInGXvtGuDYLs1dxqe6dwegePsf/vcegRHwh960iOxUU6r0dZ2S4KRysxk/ ICTwtfEYeCZ22hrDl++mAg60PIr4HT/PsHF8YBW7NWHXKDbWmYdSwncW33Ro39snHXKh /dkiDjXEYCAy6TAhCqBE18FgW6cF9CiT4V+MZUQ6/c4sQYw+NK46vikxNqmFk/36zBPi KOSoPbyVqAMw/Pl8Mk5zap9na9IxhSi4kc8PdqzOhuv6jQz3fsKj34OviFgFfP+ny+iC dALtB69hyK24HGMauDEn+UhN4kmyyYPyWJfQNjTdqL3ANcm/l2ai0oGiVdQi+KOri9+Z pHxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ZDZS1Vohgob9LOT0XdIIS8ecuf92i8BSdW6ETo1UII8=; b=sLDWGVrvIambGBXcdJt3pZuuBovoHDCXG4YCQIFeM7HRrrRNEpEw4P3NJIpvg1V7rR pHfQfdys1KsB/f/jricx0FdD4lMg1iLHom7x6PDmkZIYiuhJiwGdhRrRMu6+IEe6aroy MduUPpykuSdqwbOkxaj1HdLBTKnh7dsDUewqrivoyOq+XkkCC/Amo7CunCNLJ88kXpEX JBS3AKhjlNs/nlZLD4KcDWNfiiO7PBWMbKhsBKoZKRogl0c5p2Qe/1SML49vMyNEQeOH yBQdYn8hjF0yS3qrQ22DWbL6vDjlYM2EQKzlAGuGvEI0jrd1L9CA/JTZNoXvnQaCT87D +KVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t17-20020a170902e85100b001870dc9ef63si16116539plg.129.2022.11.22.06.27.46; Tue, 22 Nov 2022 06:28:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233691AbiKVOWK (ORCPT <rfc822;cjcooper78@gmail.com> + 99 others); Tue, 22 Nov 2022 09:22:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233492AbiKVOVs (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 22 Nov 2022 09:21:48 -0500 Received: from zju.edu.cn (mail.zju.edu.cn [61.164.42.155]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 48A246829D; Tue, 22 Nov 2022 06:21:46 -0800 (PST) Received: from localhost.localdomain (unknown [10.14.30.50]) by mail-app4 (Coremail) with SMTP id cS_KCgCHrN_o2nxjHR5BCA--.15646S6; Tue, 22 Nov 2022 22:21:43 +0800 (CST) From: Jinlong Chen <nickyc975@zju.edu.cn> To: axboe@kernel.dk Cc: hch@lst.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, nickyc975@zju.edu.cn Subject: [PATCH 4/4] elevator: remove an outdated comment in elevator_change Date: Tue, 22 Nov 2022 22:21:26 +0800 Message-Id: <cbf47824fc726440371e74c867bf635ae1b671a3.1669126766.git.nickyc975@zju.edu.cn> X-Mailer: git-send-email 2.34.1 In-Reply-To: <cover.1669126766.git.nickyc975@zju.edu.cn> References: <cover.1669126766.git.nickyc975@zju.edu.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: cS_KCgCHrN_o2nxjHR5BCA--.15646S6 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUY37CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAac4AC62xK8xCEY4vEwIxC4wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC 0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr 1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IE rcIFxwCF04k20xvY0x0EwIxGrwCF04k20xvE74AGY7Cv6cx26r4fKr1UJr1l4I8I3I0E4I kC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWU WwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr 0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWU JVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJb IYCTnIWIevJa73UjIFyTuYvjfUOlksUUUUU X-CM-SenderInfo: qssqjiaqqzq6lmxovvfxof0/1tbiAgECB1ZdtciuiwAAsV X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750206808288506955?= X-GMAIL-MSGID: =?utf-8?q?1750206808288506955?= |
Series |
random improvments and cleanups for elevator.c
|
|
Commit Message
Jinlong Chen
Nov. 22, 2022, 2:21 p.m. UTC
mq is no longer a special case.
Signed-off-by: Jinlong Chen <nickyc975@zju.edu.cn>
---
block/elevator.c | 3 ---
1 file changed, 3 deletions(-)
Comments
On Tue, Nov 22, 2022 at 10:21:26PM +0800, Jinlong Chen wrote: > mq is no longer a special case. But switching to none still is a special case. Then again this should be very obvious from the code, so I'm fine the comment removal: Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/block/elevator.c b/block/elevator.c index 5287b39cd7a9..599413620558 100644 --- a/block/elevator.c +++ b/block/elevator.c @@ -721,9 +721,6 @@ static int elevator_change(struct request_queue *q, const char *elevator_name) if (!blk_queue_registered(q)) return -ENOENT; - /* - * Special case for mq, turn off scheduling - */ if (!strncmp(elevator_name, "none", 4)) { if (q->elevator) elevator_disable(q);