From patchwork Tue Jul 18 16:54:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 122172 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1905244vqt; Tue, 18 Jul 2023 10:37:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlEApXR46q+JYzqSV3OE36szfVDGD09h2aLGNVd8ZMbN8pQesN1kvo0XiZOr8YBNS/h2wSCw X-Received: by 2002:a17:907:8a07:b0:989:450:e585 with SMTP id sc7-20020a1709078a0700b009890450e585mr490827ejc.45.1689701854666; Tue, 18 Jul 2023 10:37:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689701854; cv=none; d=google.com; s=arc-20160816; b=Ng5ucAf//91D4IbCwdq9AyUGxe5Fd4BaB6Jt8S4rzQByDE/zzOSd+igSN+R3J38hiE YCqiVJkPbyUadJWHuh8Ged/efKBaLEcl9KnVxYBomchkDtqYTADAkuRzMriBt1FP/p7x vpsR+2J2y1n5ABW4YEJIyxzHBIutlMfTYJQkA6GMI/JXBuAst2kc3cUfzqx0Fa1XKLXq 2RDK4QZe3TB7I/u1IFHRI7AfZMReupG4cNctnV0/2Va1fLlzScGZbjFYpSdPaedQhFkq ljwEwW5yE26ASSzZ71T4c+xa+8XYHS90s1aRIrqV9phR1vUQUx/hDOPZ3T8af3ysgFua iF6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=V76NAgd7f1t/otXXRcnIYYSN2NX/p2qH/dPlqdSZNiY=; fh=Ople2ijcDVdvBJwvAg2RvyZp0qNZK7It46SN0LxlrVk=; b=yfjZXQQ0W4rk6UY8qKKSTe573mKGu9D0j4wtA3i82AEdTb7PoiXm9l+kFisc+AplhG XDwcS96MluRcL7BB92d37x/9cxVfAl0HuIPYl0qsvAVAnKxBKMl8VEGBNtRyc7iAxXvW FtvOWMXaEeQ+T+bARHLYfENg+3DF6yJuasvknMfpmP0Ba/u3MwttCp5laDiTqJTA1B5K Fc+trCXvdxDk5WdgNBL2HOudJUC5Ne/LSB/TzB0NTKpKIXGFJvZE8k0yJHyAsJe8/42a lgb/hbEnTqrRfPhBb4a8bWPmcmSNojRe8li0j2ReBBdaJ28MHq60q3TYIAdWxwgJSuFq Bkpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sb8-20020a170906edc800b009828298ddd5si1527556ejb.259.2023.07.18.10.37.10; Tue, 18 Jul 2023 10:37:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233559AbjGRQzj (ORCPT + 99 others); Tue, 18 Jul 2023 12:55:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232471AbjGRQzA (ORCPT ); Tue, 18 Jul 2023 12:55:00 -0400 Received: from xavier.telenet-ops.be (xavier.telenet-ops.be [IPv6:2a02:1800:120:4::f00:14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 022741719 for ; Tue, 18 Jul 2023 09:54:54 -0700 (PDT) Received: from ramsan.of.borg ([84.195.187.55]) by xavier.telenet-ops.be with bizsmtp id Ngur2A00i1C8whw01gur1W; Tue, 18 Jul 2023 18:54:53 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qLnyD-001nZR-KZ; Tue, 18 Jul 2023 18:54:51 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qLnyN-000gdb-Li; Tue, 18 Jul 2023 18:54:51 +0200 From: Geert Uytterhoeven To: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Laurent Pinchart Subject: [PATCH v2 31/41] drm: renesas: shmobile: Move shmob_drm_crtc_finish_page_flip() Date: Tue, 18 Jul 2023 18:54:36 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771780811582677809 X-GMAIL-MSGID: 1771780811582677809 Move the shmob_drm_crtc_finish_page_flip() function up, to avoid having to move it during the modification in the next change. Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- v2: - Add Reviewed-by, - Move further up. --- .../gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 36 ++++++++++--------- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c index f55b5263e611c782..0adf5d33ba31695e 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c @@ -35,6 +35,26 @@ * TODO: panel support */ +/* ----------------------------------------------------------------------------- + * Page Flip + */ + +void shmob_drm_crtc_finish_page_flip(struct shmob_drm_crtc *scrtc) +{ + struct drm_pending_vblank_event *event; + struct drm_device *dev = scrtc->base.dev; + unsigned long flags; + + spin_lock_irqsave(&dev->event_lock, flags); + event = scrtc->event; + scrtc->event = NULL; + if (event) { + drm_crtc_send_vblank_event(&scrtc->base, event); + drm_crtc_vblank_put(&scrtc->base); + } + spin_unlock_irqrestore(&dev->event_lock, flags); +} + /* ----------------------------------------------------------------------------- * CRTC */ @@ -364,22 +384,6 @@ static const struct drm_crtc_helper_funcs crtc_helper_funcs = { .mode_set_base = shmob_drm_crtc_mode_set_base, }; -void shmob_drm_crtc_finish_page_flip(struct shmob_drm_crtc *scrtc) -{ - struct drm_pending_vblank_event *event; - struct drm_device *dev = scrtc->base.dev; - unsigned long flags; - - spin_lock_irqsave(&dev->event_lock, flags); - event = scrtc->event; - scrtc->event = NULL; - if (event) { - drm_crtc_send_vblank_event(&scrtc->base, event); - drm_crtc_vblank_put(&scrtc->base); - } - spin_unlock_irqrestore(&dev->event_lock, flags); -} - static int shmob_drm_crtc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb, struct drm_pending_vblank_event *event,