From patchwork Wed Dec 27 21:02:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183565 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1666066dyb; Wed, 27 Dec 2023 13:04:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IGrM5mFUFgEwXrckjBKEdVrA78+UDnUDM+jJtJqT98Z/mAZb7Ph0lMit1v7JjU+jIjnfzQ9 X-Received: by 2002:aa7:998e:0:b0:6d9:a856:ec9b with SMTP id k14-20020aa7998e000000b006d9a856ec9bmr6917459pfh.25.1703711077542; Wed, 27 Dec 2023 13:04:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703711077; cv=none; d=google.com; s=arc-20160816; b=BnYcvaaUOG5YTBA9X0K6U2mC/bd1HcIcQ8AcETZh7u28vl/E4fmTS8YXCy3lqpjMOT y6MaKSZRPqpIKfDrGprABVbQ//6iboumGTrI2djfJ3Nm2ZmRRNBaEAC37tJxUE8NW3Xr +ia6ueuINpX4ciPFwFVefZSn9u+cwcrVONqu8EyWdviU9CAYlMNMaYGzXM3XE1Oj37Yx GOwx/zaFp4RxGgNQROhR3wQbyPdMO+t2dOhKyfa7IBh7JStI6LUemGSlBexxiDUX+BI/ MnACnHJOx2uDENBqZvsrr3jXxdhmhNJBawxHR0K3s1FN4/6BITJ3COPzdOGA6mVW8gRc YsEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=QPgSQGtHC0iwqzU7zRiU2EM3jg+35c1QbIzYsPSzag0=; fh=9Ymq9WTXqHRlhbTIgATkHrbGXdIaHSZtaGutPygdzak=; b=XYb9z5/SjRpArUG7NWrHHYVrG3hBmemuHc3yponGw4BlEZOF9moxZFdZtPjGPvq9/y 7SYsrmzlvsicr9oylNVolgG6ppxUWfvqaaZ1EO01iP+ygks7LQPZPnRrox3MgrHIAxTn mzPt0xxzNHoo5ZC0lqREFCmuHPl9YVl+f+HaIT2uTuXiQO6blCt0u719VT77r1FySo85 IfFPsgJGT7dB6Z9i0F9UmilTPJ9qWgkhqSWoZGmIf66OoKyfgch1MJqrkHohVqO6c6gj 4k1lprYe/61B4OMOh1HKlg53ohWP0I/fNfzH/2wYSyeQC7goDmcFYU0UGc3K+/tTjSnM aP8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12264-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12264-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id p8-20020a63e648000000b005cd88585706si11583599pgj.828.2023.12.27.13.04.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 13:04:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12264-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12264-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12264-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2C125283EAB for ; Wed, 27 Dec 2023 21:04:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1DAF249F7E; Wed, 27 Dec 2023 21:03:05 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A37F481A5 for ; Wed, 27 Dec 2023 21:03:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIb3J-0000mR-JU; Wed, 27 Dec 2023 22:02:57 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIb3I-001wEs-02; Wed, 27 Dec 2023 22:02:57 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIb3J-001ZVQ-01; Wed, 27 Dec 2023 22:02:57 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jassi Brar Cc: Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 03/12] mailbox: imx: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 22:02:31 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1729; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=tu7OGIAh4t5eSo5RkymTUYbo/0xSaIoNAc2ogwnsVgo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljJDodYLH7tkz1QmIENibmLSj5ppFvhRT8H2EQ iVhsDahxNyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYyQ6AAKCRCPgPtYfRL+ TgfFCACPAWNWZETI1tvYwCrw2K4KfE4KqyAXJTss7x7RZKwriOCHeV05ZuvPw3lhNC0qyk9FoZj Z0LwpZq+kn4+yHziqi6i05zT71n51CZNdTQ2kSm6fMd4XxYlC/O5FGYKcOMLLTx7LBQZ7HuiYYl ZsK0Av6p9SLZbIkW770H8l8YmXbFb1ICniZ8xda0nUV37u9lToGXiH1jPdgHP3GdSbL9YsoCqxS PqhBOziRKbN6KRzm8SMjAn9YEbOYXd9KV6PjldGpuiwpv0UGDjlHeRi8u9I0KQcwrHaJuo/BZO6 OmITM3R0hpu1/G7u9Cp7S8D1+F6aoc6rSHhFi4GcNsFCEynj X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786470546817448571 X-GMAIL-MSGID: 1786470546817448571 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mailbox/imx-mailbox.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c index 0af739ab571c..656171362fe9 100644 --- a/drivers/mailbox/imx-mailbox.c +++ b/drivers/mailbox/imx-mailbox.c @@ -903,13 +903,11 @@ static int imx_mu_probe(struct platform_device *pdev) return ret; } -static int imx_mu_remove(struct platform_device *pdev) +static void imx_mu_remove(struct platform_device *pdev) { struct imx_mu_priv *priv = platform_get_drvdata(pdev); pm_runtime_disable(priv->dev); - - return 0; } static const struct imx_mu_dcfg imx_mu_cfg_imx6sx = { @@ -1070,7 +1068,7 @@ static const struct dev_pm_ops imx_mu_pm_ops = { static struct platform_driver imx_mu_driver = { .probe = imx_mu_probe, - .remove = imx_mu_remove, + .remove_new = imx_mu_remove, .driver = { .name = "imx_mu", .of_match_table = imx_mu_dt_ids,