From patchwork Mon Dec 25 18:12:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183231 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp505448dyb; Mon, 25 Dec 2023 10:14:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IEdd3+YhEqfFOZTB9Dcwf1lb/Trjy/2/voU4hZ+DZrsTi8NFX9qjSFtPu+fDE6xSjUabyI8 X-Received: by 2002:a05:6a00:1acc:b0:6ce:54dc:2d0b with SMTP id f12-20020a056a001acc00b006ce54dc2d0bmr7573658pfv.1.1703528070433; Mon, 25 Dec 2023 10:14:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703528070; cv=none; d=google.com; s=arc-20160816; b=qvq5qBYHRTkICJeqTBdCKLkqAKZPras/2u7vWQBhaYxmhCGWdstHw+SUAwoAOWB8w0 0tww0MEyw8zwAqRz7+sAlQXjAo5lLQxKKASLsWpdttOrnzYL6hTjwSLFfCJncKEkdHe8 0LxI8IIg/Xt4X/N3GuLvYCvpdEd5ZkVTTYM1bwdsua+L0l3fhiLIEnyej3BxEjGqUwj2 NmOPXgJiytwzdooyvQQZGT7zKNSf7mOr65YZe+lrx7OfN+oWpGD8bW9FReiLNN/6m7Mw YTb9LeORqP97TQ8p/2RZjtqbB5EpWIJRbE6CwxPdHcKi8E40rSuRCwObXczBkM8hK0l7 L0YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=0z0S00f2ZIklO3oMFIEHJnraJG3Q0f07S/78f9Nkjik=; fh=ur5raHTd+jMarMVUZtd7ICu2SclynYpUY/AZehLvF+E=; b=udk403n8kCgSfoHSBHuP8Y0QNuFTZ/ai+NsJQOuB+0QaEyGa/7z37l64BrJNyaXBk7 J1M/RKP3nJQeosYFdPSoT/lTz/rhdO7ogBXziFsUAxjO08O7RBvoufj4yRLY0kxq9e+W h5YuMPN81D06c62fbqfaonmI1CbALADPaj2JiEs0msmMtGYRWzvcVnw2lC2wQ4CqEBsF w/kBrF2aioQqbN94x42zGOOtrqI843iyjkRaP1A99XyNvNIJ4Kx0E+smXQutEeeDChtB EzPq5ZRVGa2jQUdqRnS8dpVs2S9i5JlOp+di8bxS+5McT/VJdzS/JOwHhjtwxEpRyJ97 NVvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-11141-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11141-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id l184-20020a6325c1000000b005c690745520si5101359pgl.743.2023.12.25.10.14.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Dec 2023 10:14:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-11141-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-11141-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11141-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A92F8B21864 for ; Mon, 25 Dec 2023 18:14:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EC48C53E1B; Mon, 25 Dec 2023 18:13:31 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D96552F9C for ; Mon, 25 Dec 2023 18:13:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rHpS2-00024Y-Ur; Mon, 25 Dec 2023 19:13:18 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rHpS0-001TaU-OR; Mon, 25 Dec 2023 19:13:17 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rHpS1-000xT8-2T; Mon, 25 Dec 2023 19:13:17 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-pwm@vger.kernel.org Subject: [PATCH v2 1/2] bus: ts-nbus: Convert to atomic pwm API Date: Mon, 25 Dec 2023 19:12:52 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1441; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=61dg6kJV4BhcvrrnMUjQLyQd3kNaWCq2zXIx0/k9U3g=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlicYrApVp2AghnOZRenfLlyNCDj11FmxSGu9Tm SyzdkyY+PeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYnGKwAKCRCPgPtYfRL+ ToNKCACAbl7r+yqdYqOTwZnl/WI1HPX8dJjgKDztfwqjRdX289u0rz3IxHS+WV3yldixYTSV/zD cAzGJxECh7drgCgzQG89WyYnL3Jm71lmEqD/ax77fxCcWWHVCqvgTIOz6Jp9Bu8cpSL3NQ5iUzM lP9IoTAmIz0nXyZEJKgW80W/K7c3XI6N35mYz9N1xoqVOdvoluXCvOPywN2lxPIy1dNvt/tRL0g m2Z+HhGb0c2+oaU1fWh6Wezew7lVtOzxq7R1/UmwRJcMby79Y8tRkaRjt1kU3aZ94E6ZThG2q3H F6DyWXl20cCqaMPIkmwMkhJNODzL3oFKGFrnmn98IwRnJQv4 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786278650100459957 X-GMAIL-MSGID: 1786278650100459957 With this change the PWM hardware is only configured once (instead of three times). Signed-off-by: Uwe Kleine-König --- drivers/bus/ts-nbus.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index 4fa932cb0915..19c5d1f4e4d7 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -273,7 +273,7 @@ EXPORT_SYMBOL_GPL(ts_nbus_write); static int ts_nbus_probe(struct platform_device *pdev) { struct pwm_device *pwm; - struct pwm_args pargs; + struct pwm_state state; struct device *dev = &pdev->dev; struct ts_nbus *ts_nbus; int ret; @@ -296,25 +296,22 @@ static int ts_nbus_probe(struct platform_device *pdev) return ret; } - pwm_get_args(pwm, &pargs); - if (!pargs.period) { + pwm_init_state(pwm, &state); + if (!state.period) { dev_err(&pdev->dev, "invalid PWM period\n"); return -EINVAL; } - /* - * FIXME: pwm_apply_args() should be removed when switching to - * the atomic PWM API. - */ - pwm_apply_args(pwm); - ret = pwm_config(pwm, pargs.period, pargs.period); + state.duty_cycle = state.period; + state.enabled = true; + + ret = pwm_apply_state(pwm, &state); if (ret < 0) return ret; /* * we can now start the FPGA and populate the peripherals. */ - pwm_enable(pwm); ts_nbus->pwm = pwm; /*