From patchwork Thu Jun 22 09:21:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 111593 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp4945973vqr; Thu, 22 Jun 2023 02:55:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6akrlPD8U9YqnBnWO+XkZefy4f6n3+peCXnW8vt8ip8KqjlwWh5L6dw0b7O+nykw1KojgX X-Received: by 2002:a05:6870:9712:b0:1a6:6b2e:ecf with SMTP id n18-20020a056870971200b001a66b2e0ecfmr21435764oaq.57.1687427738382; Thu, 22 Jun 2023 02:55:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687427738; cv=none; d=google.com; s=arc-20160816; b=aWFDH0rlzkYw7CSQdB/oArzdUVCX5K3CfDsRBCjV3IZXJVyWFI+UhCzMcqBBw1LNmR E+Li0Xy/HZg4HS9mugC2I3XHgyh1sXD0rE30CJ0HFsxa3l7W24I54FFKvWsl5Buo3gx8 xlvvoOr70h1dTnbRqDgC6P35kDFgr4pW7RZy0tHlMlPX6T6ybYJnJp1Hvecsgxaqa7v9 01CnH9lqIsYMdh3ZomKTgu+kz+ZMUuPhsLBWLSYKmI3sRljw89B8+6KneV9bt2PXGSUo l8Nvs3gS7pgGpoJsyzWDZAk0oXpOyKZXetGEd++iyK4aXZKyT1Ld5f2g92+Mr+qe0Ow0 Sucg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=dP3ZLabY1YbGFbBmRKYn/PjUo5XR0LWeGC4Ys50mT+Q=; b=XSvjLaY213Z4ZqVGU1F37Kr5259K4XLTt834NlBNr7VFLLuav01Qo0o5ZE/pX5Qy8O Q68IEddkxSUu++PcdW9EzGZYDTv/NzU3uqZQJNdw6ETg97GOdOY5yfW5gcWqkv01ck+L T1Z4Gz2Ly8ukec2z6VYPOIpYWhvWLATxtVBglY1Db7hjsanoEG2vgELQCSdNjo6/BPdP bnT+MibCw4ay6DFo+Ur5dwcFXKsSk+1mIRJQHKq35+QDg8lyq8gNiMbXPY1i3PmDW9yT g1/K0XG47No4h7vC6vXkpiignAmuXJAzc4xqCReZSH5SW5GWcS3LA+RDE9UXYgGH720Z +VpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l71-20020a633e4a000000b0055384baa018si6114290pga.693.2023.06.22.02.55.14; Thu, 22 Jun 2023 02:55:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231463AbjFVJaY (ORCPT + 99 others); Thu, 22 Jun 2023 05:30:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230354AbjFVJ3l (ORCPT ); Thu, 22 Jun 2023 05:29:41 -0400 Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CD75421C for ; Thu, 22 Jun 2023 02:22:45 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed20:991a:a831:ea4b:6058]) by andre.telenet-ops.be with bizsmtp id C9Nj2A00a1yfRTD019NjNp; Thu, 22 Jun 2023 11:22:43 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qCGWX-000BwF-Nh; Thu, 22 Jun 2023 11:22:43 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qCGWZ-003Vwo-Ak; Thu, 22 Jun 2023 11:22:43 +0200 From: Geert Uytterhoeven To: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm Cc: dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 16/39] drm: renesas: shmobile: Convert to use devm_request_irq() Date: Thu, 22 Jun 2023 11:21:28 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769396228453015196?= X-GMAIL-MSGID: =?utf-8?q?1769396228453015196?= Convert to managed IRQ handling, to simplify cleanup. Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c index 50fca18282c5cb5e..ece9aedde9b662d4 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c @@ -169,7 +169,6 @@ static int shmob_drm_remove(struct platform_device *pdev) drm_dev_unregister(ddev); drm_kms_helper_poll_fini(ddev); - free_irq(sdev->irq, ddev); drm_dev_put(ddev); return 0; @@ -252,8 +251,8 @@ static int shmob_drm_probe(struct platform_device *pdev) goto err_modeset_cleanup; sdev->irq = ret; - ret = request_irq(sdev->irq, shmob_drm_irq, 0, ddev->driver->name, - ddev); + ret = devm_request_irq(&pdev->dev, sdev->irq, shmob_drm_irq, 0, + ddev->driver->name, ddev); if (ret < 0) { dev_err(&pdev->dev, "failed to install IRQ handler\n"); goto err_modeset_cleanup; @@ -265,14 +264,12 @@ static int shmob_drm_probe(struct platform_device *pdev) */ ret = drm_dev_register(ddev, 0); if (ret < 0) - goto err_irq_uninstall; + goto err_modeset_cleanup; drm_fbdev_generic_setup(ddev, 16); return 0; -err_irq_uninstall: - free_irq(sdev->irq, ddev); err_modeset_cleanup: drm_kms_helper_poll_fini(ddev); err_free_drm_dev: