From patchwork Fri Oct 20 06:19:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varadarajan Narayanan X-Patchwork-Id: 155823 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2010:b0:403:3b70:6f57 with SMTP id fe16csp857834vqb; Thu, 19 Oct 2023 23:21:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFokMe0hkRZ0jBgV0Gc3RdsWVxAaLi3DY1UxMf3Vivm8AK9ETaEFurdkNXkkNkJoSiPz9Na X-Received: by 2002:a05:6a21:71ca:b0:17b:7dda:c106 with SMTP id ay10-20020a056a2171ca00b0017b7ddac106mr965908pzc.34.1697782867397; Thu, 19 Oct 2023 23:21:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697782867; cv=none; d=google.com; s=arc-20160816; b=Uu6IBmEMbhkWZNOnhb1dVH/KcIweFN4E3qf7PsfE4OIemv6HoclKOewYQXO+UC0A3Z gC++8d6TJyYK5QIMc30HLi0LInxwqiTwGVnnk7+cCDlfa2MburThJV8JjUOCaxcMVHf0 1FWoQVtUBuV7mQfL4nIp5oe2zuqx65UZ7Xiljbd5+aRh2/Cr4G/j1csml6Ag9FK6wzIv d/qo8FoLCCw+R8XQWM8x4Vn3IBpbSIRC/fPxMEWJEgNFb+CO/kR1WKZBAQbjVYoD5WFe R6T0BZ7hHSRnzEFAh8KNByLvbJPWZZgZqm14/p2N+aBknmmeHusaNaX3rYxV8mewnQca KMHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=fY1x2rWSs0LVIksaZFZnRqeMc75hS/I+54pfaY4c2oc=; fh=/PcbLsdifyktaw5PNVUHNeBf/uyMY7MMN8WFopaJ5z8=; b=JrYwWwoQMvBAOIhYHMIM+xR1r254hnrsHEfkknjd0xLfv5W7FOTqlFm86cLTdrHOMN D9xdzsyD6PMgpsP9xMOuZfRulOC87e3RqhnmxmrvKG10cYpfZopTPFJgna7gaSy2+6IF x+knSkbeHaTdvehHWm8+I90yWOR5X9T44Q8fFwomrelnVEQ4eiowqs7x+pR9MiO3XVRA PN1WELA856ohPv98uU+a9QSofNXxp45BkkilzwG9Ub1snWBoAF1RLL3mOfxv+wd5N1Zd pdgW5lTusTxFqKIU/ivFfbjpE5ZVOc5HCJLC5/nedTPkt2xovZV2jtaEy6NaaaB5UO8f AuFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Oyj8N4bD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id v11-20020a170902d68b00b001b801044467si1070407ply.3.2023.10.19.23.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 23:21:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Oyj8N4bD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id BB0F082909A4; Thu, 19 Oct 2023 23:21:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345092AbjJTGUs (ORCPT + 25 others); Fri, 20 Oct 2023 02:20:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376338AbjJTGUo (ORCPT ); Fri, 20 Oct 2023 02:20:44 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63768D68; Thu, 19 Oct 2023 23:20:41 -0700 (PDT) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39K4itLg008969; Fri, 20 Oct 2023 06:20:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=fY1x2rWSs0LVIksaZFZnRqeMc75hS/I+54pfaY4c2oc=; b=Oyj8N4bDLt72fZT/2+1vXwdJya6hxz3n81s7ro/OeEznJph0TEZStp5rfl0rl08onikW tr9mY1o4+vJPmsuRWkTR0Ro3sIlM1laYxnTMPr0R6s99YxPz9On13D3e4UbEvBrmG6pz izJzLTi4VANxZrUTRvPSFuZ3rQVuXzRkdHQKEJmlaJlbY3TLRynT5X15UmUk/4clyJl0 KgxfJdt2Kq3Y2kAyX5ktpn1fKj0VE3daYufS64sJjYOKCEPCfO1icdMN9XhBBUdK2vT8 PnJUuR8y+MT2r8wK3Apl04ePxTgp0mjm5wBYiuyV+DiYs7QQ+CLX4Z9AOHM0TE89sBbM Hw== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tubwr0wh1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Oct 2023 06:20:12 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 39K6KBSY007206 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Oct 2023 06:20:11 GMT Received: from varda-linux.qualcomm.com (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Thu, 19 Oct 2023 23:20:05 -0700 From: Varadarajan Narayanan To: , , , , , , , , , , , , , , , , , CC: Varadarajan Narayanan Subject: [PATCH v5 3/9] clk: qcom: apss-ipq-pll: Use stromer plus ops for stromer plus pll Date: Fri, 20 Oct 2023 11:49:33 +0530 Message-ID: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: os0gtEWOufSO3gjDSnvVR02dnnys8eHe X-Proofpoint-ORIG-GUID: os0gtEWOufSO3gjDSnvVR02dnnys8eHe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-20_04,2023-10-19_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 bulkscore=0 mlxlogscore=784 impostorscore=0 adultscore=0 mlxscore=0 clxscore=1015 phishscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310170001 definitions=main-2310200053 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 19 Oct 2023 23:21:04 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780254367932848643 X-GMAIL-MSGID: 1780254367932848643 The set rate and determine rate operations are different between Stromer and Stromer Plus PLLs. Since the programming sequence is different, the PLLs dont get configured properly and random, inexplicable crash/freeze is seen. Hence, use stromer plus ops for ipq_pll_stromer_plus. Reviewed-by: Dmitry Baryshkov Acked-by: Stephen Boyd Fixes: c7ef7fbb1ccf ("clk: qcom: apss-ipq-pll: add support for IPQ5332") Signed-off-by: Kathiravan T Signed-off-by: Varadarajan Narayanan Reviewed-by: Konrad Dybcio --- v4: Update commit log to include "What goes wrong if we don't have this patch?" v2: Add Fixes tag --- drivers/clk/qcom/apss-ipq-pll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c index e170331..18c4ffe 100644 --- a/drivers/clk/qcom/apss-ipq-pll.c +++ b/drivers/clk/qcom/apss-ipq-pll.c @@ -68,7 +68,7 @@ static struct clk_alpha_pll ipq_pll_stromer_plus = { .fw_name = "xo", }, .num_parents = 1, - .ops = &clk_alpha_pll_stromer_ops, + .ops = &clk_alpha_pll_stromer_plus_ops, }, }, };