From patchwork Fri Dec 15 13:59:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 179309 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9296065dys; Fri, 15 Dec 2023 06:03:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IHY97K5ntpZcvnl1wQVF6WX7QLHYBxohw5CnXa0A2u3EYZ7gbHPHc9+q2QTXGYBQoBFyK8d X-Received: by 2002:a17:906:1cc2:b0:a1f:69b1:a493 with SMTP id i2-20020a1709061cc200b00a1f69b1a493mr3927720ejh.187.1702648987206; Fri, 15 Dec 2023 06:03:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702648987; cv=none; d=google.com; s=arc-20160816; b=pCwkIxKBLghxeJezlGsPaiE//Erx1tBfG5Uq6XgJqeMZGenL/0vFJfXOMHsQ8hI276 nk6eFwUUQGxw5afTuospL6ZUzBgZI4U0tJvR1hPMGdNNJNXs/YO19uUC9Df7b6S4Z6Ao u/NpPB+3RvhTT6vf4bUYmancya8j0/6N32zx1bk4Z63Wqq1xl8mExSs1MG5tCaki8fEu BJ9jl6eH7GnfSCHvk/BxDSR01JN6Ie15O7y7SlnG2hLetjfDuRx/AO9H3mMuKpPjuG5a VMbhSBWyV8y4HSR8Jii86XqBMeoHeC23LLCFvAffQn0T1osCLzMhJpNqNJNkSFMzvzTE qIzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=SUNKKr6dYHtEu5fOvj7kPx70fx8URsyfh1UDB9nm884=; fh=VnqN9gvG7f7PFjybLJK5tohSJBOOYXZP9MP5VkWGa00=; b=KP20gPlRFLzvPXh30bWHJbc+KPfVNgxHvqWB2dKGT/zbgxcRnD8TRS7IzHhCkXQ5d5 T/PYIgaXAchid11qvNUmHRWI/ZnuF0hOdN/xmaRlgEDHSU8tBjHdzco0dPQsstZ/Bbmo Zq2HaPtn9EkKt5NstEc+wNPKIUoc4GxeYaLu8JMtOu44HAEqsblGv7PqeNnG+3aKI/QC YJkWVVcNqm6GTdi4peAuGwtyD6v5j3YsWMeJhwRKHneJbhFuNNFTQpk3ZXodiZzsog6h 5+pOctMqjR/Gk76oF9NO2LYtqlYxdteG/UfFGxCNmMaUyxX5BvbVPMaujfeZqa76kIsQ aV3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-1063-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1063-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id u10-20020a1709060b0a00b00a2320450925si57769ejg.336.2023.12.15.06.03.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 06:03:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1063-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-1063-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1063-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 65D4C1F24672 for ; Fri, 15 Dec 2023 14:02:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 255B936AF3; Fri, 15 Dec 2023 13:59:42 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EC4C31A73 for ; Fri, 15 Dec 2023 13:59:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rE8ix-0002mX-Ni; Fri, 15 Dec 2023 14:59:31 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rE8ix-00G2Zt-9c; Fri, 15 Dec 2023 14:59:31 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rE8iw-003cCg-Vu; Fri, 15 Dec 2023 14:59:31 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Will Deacon , Mark Rutland Cc: Frank Li , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/18] perf: fsl_imx8_ddr: Convert to platform remove callback returning void Date: Fri, 15 Dec 2023 14:59:11 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1845; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=T+20pqO282TURQ3KdX9THzy7jvQJXD3iKvoD14JC1QE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfFuxbrW2Q2PBwqQM4KAykWSBx75C886HAfiiG N9zzX46qnyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXxbsQAKCRCPgPtYfRL+ TqngCACUznhYhR8/BzUWG4hp303BWa3SfxSmsN5tbFkOpRb0acP7jKPKS4I7sOqxOeGneQWBCRy 5ZzIULjqO0zTyhnEn9S84dJL619cRTzQGlhi8D0nR33rRCL77eHWD7VIAgwubHYwpVpPX7lXOMS yAwjU2ryhwe7oezSSMrwBK1gv7W/2/wP6UlECKixF4SGK8Nl5xQlEYstnUkbV1pWQt7nit0bsGx dUBQJPvnCQIzi+U2WD5o1vix9RJSi8JTRUMZweWk9h5cMqdkla+cdKjN1rTw12munZhHlOZHVqb eZbhrpDVcuiFaV3nn2FLb6y/8q9hNNfQloQaA7pNifjITj90 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785356864730597823 X-GMAIL-MSGID: 1785356864730597823 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/perf/fsl_imx8_ddr_perf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c index 7dbfaee372c7..4e8fa5a48fcf 100644 --- a/drivers/perf/fsl_imx8_ddr_perf.c +++ b/drivers/perf/fsl_imx8_ddr_perf.c @@ -826,7 +826,7 @@ static int ddr_perf_probe(struct platform_device *pdev) return ret; } -static int ddr_perf_remove(struct platform_device *pdev) +static void ddr_perf_remove(struct platform_device *pdev) { struct ddr_pmu *pmu = platform_get_drvdata(pdev); @@ -836,7 +836,6 @@ static int ddr_perf_remove(struct platform_device *pdev) perf_pmu_unregister(&pmu->pmu); ida_free(&ddr_ida, pmu->id); - return 0; } static struct platform_driver imx_ddr_pmu_driver = { @@ -846,7 +845,7 @@ static struct platform_driver imx_ddr_pmu_driver = { .suppress_bind_attrs = true, }, .probe = ddr_perf_probe, - .remove = ddr_perf_remove, + .remove_new = ddr_perf_remove, }; module_platform_driver(imx_ddr_pmu_driver);