From patchwork Tue Feb 28 18:28:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan McDowell X-Patchwork-Id: 62571 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3184255wrd; Tue, 28 Feb 2023 10:37:16 -0800 (PST) X-Google-Smtp-Source: AK7set8pe0P//FxtOWYWvpvUnS5J62zWznlMIl85r5NFgXd9OIBO8MxQTEM303C8Z9esDva/11E0 X-Received: by 2002:a17:907:7f21:b0:8f2:5c64:d53b with SMTP id qf33-20020a1709077f2100b008f25c64d53bmr15607102ejc.24.1677609436339; Tue, 28 Feb 2023 10:37:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677609436; cv=none; d=google.com; s=arc-20160816; b=IGasTYguXT85BIbVoZ+p5Wb8f0HWQoMu8uvSaxvsyNYr1HlBvrq9Ew0d+UJfdcH+XW Yzx26PH7OjC/eXpiurHJwr0y3oezSPNDr6hQ5PSZJmyODK2uMPgBV9OENvfYJrwsTfW9 z+FDzhYNAUE1zbrXM6TUEfkAxm61cV8BHw0oAGFdoMyfv1peueq2giuVn/yce73nWIKD ArvC2VdnmS0I3EuNb7gF9rKVwkFLSOx0L/8yXO3orhApPWpyOi/4gNOhv4Wm24zr9cth G5uBFo+m7+z3aYecs3lTToiyInuxDBp8Tq2PFkaO40iMR8f+VU4aq6p8jR6qNMrod763 vYJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5XDgmrCVldCZcKRfq8ly88XN9tFbmvTHx2oZvsD+P54=; b=hBZapDucOYlz6ATgWo/+uKZiZKhg/e9m0R5JPyjroMrlJQwaGfTfqxOrtQGD/pDJWV ajnhZLE/R+sArCEpIXc9LkPs0dhz1GAM45xrxiWASuxqyHx4SaLnBYfDVem5eOgoLodG nialS51kM8WaMZ+AmBlrbMzcHvZrhCOQBQ+ZDPs/hchm6X/aYJXoziy/j7Bw0jSDKf2a wIiaUHaYR/XTL169Zwy5etDlc63GxEem6QopaHbDftBD9rXgcXlyvCYf97g7Y0L0VPNw XzG77SnDX6cNGx8XgxDN5zak/MOY/jF3uNZD30dFjmXEb7ExkL3TKsGcCpTR/F4hoUZ3 bc4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@earth.li header.s=the header.b="rjt+/6zT"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t17-20020aa7d711000000b004ad05f8a5cbsi633241edq.266.2023.02.28.10.36.54; Tue, 28 Feb 2023 10:37:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@earth.li header.s=the header.b="rjt+/6zT"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229754AbjB1S2x (ORCPT + 99 others); Tue, 28 Feb 2023 13:28:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229561AbjB1S2v (ORCPT ); Tue, 28 Feb 2023 13:28:51 -0500 Received: from the.earth.li (the.earth.li [IPv6:2a00:1098:86:4d:c0ff:ee:15:900d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64B603345C; Tue, 28 Feb 2023 10:28:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=earth.li; s=the; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5XDgmrCVldCZcKRfq8ly88XN9tFbmvTHx2oZvsD+P54=; b=rjt+/6zTNh9QtloPA0iKD7d45W vVp82Gm11hA67RpvQE2UVkGRTXDwoAHA6cbrgifvD91xlU2MhTI4yBv5amxhmtFNyyjMwd/QHOuRj rkTNF/pQMdrp9FOnQTsmTPOu2i0LvKif/eIcnESFvKwf9uTjFrDhuWw+1/BnM5CV6+5D55EJnCX09 NkmtwJESPbnQtfGZWgxdLf0jh0jHmRA5L9ODYsOCYaiKXKF3aG7DpSz605b/yAjmQpk03N+9TIk16 0EIdmcZqoJvBfCJv1ZlJ2fyi/pNzo6/4xP0Q276ssYRA8xIMJscdyd4erTytcSs+UKzV0hrVOVJ+C MXg37iGA==; Received: from [2001:4d48:ad59:1403::17ca] (helo=earth.li) by the.earth.li with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pX4iS-008oS5-9l; Tue, 28 Feb 2023 18:28:44 +0000 Date: Tue, 28 Feb 2023 18:28:40 +0000 From: Jonathan McDowell To: Antoine Tenart , Herbert Xu , "David S. Miller" Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] crypto: inside-secure: Raise firmware load failure message to error Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759100992193341323?= X-GMAIL-MSGID: =?utf-8?q?1759100992193341323?= At the moment if there is no firmware available for the safexcel driver it will fail to load with a cryptic: crypto-safexcel f2800000.crypto: TRC init: 15360d,80a (48r,256h) crypto-safexcel f2800000.crypto: HW init failed (-2) Raise the logging level of the firmware load failure to err rather than dbg so that it's obvious what the reason for the HW init failure is. Signed-off-by: Jonathan McDowell Reviewed-by: Antoine Tenart --- drivers/crypto/inside-secure/safexcel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c index 6858753af6b3..5e10ab24be3b 100644 --- a/drivers/crypto/inside-secure/safexcel.c +++ b/drivers/crypto/inside-secure/safexcel.c @@ -474,7 +474,7 @@ static int eip197_load_firmwares(struct safexcel_crypto_priv *priv) goto retry_fw; } - dev_dbg(priv->dev, "Firmware load failed.\n"); + dev_err(priv->dev, "Firmware load failed.\n"); return ret; }