From patchwork Mon Apr 24 13:45:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baolin Wang X-Patchwork-Id: 87060 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2774088vqo; Mon, 24 Apr 2023 07:11:01 -0700 (PDT) X-Google-Smtp-Source: AKy350YDQpcO2DhRzbUSxAmD5ppx8Ll9/F5KjLyzxiasR2h2+I4e//LEMpxTx8TZbHVHqiU69Jey X-Received: by 2002:a17:903:230d:b0:1a8:5083:21ed with SMTP id d13-20020a170903230d00b001a8508321edmr17548193plh.51.1682345460733; Mon, 24 Apr 2023 07:11:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682345460; cv=none; d=google.com; s=arc-20160816; b=wH5yCCA3MuCoXksrZ3kPYjEo295iC+1EQd/vLmIB9FW1pvIW6H6XUENuOJeiQkVCad bTJ/w2EkUPpThy/M7KxTy/qUEZwtR7Wfk6Faqq/4DxeJU/hLwJ/IfoOfdBS9taNPsW85 EtOJFWh+a5pR2Zr8fL+83+rLtMvOs3RnhfM1vel57INKB8b7qGfT58xHRw4U6HGw1XBc NftFt9SmfIbOmDbziYvMusBdvbfsB2pfYYJOqSz6Qq33cg6GntUUY/mFm4sOJtH1C/D/ xRo51B3cZfpyrG2kke8HKW9wW3OibcKFugpsN0Q0wwDYCd9Qu2lxJjSehHo8PAI/eYD9 7Usg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=of4y4r11HnMBjpqe6J5ROFKicQ684iyvaOjw+qGJf5k=; b=A6CTm01S+j+n7LGCivgEkzGniL79zGJKuHS6wJc4uf04SMfIDLSiDboXdxHyYTdzww QsvPlkm6bwrQ6edDL4fxMQh3+d6nD2PN+ryfDSq6SSmdsept1WW9M82aNtkXichLCpD5 rHLLAUVMYncW54WtoK4wcJfRFpJmqbXJP/KyE5Uqj6SGBJv3uoUJWeIVQv5vBjP1L3U/ 9r6dNbcsWg9HwMHCX/K0Dyc7VhE6Mvgd3dX3L88xGi5RY5EY7HchaedPpyMRNDVKynR0 XG99poTKrEU+xzDn/yfdSWXWdNVdjLxmkdZwWP1BD2DzSG5Q2qV8waMBqd7dBG4QHRJr IAEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d4-20020a170902654400b001a5089fe47fsi10603891pln.326.2023.04.24.07.10.47; Mon, 24 Apr 2023 07:11:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231824AbjDXNqJ (ORCPT + 99 others); Mon, 24 Apr 2023 09:46:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231766AbjDXNqH (ORCPT ); Mon, 24 Apr 2023 09:46:07 -0400 Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B32367A8A for ; Mon, 24 Apr 2023 06:45:55 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0Vgw4CI-_1682343948; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Vgw4CI-_1682343948) by smtp.aliyun-inc.com; Mon, 24 Apr 2023 21:45:49 +0800 From: Baolin Wang To: akpm@linux-foundation.org Cc: rppt@kernel.org, ying.huang@intel.com, mgorman@techsingularity.net, vbabka@suse.cz, mhocko@suse.com, david@redhat.com, baolin.wang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/2] mm/page_alloc: drop the unnecessary pfn_valid() for start pfn Date: Mon, 24 Apr 2023 21:45:39 +0800 Message-Id: X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763964727027523520?= X-GMAIL-MSGID: =?utf-8?q?1764067073349144369?= __pageblock_pfn_to_page() currently performs both pfn_valid check and pfn_to_online_page(). The former one is redundant because the latter is a stronger check. Drop pfn_valid(). Signed-off-by: Baolin Wang Reviewed-by: David Hildenbrand Reviewed-by: "Huang, Ying" Acked-by: Michal Hocko --- Changes from v2: - Update the commit message per Michal. Thanks. - Add acked tag from Michal. Changes from v1: - Collect reviewed tags. Thanks David and Ying. --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 9de2a18519a1..6457b64fe562 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1512,7 +1512,7 @@ struct page *__pageblock_pfn_to_page(unsigned long start_pfn, /* end_pfn is one past the range we are checking */ end_pfn--; - if (!pfn_valid(start_pfn) || !pfn_valid(end_pfn)) + if (!pfn_valid(end_pfn)) return NULL; start_page = pfn_to_online_page(start_pfn);