From patchwork Fri Mar 10 17:54:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alison Schofield X-Patchwork-Id: 67622 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1014920wrd; Fri, 10 Mar 2023 09:56:46 -0800 (PST) X-Google-Smtp-Source: AK7set8hWwUR4MbuR1x4DLRo9WJ592Xa+sMQmOmLaJXEzETFiRonNrIVPc0pACaOog3iBaT//B3u X-Received: by 2002:a05:6a20:1610:b0:be:ed2a:b2dd with SMTP id l16-20020a056a20161000b000beed2ab2ddmr2546737pzj.6.1678471006091; Fri, 10 Mar 2023 09:56:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678471006; cv=none; d=google.com; s=arc-20160816; b=pzx+dkGf+x2Q8F4KjF6X7meOdp/RiRd5Cky9EeLk3GdhbAmTu67lx3bGg0uvbjrntH hTqdHyzboshgoUYLLQq/BIiMPTbMOabFW75yDMpt2IXuAqch+ddDPG+hIAJp2auaE0kH EM+dzmXhCCtmpRyK4D+aiTzbg++MSTO7AogKVcIsvQSNrp+eeXolbtXNRnWa6foORdr4 ExEW8y6HrLjRr9QfqcgLIxY4TLqvp2Lk21UijCCDBsmp89q9RTa261GMVQ5a4B4sdpjj bxCvYZf7KqWxSzS5JG9L9CZN4BNPH5hyjrjsSzDktzYAHmg29X3JmJNJwf6QEJXINhao 6O6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BTAkyV3RD0rmFZFSe+euUXdFAJhli5k3fbXzRNJZZUY=; b=nux0HEHrUvAuxPhxG7DM26Oj44f2DKK1bcTmnZVeL69sxHpJqXqzYLaZ+4cQmbZ1K+ dhF7FWMwguLGMnjXucaKYqC/6/nuHnRSfh+zM6AKCdMp+H6pIhm0A6weTaHc2GzfqAdc 3t/8D/woyDPMKG+3xh0e2hrpmEuPIY19HXeYqKB02JyT5sPgSzkDVb/VlqnN4bRDV2w1 rtj7BjDWPMlvAuUb/yMR53z3pDz89fVw0H28Pm5PYS9H0XyQNsw6v00whatr5/dCdxWu ew9/wFwP5QpJqDvkG/yOfzPPq/KJZMKqC3Q9x8mS5CfE7vm8WWgdU+Rym1wxpw24X0Zf sTTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ZKnLZIeY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j7-20020a63fc07000000b004fb12ee7cb9si331403pgi.354.2023.03.10.09.56.32; Fri, 10 Mar 2023 09:56:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ZKnLZIeY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231720AbjCJRzO (ORCPT + 99 others); Fri, 10 Mar 2023 12:55:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231672AbjCJRyk (ORCPT ); Fri, 10 Mar 2023 12:54:40 -0500 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F2EA133A5D; Fri, 10 Mar 2023 09:54:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678470870; x=1710006870; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=hD2rrzfHMjsATs4mojwT9YO3fE187EZT2AZxIFCr5Do=; b=ZKnLZIeYJ+ykk4e1Vi6a9f6FY0d1Vbm3t2yUk0wTCzt2/2+Yb0UBCxXr xLHTQcVF2PkcECI9ojDaWsjGMpBVGBFDOw/cI2pbKovn4pjrqIK0XW/6x AXKU4lz1MbkNLJfv6hFerbHad7xU0W0cwFr7m5gieuH8FuUeWRNchnkRo o0OimyTuFkyOt08204nuBcq3zWcdJRSFnSFj6G7a2ppsoDcwbr69fDKp3 g4wU6uhQvAXOfwdlYRLTVlOaLeIOsvEMwEhhQEe+EwgaP8cLQxAfUrdKI sijTCOU5jPNVr7VCDhz1wm2YRUO9n5UbrzosgggWc09pktakhFx0NJdum w==; X-IronPort-AV: E=McAfee;i="6500,9779,10645"; a="339154059" X-IronPort-AV: E=Sophos;i="5.98,250,1673942400"; d="scan'208";a="339154059" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2023 09:54:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10645"; a="680276573" X-IronPort-AV: E=Sophos;i="5.98,250,1673942400"; d="scan'208";a="680276573" Received: from aschofie-mobl2.amr.corp.intel.com (HELO localhost) ([10.255.228.62]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2023 09:54:27 -0800 From: alison.schofield@intel.com To: Dan Williams , Ira Weiny , Vishal Verma , Dave Jiang , Ben Widawsky , Steven Rostedt Cc: Alison Schofield , linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron Subject: [PATCH v8 3/6] cxl/memdev: Add trigger_poison_list sysfs attribute Date: Fri, 10 Mar 2023 09:54:17 -0800 Message-Id: X-Mailer: git-send-email 2.37.3 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760004413635207127?= X-GMAIL-MSGID: =?utf-8?q?1760004413635207127?= From: Alison Schofield When a boolean 'true' is written to this attribute the memdev driver retrieves the poison list from the device. The list consists of addresses that are poisoned, or would result in poison if accessed, and the source of the poison. This attribute is only visible for devices supporting the capability. The retrieved errors are logged as kernel trace events with the label 'cxl_poison'. Signed-off-by: Alison Schofield Reviewed-by: Jonathan Cameron Reviewed-by: Ira Weiny --- Documentation/ABI/testing/sysfs-bus-cxl | 14 +++++++ drivers/cxl/core/memdev.c | 56 +++++++++++++++++++++++++ drivers/cxl/cxlmem.h | 2 +- 3 files changed, 71 insertions(+), 1 deletion(-) diff --git a/Documentation/ABI/testing/sysfs-bus-cxl b/Documentation/ABI/testing/sysfs-bus-cxl index 3acf2f17a73f..02776fee6d4c 100644 --- a/Documentation/ABI/testing/sysfs-bus-cxl +++ b/Documentation/ABI/testing/sysfs-bus-cxl @@ -415,3 +415,17 @@ Description: 1), and checks that the hardware accepts the commit request. Reading this value indicates whether the region is committed or not. + + +What: /sys/bus/cxl/devices/memX/trigger_poison_list +Date: March, 2023 +KernelVersion: v6.4 +Contact: linux-cxl@vger.kernel.org +Description: + (WO) When a boolean 'true' is written to this attribute the + memdev driver retrieves the poison list from the device. The + list consists of addresses that are poisoned, or would result + in poison if accessed, and the source of the poison. This + attribute is only visible for devices supporting the + capability. The retrieved errors are logged as kernel + trace events with the label 'cxl_poison'. diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c index 0af8856936dc..ea996057815e 100644 --- a/drivers/cxl/core/memdev.c +++ b/drivers/cxl/core/memdev.c @@ -106,12 +106,60 @@ static ssize_t numa_node_show(struct device *dev, struct device_attribute *attr, } static DEVICE_ATTR_RO(numa_node); +static int cxl_get_poison_by_memdev(struct cxl_memdev *cxlmd) +{ + struct cxl_dev_state *cxlds = cxlmd->cxlds; + u64 offset, length; + int rc = 0; + + /* CXL 3.0 Spec 8.2.9.8.4.1 Separate pmem and ram poison requests */ + if (resource_size(&cxlds->pmem_res)) { + offset = cxlds->pmem_res.start; + length = resource_size(&cxlds->pmem_res); + rc = cxl_mem_get_poison(cxlmd, offset, length, NULL); + if (rc) + return rc; + } + if (resource_size(&cxlds->ram_res)) { + offset = cxlds->ram_res.start; + length = resource_size(&cxlds->ram_res); + rc = cxl_mem_get_poison(cxlmd, offset, length, NULL); + /* + * Invalid Physical Address is not an error for + * volatile addresses. Device support is optional. + */ + if (rc == -EFAULT) + rc = 0; + } + return rc; +} + +static ssize_t trigger_poison_list_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t len) +{ + struct cxl_memdev *cxlmd = to_cxl_memdev(dev); + bool trigger; + int rc; + + if (kstrtobool(buf, &trigger) || !trigger) + return -EINVAL; + + down_read(&cxl_dpa_rwsem); + rc = cxl_get_poison_by_memdev(cxlmd); + up_read(&cxl_dpa_rwsem); + + return rc ? rc : len; +} +static DEVICE_ATTR_WO(trigger_poison_list); + static struct attribute *cxl_memdev_attributes[] = { &dev_attr_serial.attr, &dev_attr_firmware_version.attr, &dev_attr_payload_max.attr, &dev_attr_label_storage_size.attr, &dev_attr_numa_node.attr, + &dev_attr_trigger_poison_list.attr, NULL, }; @@ -130,6 +178,14 @@ static umode_t cxl_memdev_visible(struct kobject *kobj, struct attribute *a, { if (!IS_ENABLED(CONFIG_NUMA) && a == &dev_attr_numa_node.attr) return 0; + + if (a == &dev_attr_trigger_poison_list.attr) { + struct device *dev = kobj_to_dev(kobj); + + if (!test_bit(CXL_MEM_COMMAND_ID_GET_POISON, + to_cxl_memdev(dev)->cxlds->enabled_cmds)) + return 0; + } return a->mode; } diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h index 57a5999ddb35..a6eb1b42eb88 100644 --- a/drivers/cxl/cxlmem.h +++ b/drivers/cxl/cxlmem.h @@ -145,7 +145,7 @@ struct cxl_mbox_cmd { C(FWROLLBACK, -ENXIO, "rolled back to the previous active FW"), \ C(FWRESET, -ENXIO, "FW failed to activate, needs cold reset"), \ C(HANDLE, -ENXIO, "one or more Event Record Handles were invalid"), \ - C(PADDR, -ENXIO, "physical address specified is invalid"), \ + C(PADDR, -EFAULT, "physical address specified is invalid"), \ C(POISONLMT, -ENXIO, "poison injection limit has been reached"), \ C(MEDIAFAILURE, -ENXIO, "permanent issue with the media"), \ C(ABORT, -ENXIO, "background cmd was aborted by device"), \