From patchwork Thu Aug 10 17:59:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Guido_G=C3=BCnther?= X-Patchwork-Id: 134141 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp610303vqi; Thu, 10 Aug 2023 11:37:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEUsedWcUW12FGvY6KC59xRbdb3Gxtz3ulXpvT56AbakF81uLCkdJsvw1cZSeWAKOD25vcv X-Received: by 2002:a05:6a20:7fa8:b0:134:40f0:5d04 with SMTP id d40-20020a056a207fa800b0013440f05d04mr4325875pzj.13.1691692651820; Thu, 10 Aug 2023 11:37:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691692651; cv=none; d=google.com; s=arc-20160816; b=oTsSC4C/DHKfFy4d9JRiwX+EOVTnBl91Yi4XgK0TWyVBfo0RUpe/F0e9T07cCKFxG2 joOj1jTewiBPY6ow7rJoiJJNypZsTi5bwq3tc8HR5m0j2iAGSdUwToJVO2fYKFKqK2KN I+9zBimpeIW8wsLnCJr6y+1+K/xpZopvCB/aXfg1mswXlyuAz5pIcVrgGWdCYYq/H7gF KdQqrFXFEdpAuT9YrlMNEBNKUUJC3BMR15oCM5CUoRpD//sV+mO66GOMguYxucRNwDl2 ACk0bBdIrpjjkIzmC8cdiYmzYJsg6IVAMuRcF4lZhiAsS7u8pF9EFmdvP74B8ywBBvDb qPPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from; bh=4fgZLsSfZBwJduzCzSVH+rwAg4vG6qF44dAkEPbx1Pg=; fh=22IXsjL+5qvSknqAd8AlUrO0wm0WJvaZ1lQXoRTjFSg=; b=Emhmao42tyNq6HI/cTHuU8i77rVw08IRwWO8B1Zo5pL2ebWdOz0R8Vx08tGpSe20pR CWuc+ao3QS3c4vpDzGR9NPuLUDB6FpqTl2lYndRWPBwRyY9DfSfsadgsBHyt8kCkOlTk KG0M6rnGx+GEAS+56ARaeAbFm4AqN8bG7fSanznViw+G9jQXJTtjB1KHd34l1aw9yQUG 0ACLpAdwVwun2wRl/MRQCW4T9/bGW+iOyza/CN30Yqclaa8dX84ct7K5eZk0a/wa8n6h KgBLHeIMb9qCiqrawDOEZCLMirK2n7sCR7PH5JjZcntP/98fmaR16AWSqoABnclwDxl2 1u4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h64-20020a638343000000b005655bf61e1csi1346411pge.230.2023.08.10.11.37.16; Thu, 10 Aug 2023 11:37:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235680AbjHJSAO (ORCPT + 99 others); Thu, 10 Aug 2023 14:00:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235603AbjHJSAH (ORCPT ); Thu, 10 Aug 2023 14:00:07 -0400 Received: from honk.sigxcpu.org (honk.sigxcpu.org [24.134.29.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D748EE7E; Thu, 10 Aug 2023 11:00:06 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id A1FFFFB04; Thu, 10 Aug 2023 20:00:01 +0200 (CEST) Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ga5_QdtRO3Fa; Thu, 10 Aug 2023 19:59:59 +0200 (CEST) From: =?utf-8?q?Guido_G=C3=BCnther?= To: Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Catalin Marinas , Will Deacon , =?utf-8?q?Guido_G=C3=BCnther?= , Peng Fan , Bjorn Andersson , Arnd Bergmann , Geert Uytterhoeven , Konrad Dybcio , =?utf-8?b?TsOtY29sYXMgRi4gUi4g?= =?utf-8?b?QS4gUHJhZG8=?= , =?utf-8?b?UmFmYcWCIE1p?= =?utf-8?b?xYJlY2tp?= , kernel@puri.sm, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, David Heidelberg , Sherry Sun Subject: [PATCH v2 3/4] arm64: dts: imx8mq-librem5-devkit: Drop power-supply Date: Thu, 10 Aug 2023 19:59:51 +0200 Message-Id: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773868313857696855 X-GMAIL-MSGID: 1773868313857696855 It's not a valid binding. Instead move the sdio_rst line to the power sequence and use w_disable1 as the vmmc-supply bringing it more in line with other SDIO M2 cards. Resolves following warning: arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dtb: mmc@30b50000: Unevaluated properties are not allowed ('power-supply' was unexpected) from schema $id: http://devicetree.org/schemas/mmc/fsl-imx-esdhc.yaml# Reported-by: David Heidelberg Signed-off-by: Guido Günther --- .../dts/freescale/imx8mq-librem5-devkit.dts | 25 ++++++++----------- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts index be9ef5c271df..8055a2c23035 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts @@ -139,18 +139,6 @@ reg_pwr_en: regulator-pwr-en { regulator-always-on; }; - reg_usdhc2_vmmc: regulator-usdhc2-vmmc { - compatible = "regulator-fixed"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usdhc2_pwr>; - regulator-name = "VSD_3V3"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; - enable-active-high; - regulator-always-on; - }; - wwan_codec: sound-wwan-codec { compatible = "option,gtm601"; #sound-dai-cells = <0>; @@ -242,6 +230,13 @@ wifi_pwr_en: regulator-wifi-en { enable-active-high; regulator-always-on; }; + + wifi_pwr_seq: pwrseq { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usdhc2_rst>; + compatible = "mmc-pwrseq-simple"; + reset-gpios = <&gpio2 19 GPIO_ACTIVE_LOW>; + }; }; &A53_0 { @@ -808,7 +803,7 @@ MX8MQ_IOMUXC_SD1_RESET_B_USDHC1_RESET_B 0xc1 >; }; - pinctrl_usdhc2_pwr: usdhc2pwrgrp { + pinctrl_usdhc2_rst: usdhc2rstgrp { fsl,pins = < MX8MQ_IOMUXC_SD2_RESET_B_GPIO2_IO19 0x41 >; @@ -1031,8 +1026,8 @@ &usdhc2 { pinctrl-1 = <&pinctrl_usdhc2_100mhz>; pinctrl-2 = <&pinctrl_usdhc2_200mhz>; bus-width = <4>; - vmmc-supply = <®_usdhc2_vmmc>; - power-supply = <&wifi_pwr_en>; + vmmc-supply = <&wifi_pwr_en>; + mmc-pwrseq = <&wifi_pwr_seq>; broken-cd; disable-wp; cap-sdio-irq;