From patchwork Fri Dec 22 22:50:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 182799 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp1371899dyi; Fri, 22 Dec 2023 14:54:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IE5/4ys9V1cjCP1gv8DQYdvjQEpPIcExUGsZBZvNJVxOAP8TMLviyKM0dghGWSg6/q751zw X-Received: by 2002:a05:6214:509e:b0:67a:a72d:fbc3 with SMTP id kk30-20020a056214509e00b0067aa72dfbc3mr4138866qvb.65.1703285669633; Fri, 22 Dec 2023 14:54:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703285669; cv=none; d=google.com; s=arc-20160816; b=TYXW1lSEQaAzKqz/ECwcmxBKLpmK3EeATrFAmSBS5kFFl5If3W7KD0Emmd3VyLjDBz YHIzgNTyI9TcyyZc+os9zNjmPKu6Rj1E49kT61z21fZsZG3LOGUR/G+E8teFKwq1H8Tg 7RLFvg9jskZ6AnfpMU127ljz4nRODpp9RExPkBfETn/prxjKmsCyEsDP+Huid5q0sXLT +bh5LtcuHWQoNlfaqidCbXcKLphWBuQOWFweasMwOUY5k87bbw8SH7TyNxLsPwV3hLeK /d2ZzqaSZtt/wgRtN3L/lWX8GqeRrkUeozU7InGxj0i+N9pQXY06qXjcZyiVW+7+WeJX /ogg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=EoNta1dtKSyZz4ucdS/hyuhoZVoMCIQkrFp6Lysn4pw=; fh=/7k3G5kYgdzNREH7N5X6ApKxsFgwBo/+qx/r7G5UAw8=; b=IIyQslZ0Fxns3OSznMD9Sie5eb2VWTYwWqGkFgM1aLOCUaoypXfTcxMCWvDyYql1Yl YVQoV6IlUQ5jt9mAwH23NgODOoY7Pxpo7EUyuW95bI8OufhMuXQDQa0NktmZVvo+TFOA D043QKC+fk2PSPMa0/XN4zo8kOpD1fcYkjzXYI8zFs1eaSCmsx9VOzdhCvRSQwg3qk7c n1a1pwLhjtLFDqP9/pIghX0g4PZJJmJWJL2Bqx9sKKn4evzCYk8h/Z8CqJafP8FWaXwT YIB/D4YswcmbQJeF54hi+VJQtf1gH9KFOzY8Wxxv01/FrKKHKfMTFItwSmSof+fOxlng FBKQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10104-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10104-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id u21-20020a0cb415000000b0067f235a34bcsi5133867qve.79.2023.12.22.14.54.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 14:54:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-10104-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10104-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10104-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 6C98D1C22D20 for ; Fri, 22 Dec 2023 22:54:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 85CB03BB36; Fri, 22 Dec 2023 22:51:29 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8BCC1EB43 for ; Fri, 22 Dec 2023 22:51:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rGoML-0005Zf-AD; Fri, 22 Dec 2023 23:51:13 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rGoMJ-000qv1-PE; Fri, 22 Dec 2023 23:51:12 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rGoMK-000FfC-2Y; Fri, 22 Dec 2023 23:51:12 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thomas Gleixner Cc: Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 03/13] irqchip/imx-irqsteer: Convert to platform remove callback returning void Date: Fri, 22 Dec 2023 23:50:34 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1880; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=xfWwPsMpemUSHTIcU/EikGDBKd36foZe+1G4fTs3hqo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlhhK6Fur6CUd1UOKaLZ5K33vkMMIOKWjwsqHiH 25whVgrJMeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYYSugAKCRCPgPtYfRL+ TmM1B/0dtKRdQR04yQXFSmzwaKbsX5SOncdt4JztEDpjk9maci6FPNbO2abC9u92f4VLYrEnQbO WyEdYipdt3kPefqWG8bmhncSmyWaAK5Q95KMUDzm+zD66K5GQM9YjaZrGXyALfPMUAK2mHx5563 4aZblITVqigT8nGGU2xr0oI4OGTlBTBCJrYF65ypXXvXJbubUiMrnk/Pdfw2iHWkuLKvNH5Xcue SlDTOQuUDCUMGtkmkC7aS/xJfTHZGAP2gQwrLKx5ewD5ahv+L391QchrYo3AYQsLCRPeuWuj5qP 3eUQObHtwIkaRfDnEh9PCXgEqAXakiYb81I+xLYTBkygm3v1 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786024474557297493 X-GMAIL-MSGID: 1786024474557297493 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/irqchip/irq-imx-irqsteer.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c index bd9543314539..05f6b5e8370d 100644 --- a/drivers/irqchip/irq-imx-irqsteer.c +++ b/drivers/irqchip/irq-imx-irqsteer.c @@ -231,7 +231,7 @@ static int imx_irqsteer_probe(struct platform_device *pdev) return ret; } -static int imx_irqsteer_remove(struct platform_device *pdev) +static void imx_irqsteer_remove(struct platform_device *pdev) { struct irqsteer_data *irqsteer_data = platform_get_drvdata(pdev); int i; @@ -243,8 +243,6 @@ static int imx_irqsteer_remove(struct platform_device *pdev) irq_domain_remove(irqsteer_data->domain); clk_disable_unprepare(irqsteer_data->ipg_clk); - - return 0; } #ifdef CONFIG_PM @@ -312,6 +310,6 @@ static struct platform_driver imx_irqsteer_driver = { .pm = &imx_irqsteer_pm_ops, }, .probe = imx_irqsteer_probe, - .remove = imx_irqsteer_remove, + .remove_new = imx_irqsteer_remove, }; builtin_platform_driver(imx_irqsteer_driver);