From patchwork Wed Jun 28 17:56:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 113988 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp9107579vqr; Wed, 28 Jun 2023 10:59:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Qrmm6g1waYyz/bCmaz6PMtMo4q1li7xmkUA7Ze3bPRk9i/uLURqsy6zLSJXCJc4HOfGdt X-Received: by 2002:a05:6a00:138d:b0:67d:308b:97ef with SMTP id t13-20020a056a00138d00b0067d308b97efmr5193674pfg.2.1687975154294; Wed, 28 Jun 2023 10:59:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687975154; cv=none; d=google.com; s=arc-20160816; b=UIu9DfBZZsLrZkAik5OBHf7Kk1tbIha13GSWtjEqkiQsbCkTp3XdkoWiDV5zLvwhjP xvNICrB9GP4Z5H/4iN3WPkxhCaPpKs1m68WcyL/p5p8qmzKSSgIuasTVUZB5MDvpCMzb p993COVZnlj6E8GY5dwzJ3bqIC/J/RxB2oDe2knrnKGZ1PicGDTV85A46i1Cu4EdNv2V 87iUa5Lm/NqoxNHs81wwPyLscU/YimwKfU2EewZbQXejj6YbnokGCOgNkh1blUBRhu/Z iWWBXpYrYoyn0x1BR2ODmWLTu39EwUN66IIdYgyUhxlV2k4A/w6sAds+13bc7uy57Sva iXTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1LSRtsJvhdu2zN79QaO182w8F8LZTZrw/UbUJ7jYlPo=; fh=2ET6nL/wlcZ4gumDTTusm6ilw662ytnheFDwMTsLDv4=; b=AQHLKnrOQpJyOwa1OScddFoKOCX2YuFBYiz1eaVf+SHmZXuSjcFPB1oAoT36QBcz9c 7cUD79Gz0sEZ7hq5fwA32bq4qGX7emYjgS3X2lKRbIyoJoK3LWhCdzq4re0Z6lNCmksg hA2aKlAQJ1lgyH9CzLO9x+BmmEoje0KBKtTR5xZAVtnv4pEQzjUJzClNCvi5HlZkU3SJ dkJQW7SSwi4UhZr60aeiEG2Vrya0q2pR2cMM7GIFKsb/8P2yCWo+wIoIn/8VE0AT6Nfi IWP+3GgPua4Iz2OKlyXFQnbHPvfMEv77hDzOo8k8nt0Be6fXvzRaYlD9XR30x/wTLeuQ ILeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VAGQADKa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k84-20020a628457000000b00668705a86ccsi8842277pfd.319.2023.06.28.10.59.01; Wed, 28 Jun 2023 10:59:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VAGQADKa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232017AbjF1R44 (ORCPT + 99 others); Wed, 28 Jun 2023 13:56:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232429AbjF1Rz7 (ORCPT ); Wed, 28 Jun 2023 13:55:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13207ED; Wed, 28 Jun 2023 10:55:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 935F16141D; Wed, 28 Jun 2023 17:55:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1ABBEC433C9; Wed, 28 Jun 2023 17:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687974958; bh=7gxVFglFtXDu/AnNBVBeHPlv7TElOsSUgfmrlZBHPf0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VAGQADKajLlW1y4fkCGn3p1Dl/RgpYmd4NHIx7S2mGSb25bdu9R0GYH1edCFjDrWT tXuz1a1LhxR9StVgXR8q7G8ihL/kHAHNTNvO02H6CAtQ53yaCW8SQxL91q+IcPztHO x8k9ggymNK9nKqeSCuiHLU8YFCgb/bcppPK6nN0BDcvaxUzXBhxLzrU0buDQaaxdY9 P8nN1N9Z6XKDbOIYmGbz83ZnbMmWUFe74RzFn5BkhzaXhX5Kqe3n2fZ78BKFnP/5dh A2L1fOV2uIw7mb2Vyd7sBLkGNsY3X2Vw7VjYyvnMt6jxpNh8HI9rlL4fD0cP0LurMh bK1wlm/YrdjmA== Date: Wed, 28 Jun 2023 11:56:52 -0600 From: "Gustavo A. R. Silva" To: aacraid@microsemi.com, "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook , "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH 07/10][next] scsi: aacraid: Replace one-element array with flexible-array member in struct user_sgmap64 Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769970235272189468?= X-GMAIL-MSGID: =?utf-8?q?1769970235272189468?= Replace one-element array with flexible-array member in struct user_sgmap64. This results in no differences in binary output. Issue found with the help of Coccinelle and audited and fixed, manually. Link: https://github.com/KSPP/linux/issues/79 Link: https://github.com/ClangBuiltLinux/linux/issues/1851 Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook --- drivers/scsi/aacraid/aacraid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h index 87015dd2abd9..94eb83d38be6 100644 --- a/drivers/scsi/aacraid/aacraid.h +++ b/drivers/scsi/aacraid/aacraid.h @@ -522,7 +522,7 @@ struct sgmap64 { struct user_sgmap64 { u32 count; - struct user_sgentry64 sg[1]; + struct user_sgentry64 sg[]; }; struct sgmapraw {