Message ID | bebcd822-d465-45da-adae-5435ec93e6d4@moroto.mountain |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-74136-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp861278dyc; Tue, 20 Feb 2024 22:20:59 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWNNX1rDNhzJHvmAbPg0k3GvWc2sccAfro4fgpK2zKdKiQKmSVPuKoNFC2s/f11NHXzGdW58O7fS4ma8pqANd2qqlGe3Q== X-Google-Smtp-Source: AGHT+IGBcwVdSFQ8aw/AmGe69n1T1zjedPouyfGdP3VuZxwTjF6iGqwxk6MDsxind2QA+kvx1QcZ X-Received: by 2002:a05:620a:448b:b0:787:7ae4:7ec4 with SMTP id x11-20020a05620a448b00b007877ae47ec4mr4437579qkp.71.1708496459319; Tue, 20 Feb 2024 22:20:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708496459; cv=pass; d=google.com; s=arc-20160816; b=T9Vnyjy3NL9PzPZ1Ksf8yt0JGwbKpbF7wsbXMNDdRIDxM2U8QfoQCVcAVxPn1z96BM be5Zvt53guPD7w5PWlZyjktUYW1/sbxVI8+SAO4lfIjazGJzprAuZBYtrVS1goFgDMAq VcpndK9tiHSZElem/BJNiw6ejCPQ4fR/YFNV+4wMxy7zzEeZA5dyJEIoVZG9kqtCJIYG JN/tW35oD2dpO32qd91VKiID33v+CQzrxR891sZ427rUe4Jlr+vvrP0iOZ2o3J81qZDP HriZW44ARPFvgiy6HxEZZVAWMohVJamb9NRXyrw4RfDESfFGuoTL2bxfnruzpjNWYUUV VXlA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-disposition:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:message-id:subject:cc:to:from:date :dkim-signature; bh=z7BDvVnOFI8EfULdSJBhx0Uoarr0dwLKho4DFLKCbPE=; fh=Mev5CepT/VsxuE1tKomiEAyn2QyLuInUt4M8ea1Il74=; b=I7hcBxCabTzVfbmjsjWmASkW4GWWgecy6EOby/LVB2x4QL01CZIZp4OZEoVNpCxyRt 89iXbjUZ0VzESdUeM5cnI/FBMjecqY9QiDtcJQueqjydaX6vDScmFpQDA4GnY+95nOBL MR47s//oFYAmiY8xvLMfHCZl57Cv3ysBmr1loJgUPih6bk8+/Ip0lx+QJAnZwr6geWT+ O32u7pWneH2GVsOywGaZi1u+st5fyE1QsuOkfmL0Aa6/guoyyJ5yBfq/fgp0g36VkBHD QaUDktfYKIymJ0mbRXpflDkPYJe3doU552wXAPeo1QwFVQZWi8pZaI9jg10TXp+LTByr 7mBw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m49MalvU; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-74136-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-74136-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id h6-20020a05620a13e600b007875c8bb93csi8007215qkl.554.2024.02.20.22.20.59 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 22:20:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-74136-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m49MalvU; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-74136-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-74136-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id F2AA91C22AC2 for <ouuuleilei@gmail.com>; Wed, 21 Feb 2024 06:20:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 122B63A1DD; Wed, 21 Feb 2024 06:20:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="m49MalvU" Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7C2739FE8 for <linux-kernel@vger.kernel.org>; Wed, 21 Feb 2024 06:20:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708496426; cv=none; b=Namv3iySrFm04CZI4Z8Vofis+DtsCP/RLBFZVLENqZZk+BcUBftRolYBZQdsJAMjwI5xMwbDU3bMbXGL97NToTXZBZ+F92k9x5vVzR4YoHePCj7BslakLGiejG5KwZq10D3iMFY7QAaqIXjd3CmJRoY6fB46VT00KsCQ/yXGTFQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708496426; c=relaxed/simple; bh=Aa84HSv1+2OvUetKNGlbuxpski5nWr6VCsHSEhRtETY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=DL3rf3Z7Ec/O+X6nMRGPVj8PTHOxEj0FYBFfudXNbMRTUFvMNqqdml80nIRKfv5CFCN5jy5MtwIbQPd/Xh1VeUt78Qqeq6W0rMZipf4IUCsq3OOLRZCDGVrn90TREpt20qAKbcOTSFBwYACKijwPE6100eBdzv2mlLFMqVocxBo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=m49MalvU; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-563c2b2bddbso8903375a12.1 for <linux-kernel@vger.kernel.org>; Tue, 20 Feb 2024 22:20:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708496423; x=1709101223; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=z7BDvVnOFI8EfULdSJBhx0Uoarr0dwLKho4DFLKCbPE=; b=m49MalvUruAIQhB9yuPc/uMVxLpvLNAfVqHVv4KhEPUMQhYBLJRobwiUpuh8t42HdY ZJMQoNnDsIVTIN2gvvcttjk1Bi9c8/m5O6XS4ZEsVMm1ihQCeNjchr16KKWRoh8RFg3K LmGqxYNXggdcg/gRSiaNkJZPl0UrTx5qLBdC+meD+BGxSBNNrBjqeu4qYfT1rIEhp2WW zUKe1uoEiv3AsYzGmJD8RCNhP8EUQ2tFPYleHp2iWdHz9s3kjZM7Pr7058HBAB1q0GZn 3wvMVR6sfBeZdck2lbI+ftSDI8GnZ2Tlacx50uPhhpbvNX4VklI0tFjXVhRvnYBEvPGs 4Hvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708496423; x=1709101223; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z7BDvVnOFI8EfULdSJBhx0Uoarr0dwLKho4DFLKCbPE=; b=rA/bOPCOxPFWQkS2N7s+MMBeACdBr9JEHEkqbqhbW5iygVZoaGo6/Lo+G8XoPfZB2z h7XtNyPzOBxbAo8vLyRglWtRZDqQ6J73gJrse6K1UzsyWLg/GjBs4pR5FvddGZ0jqYJa +asK16qQyF6MMGix/sH0Wb+CS1TWgJG83Rse+va+JlpCBhT2v+VScSV4YGsWTkio9Z2Q QVqF4QvdKFVWhqG2LMEvi1R19eLI2h74kLn6wK5osIdQ3rIYK93JKinFnfdHom+1A8P2 gldi8hQXzF1jUI95q2OGjy99ILqerX4yxt2uzBsxtXwZs2/FlEOeVZM38yLhL2kc18AX 2+NA== X-Forwarded-Encrypted: i=1; AJvYcCWsIGvecAzbCnp5ATC84MiEBTb+r9uk/S32RSj7iDnML9tA+FH4pRV+hTtMu6OGSsRg48xKEafmbLJWAvhJGpp3iuZF1s8F7Xlc294a X-Gm-Message-State: AOJu0YyMWaqAzfwup8FzgIJVgDRsNu61H1bqQK7VznDIVTSsWGxU0jBE lwdaOp/YKnkhJK+X6vbU3iT8+LyEHcqz4crnxcFNNVETOVamkRdVKC1IuAMTtvU= X-Received: by 2002:a05:6402:17c4:b0:563:ccd1:26bd with SMTP id s4-20020a05640217c400b00563ccd126bdmr9951812edy.2.1708496422990; Tue, 20 Feb 2024 22:20:22 -0800 (PST) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id c1-20020a056402100100b0056486eaa669sm2266459edu.50.2024.02.20.22.20.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 22:20:22 -0800 (PST) Date: Wed, 21 Feb 2024 09:20:19 +0300 From: Dan Carpenter <dan.carpenter@linaro.org> To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Cc: Alex Elder <elder@linaro.org>, Jeffrey Hugo <quic_jhugo@quicinc.com>, Erick Archer <erick.archer@gmx.com>, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] bus: mhi: ep: check the correct variable in mhi_ep_register_controller() Message-ID: <bebcd822-d465-45da-adae-5435ec93e6d4@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791488383567118754 X-GMAIL-MSGID: 1791488383567118754 |
Series |
bus: mhi: ep: check the correct variable in mhi_ep_register_controller()
|
|
Commit Message
Dan Carpenter
Feb. 21, 2024, 6:20 a.m. UTC
There is a copy and paste bug here so it checks "ev_ring_el_cache" instead
of "ring_item_cache".
Fixes: 62210a26cd4f ("bus: mhi: ep: Use slab allocator where applicable")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/bus/mhi/ep/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Wed, Feb 21, 2024 at 09:20:19AM +0300, Dan Carpenter wrote: > There is a copy and paste bug here so it checks "ev_ring_el_cache" instead > of "ring_item_cache". > > Fixes: 62210a26cd4f ("bus: mhi: ep: Use slab allocator where applicable") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > drivers/bus/mhi/ep/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c > index 8d7a4102bdb7..f8f674adf1d4 100644 > --- a/drivers/bus/mhi/ep/main.c > +++ b/drivers/bus/mhi/ep/main.c > @@ -1497,7 +1497,7 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl, > mhi_cntrl->ring_item_cache = kmem_cache_create("mhi_ep_ring_item", > sizeof(struct mhi_ep_ring_item), 0, > 0, NULL); > - if (!mhi_cntrl->ev_ring_el_cache) { > + if (!mhi_cntrl->ring_item_cache) { > ret = -ENOMEM; > goto err_destroy_tre_buf_cache; > } > -- > 2.43.0 >
On Wed, Feb 21, 2024 at 09:20:19AM +0300, Dan Carpenter wrote: > There is a copy and paste bug here so it checks "ev_ring_el_cache" instead > of "ring_item_cache". > > Fixes: 62210a26cd4f ("bus: mhi: ep: Use slab allocator where applicable") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Applied to mhi-next! - Mani > --- > drivers/bus/mhi/ep/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c > index 8d7a4102bdb7..f8f674adf1d4 100644 > --- a/drivers/bus/mhi/ep/main.c > +++ b/drivers/bus/mhi/ep/main.c > @@ -1497,7 +1497,7 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl, > mhi_cntrl->ring_item_cache = kmem_cache_create("mhi_ep_ring_item", > sizeof(struct mhi_ep_ring_item), 0, > 0, NULL); > - if (!mhi_cntrl->ev_ring_el_cache) { > + if (!mhi_cntrl->ring_item_cache) { > ret = -ENOMEM; > goto err_destroy_tre_buf_cache; > } > -- > 2.43.0 >
diff --git a/drivers/bus/mhi/ep/main.c b/drivers/bus/mhi/ep/main.c index 8d7a4102bdb7..f8f674adf1d4 100644 --- a/drivers/bus/mhi/ep/main.c +++ b/drivers/bus/mhi/ep/main.c @@ -1497,7 +1497,7 @@ int mhi_ep_register_controller(struct mhi_ep_cntrl *mhi_cntrl, mhi_cntrl->ring_item_cache = kmem_cache_create("mhi_ep_ring_item", sizeof(struct mhi_ep_ring_item), 0, 0, NULL); - if (!mhi_cntrl->ev_ring_el_cache) { + if (!mhi_cntrl->ring_item_cache) { ret = -ENOMEM; goto err_destroy_tre_buf_cache; }