From patchwork Tue Jul 18 16:54:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 122138 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1881053vqt; Tue, 18 Jul 2023 09:57:41 -0700 (PDT) X-Google-Smtp-Source: APBJJlE00JEcO3q0aiqb2KUkcqZF/43gDJRpss3sXMrFGTVycUn+i6CRNEzvlQQ4p1QuofaHYGPp X-Received: by 2002:a05:6a20:3216:b0:130:a15d:54eb with SMTP id hl22-20020a056a20321600b00130a15d54ebmr13926432pzc.24.1689699461113; Tue, 18 Jul 2023 09:57:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689699461; cv=none; d=google.com; s=arc-20160816; b=jAwQvwjFiBVBh0k+rg93cHOIljLd1P58WmdF/+v+VZpeYZWqkVKfVlJup8v8EXPuMa P7mY+jXstBUtpAikG1kJZRC8s3valCagznWbWQBxi92PCUbDNap6SNI7Tza89YJOySur kU/oOXYJjaUYVswsFHNU6M4k10V5aLG4vUrme5ItdudL0Z11/pJv0T+Da/oJN4iuwpJn pXMJq835wSsK5MKhijxjnA6/kj6VRKPTMJrS2eGdA9I8C/dj0vrtp4aDVEjNXfApIFmB JymSKawrk9n+O3flaaXGk9eNVo4ryeVfUpPj/9qpZbhNfUA7ppjcDfvomcJhs3oTbYw0 JrJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=jz2sK9eECohbPmGBWvvFGiRJ9s0iLNqJBwCTNuL9JHI=; fh=Ople2ijcDVdvBJwvAg2RvyZp0qNZK7It46SN0LxlrVk=; b=xJz5p46vwwKN4JWiTmg1jYSU5y5qDLejyetVUKjQwrIcv/FEAOUII8EzefK5eu635S BQ+84+Xs8XP/lcusHTlY2nzR3fXId2pCJDDVuve27b3/DKm1gcXH0lyHppgQj1pyB+zv JwfjbsnCa01gs2bb15/xH51R7rU916rAZQHNsLO0Mh+22yJGhm0PIuqhE0HuLhwJtv8a QrVqfIZrpLqAkXaCMztdmY0bhAPlSdlEJh8xBf2byvq0Xzo3qcW0bRz7tjyJEXmvY3Vu 4AB16x4SQXNA2HOih5V5nm3KOuUwZr80no5RKwY+wpriNKkJa9AsbN1Fnaycl7Zd6KaA /O9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j3-20020a056a00234300b00666878f8de7si1780582pfj.397.2023.07.18.09.57.27; Tue, 18 Jul 2023 09:57:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233540AbjGRQzh (ORCPT + 99 others); Tue, 18 Jul 2023 12:55:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232347AbjGRQy7 (ORCPT ); Tue, 18 Jul 2023 12:54:59 -0400 Received: from albert.telenet-ops.be (albert.telenet-ops.be [IPv6:2a02:1800:110:4::f00:1a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 021821712 for ; Tue, 18 Jul 2023 09:54:54 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:5803:2d6d:5bbc:e252]) by albert.telenet-ops.be with bizsmtp id Ngur2A00A0ucMBo06gurSY; Tue, 18 Jul 2023 18:54:52 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qLnyD-001nXf-3d; Tue, 18 Jul 2023 18:54:51 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qLnyN-000gbU-4l; Tue, 18 Jul 2023 18:54:51 +0200 From: Geert Uytterhoeven To: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Laurent Pinchart Subject: [PATCH v2 05/41] drm: renesas: shmobile: Fix ARGB32 overlay format typo Date: Tue, 18 Jul 2023 18:54:10 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771778301687337982 X-GMAIL-MSGID: 1771778301687337982 When configuring a CHn Source Image Format Register (LDBBSIFR), one should use the corresponding LDBBSIFR_RPKF_* definition for overlay planes, not the DDFR_PKF_* definition for the primary plane. Fortunately both definitions resolve to the same value, so this bug did not cause any harm. Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- v2: - s/configurating/configuring/, - Add Reviewed-by. --- drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c index 0e34573c3cb3d032..7e49e2873da1bb6f 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c @@ -94,10 +94,10 @@ static void __shmob_drm_plane_setup(struct shmob_drm_plane *splane, format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDBBSIFR_RPKF_RGB24; break; case DRM_FORMAT_ARGB8888: - format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDDFR_PKF_ARGB32; + format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDBBSIFR_RPKF_ARGB32; break; case DRM_FORMAT_XRGB8888: - format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDDFR_PKF_ARGB32; + format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDBBSIFR_RPKF_ARGB32; break; case DRM_FORMAT_NV12: case DRM_FORMAT_NV21: