From patchwork Fri Dec 15 13:59:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 179308 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9295812dys; Fri, 15 Dec 2023 06:02:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFoOKKg9bBwO5MTzMhkewQe2K6PvGvuz7mwEH31bfR9Ae6vyS48WrEh/fn0keRn3Wmer9Ij X-Received: by 2002:a9d:6b90:0:b0:6d9:de3c:e6b2 with SMTP id b16-20020a9d6b90000000b006d9de3ce6b2mr6508976otq.39.1702648973144; Fri, 15 Dec 2023 06:02:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702648973; cv=none; d=google.com; s=arc-20160816; b=Z+3rl+qEb653PVhzdb8Av9f5f67gtz+zzOOXQQilHh1Hx8gCdV5dAkl8r2pD5aJEYP Ucfo+H9ZE8HhffimcUVr6QIgxOYl9rmWHDgOTIzbydV5czXwN9lrF1XeU4Z0LweTfrmu pxRAU3Dll64aehOHis2UiXBHp3cfoIbMSk+nCAR21oLjIx0B3Fo81XPo761DituylYG9 awXlzhoH0KahmXtYrPfgw/Zf30bFFAg3PxFRpnfopgUw64Z8PelV3ShJ4+5Q2i83meNa wLaECGsPMDiB0/dZpUiDKeP+uyylqhBsRotgKhY339F4hvjMEBHy9xKTgT6AO0xfGkMI 8lTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=EV4Wa+Opb0Bk9Gc4Ep+A/7NaUe2smM4BVPVAKr6Ziac=; fh=IzJ+G4eNjitPFqUi14ivUwieOMsSQ7Fus+T/b8/hbjg=; b=BxDAUx6BWzY5sHUrkp+CFFfrpWixS3lgAqPkAf9dBrvwYgEzUrTU3wwyBnHvNyDLg/ aNoRiCfC4hq3JjNp9D8gvOBfErw0p59PlkMXREjmAMAEeyS7nlnXv6qer0xaAnTpbZUZ 6YaCVHgGrW8C+2jrW6c25NDn+HnBrQebBVtnEMwwBBYSaEUyOPWieQG0eqIgpMJMFYIy TERdIgdlTB2eViWwKEBofKRZCEBLFS4saIKaJygkLWoSJfw/IkhS6F49c68+aRUtyYAX od7HU6weZYGgKfFvmI/MJPecnQDLGsoE/XbTGHbc0ajVkj7NAh2jtDRGQmr9SvmXHE/8 h9pA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-1064-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1064-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id g24-20020a056830161800b006d8000014a1si5166887otr.331.2023.12.15.06.02.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 06:02:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1064-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-1064-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1064-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4ECF7284378 for ; Fri, 15 Dec 2023 14:02:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 85D1B37140; Fri, 15 Dec 2023 13:59:42 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A41F321B2 for ; Fri, 15 Dec 2023 13:59:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rE8iy-0002mw-7C; Fri, 15 Dec 2023 14:59:32 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rE8ix-00G2Zx-Oe; Fri, 15 Dec 2023 14:59:31 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rE8ix-003cCp-F9; Fri, 15 Dec 2023 14:59:31 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Will Deacon , Mark Rutland Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/18] perf: fsl_imx9_ddr: Convert to platform remove callback returning void Date: Fri, 15 Dec 2023 14:59:12 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1849; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=NXdhdQQKZ6b1dcEG52uoPa64FeprMMqzZeyISKSgu6o=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfFuzTqXZWOR+jvLxMzxn/N3EohQwIej9USNDY 81tT77OLbSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXxbswAKCRCPgPtYfRL+ TsMDCACbYsOrWMQZTfj5ByGoS2/B+xJSE88BfpXrdNEUrS5LY2vhmwYMlX1NbyFGP0DpYKUDqZC c7LDp1ZSXl2iLIjp9Thh3zsRes5DIjXq/tqCUwMIMyyh7JkHwZg5xcbjcsKrWiU/huql2AaryPH l51ZpPkIW6xq31eVovns+UQGQFnHKo1BTlZ8r7aGkuYjIn9J33uu1eTvqM1/e1mx1fxvHH5US6e sBKjLsP0K/dYgyOfYCQ5Jq2wb9e1yiLR9olQpEqjd6aAbHw1tCKWJcL+ZXWONA3ryjMdANvZdYk omhE20yAo7ThOBtHe0scaUjv2wgRUeQfMZMFK+c53Wyo0DDi X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785356849826471768 X-GMAIL-MSGID: 1785356849826471768 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/perf/fsl_imx9_ddr_perf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c index 9685645bfe04..72c2d3074cde 100644 --- a/drivers/perf/fsl_imx9_ddr_perf.c +++ b/drivers/perf/fsl_imx9_ddr_perf.c @@ -679,7 +679,7 @@ static int ddr_perf_probe(struct platform_device *pdev) return ret; } -static int ddr_perf_remove(struct platform_device *pdev) +static void ddr_perf_remove(struct platform_device *pdev) { struct ddr_pmu *pmu = platform_get_drvdata(pdev); @@ -689,8 +689,6 @@ static int ddr_perf_remove(struct platform_device *pdev) perf_pmu_unregister(&pmu->pmu); ida_free(&ddr_ida, pmu->id); - - return 0; } static struct platform_driver imx_ddr_pmu_driver = { @@ -700,7 +698,7 @@ static struct platform_driver imx_ddr_pmu_driver = { .suppress_bind_attrs = true, }, .probe = ddr_perf_probe, - .remove = ddr_perf_remove, + .remove_new = ddr_perf_remove, }; module_platform_driver(imx_ddr_pmu_driver);