From patchwork Fri Jan 20 12:35:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thorsten Leemhuis X-Patchwork-Id: 46315 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp172770wrn; Fri, 20 Jan 2023 04:36:34 -0800 (PST) X-Google-Smtp-Source: AMrXdXu93gyODm9ABAjQAo6L2PMLpnfqjFYfflOriyilXER84uziIbQeXvmbqHidpjXAVm46JYv3 X-Received: by 2002:a17:907:d23:b0:877:6873:70b9 with SMTP id gn35-20020a1709070d2300b00877687370b9mr10568765ejc.29.1674218194014; Fri, 20 Jan 2023 04:36:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674218193; cv=none; d=google.com; s=arc-20160816; b=BTKBgWgTVRLoeOQ9meXvQViY3lxDcHikzH6vkmet+1Aj9OfEg4rWbT7KgU76l3sD1G jZJQ0xF1UWKjpkCDI+bTG9ubMEuWLwGSXtgo9fy4MAFA98rn/97iuByPAnSijIzViwdX 18vnJJwy9k7rWpMVW0uIzWWz/P8csK5OF5sFddE26RV5ZHf9FWXfzYE1CuISK4PC8jv+ T/6VQhJWe0Az/kRhRONuC9NddAG77gTzR9kijUwaT+ERYoqDgmCwGud+5RsDIHZrXvT0 K2azZ8a9UpLZf8hSxEf6senDtF4/mXHyxBn7OtJFGqHJ+P5d1d+/wV/4Mnlk4ky+YRmK rxiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=dXuijO9OGp8Vq/sfQ7Lfn8QrWAQCMKhSoueRZJRzGAU=; b=Kbchjqo34QcAXqP76lIUxNlncw4Cr+Bbu5PWsjcrZ5I2PckSnjM0FzpRhu3kjEBdx6 ofaf97292jhQCs9IzwtyzmzRWHv15opCss0/wpc/Z4bT22tVrHbu+Dz6luvsvHxyzJgp u/9bb237Ezf3d90BQnuXp5ACmqcned177zIsTFMw7d/trB8Pf4Fe2uqK+DZYV3kqyFTC 8VfFvvmj5Fp7i+TuQVrXBP90ZQ9CXcVHAuMjRnTJchGpoZqgKdZAVv0v9brDD2n5tLGq WpMsymJcd/XtUVAmCX/Q0W7MDB/1qfI4MTI6tygrchesLfcniVNIGHLiFMrml3RZNeQ+ +4zg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dd7-20020a1709069b8700b007ad9c8201e7si22899558ejc.93.2023.01.20.04.36.09; Fri, 20 Jan 2023 04:36:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230209AbjATMfj (ORCPT + 99 others); Fri, 20 Jan 2023 07:35:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230147AbjATMf3 (ORCPT ); Fri, 20 Jan 2023 07:35:29 -0500 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1410DBD17B for ; Fri, 20 Jan 2023 04:35:24 -0800 (PST) Received: from ip4d14bd73.dynamic.kabel-deutschland.de ([77.20.189.115] helo=truhe.fritz.box); authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1pIqc6-0007pV-Ds; Fri, 20 Jan 2023 13:35:22 +0100 From: Thorsten Leemhuis To: Joe Perches , Andy Whitcroft , Dwaipayan Ray , Lukas Bulwahn Cc: =?utf-8?q?Kai_Wasserb=C3=A4ch?= , Andrew Morton , linux-kernel@vger.kernel.org Subject: [PATCH v4 2/3] checkpatch: warn when Reported-by: is not followed by Link: Date: Fri, 20 Jan 2023 13:35:19 +0100 Message-Id: X-Mailer: git-send-email 2.39.0 In-Reply-To: References: MIME-Version: 1.0 X-bounce-key: webpack.hosteurope.de;linux@leemhuis.info;1674218125;93060bd7; X-HE-SMSGID: 1pIqc6-0007pV-Ds X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755545017418817748?= X-GMAIL-MSGID: =?utf-8?q?1755545017418817748?= From: Kai Wasserbäch Encourage patch authors to link to reports by issuing a warning, if a Reported-by: is not accompanied by a link to the report. Those links are often extremely useful for any code archaeologist that wants to know more about the backstory of a change than the commit message provides. That includes maintainers higher up in the patch-flow hierarchy, which is why Linus asks developers to add such links [1, 2, 3]. To quote [1]: > Again, the commit has a link to the patch *submission*, which is > almost entirely useless. There's no link to the actual problem the > patch fixes. > > [...] > > Put another way: I can see that > > Reported-by: Zhangfei Gao > > in the commit, but I don't have a clue what the actual report was, and > there really isn't enough information in the commit itself, except for > a fairly handwavy "Device drivers might, for instance, still need to > flush operations.." > > I don't want to know what device drivers _might_ do. I would want to > have an actual pointer to what they do and where. Another reason why these links are wanted: the ongoing regression tracking efforts can only scale with them, as they allow the regression tracking bot 'regzbot' to automatically connect tracked reports with patches that are posted or committed to fix tracked regressions. Link: https://lore.kernel.org/all/CAHk-=wjMmSZzMJ3Xnskdg4+GGz=5p5p+GSYyFBTh0f-DgvdBWg@mail.gmail.com/ [1] Link: https://lore.kernel.org/all/CAHk-=wgs38ZrfPvy=nOwVkVzjpM3VFU1zobP37Fwd_h9iAD5JQ@mail.gmail.com/ [2] Link: https://lore.kernel.org/all/CAHk-=wjxzafG-=J8oT30s7upn4RhBs6TX-uVFZ5rME+L5_DoJA@mail.gmail.com/ [3] Signed-off-by: Kai Wasserbäch Co-developed-by: Thorsten Leemhuis Signed-off-by: Thorsten Leemhuis Reported-by: syzbot+bba886ab504fcafecafe@syzkaller.appspotmail.com Reported-by: Abaci Robot Reported-by: https://syzkaller.appspot.com/b/5266d464285a03cee9db Reported-by: syzbot+cafecafecaca0cafecafe@syzkaller.appspotmail.com Reported-by: syzbot@syzkaller.appspotmail.com Reported-by: syzbot@syzkaller.appspotmail.com Reported-by: syzbot+df61b36319e045c00a08@syzkaller.appspotmail.com --- scripts/checkpatch.pl | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d739ce0909b1..b74d6002f773 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3155,8 +3155,20 @@ sub process { "Co-developed-by and Signed-off-by: name/email do not match \n" . "$here\n" . $rawline . "\n" .$rawlines[$linenr]); } } + +# check if Reported-by: is followed by a Link: + if ($sign_off =~ /^reported(?:|-and-tested)-by:$/i) { + if (!defined $lines[$linenr]) { + WARN("BAD_REPORTED_BY_LINK", + "Reported-by: should be immediately followed by Link: to the report\n" . $herecurr . $rawlines[$linenr] . "\n"); + } elsif ($rawlines[$linenr] !~ m{^link:\s*https?://}i) { + WARN("BAD_REPORTED_BY_LINK", + "Reported-by: should be immediately followed by Link: with a URL to the report\n" . $herecurr . $rawlines[$linenr] . "\n"); + } + } } + # Check Fixes: styles is correct if (!$in_header_lines && $line =~ /^\s*fixes:?\s*(?:commit\s*)?[0-9a-f]{5,}\b/i) {