From patchwork Tue Jul 18 16:54:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 122177 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1909161vqt; Tue, 18 Jul 2023 10:45:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlH4W6YBCcFaqe2if22FmFPybdsUD3P/NGP0l8X3uHgMehZdN8KoJJabPeaM/EAwMF8rLs4B X-Received: by 2002:a17:906:76d4:b0:94f:449e:75db with SMTP id q20-20020a17090676d400b0094f449e75dbmr345809ejn.52.1689702334374; Tue, 18 Jul 2023 10:45:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689702334; cv=none; d=google.com; s=arc-20160816; b=AWu4vYfBEFI9sR5w+S2l4eLm6R5IHQ6rjYqjdbvSRsEmaYsneEq2ibDiX8Z3E7jf9y uZ+RKEHSNvftjx/slB9MoYIUb/5cn+CDU3de0UxYQGPj5emBUVPfwUBp42a6+vbN3aoC y8R+cSFE1Mn3JTynjTRXeS9vN+g51wnjXnSoJiy3xn0KulIBnTaqQPb4Xoal2hjM7Maq CgDcjbDPqkc2ulRyiSVmFmFdgl/er5KNLI8mBPUiHsGewgcnCwUqUHcgIgn41zydchwD wgV3mzpRWrpmo+mVumt8Qp853x3lBTZYsj+smSGWJafqE+i2ymiZWfGmu9PnVQJRYQ66 TvhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=GZYp8w7W9pRC1kbA2BSTJhfyXRhRnPGphkMLtNccb6c=; fh=Ople2ijcDVdvBJwvAg2RvyZp0qNZK7It46SN0LxlrVk=; b=GKB2aOax2tw5+p5OrsctBfrEic7NG+T/dWmoTgNk/tSSsmSZMLGZT67BYog81vNNN3 4Vv5xcWCQDYSkgDnVO1so0CwQzDoCPsxoIEGe1J+3eJv30ajNqAnZkoy/4EDpUUoca5w UqxyuUZtFQGwDC17LFyD9k6OL6CM1ok/746si/MJbwCVIW1iWTb4a92BRu5todL9gFXm vBDoTaP1/DdjbUkA0xjsy6PqKsT83rJl5G03/gTZ/RvopfU3kq4vw2p6NUDQaQsrCq/+ oeA7Bia1wYNUaieayf6LFTnL7KCkHCE0d9vW/hm0lMITcFEXC7VL/SbvliL2V986E16l BTUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i26-20020a170906115a00b00991f9e2a81asi1464557eja.238.2023.07.18.10.45.10; Tue, 18 Jul 2023 10:45:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232974AbjGRQ4i (ORCPT + 99 others); Tue, 18 Jul 2023 12:56:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232941AbjGRQzF (ORCPT ); Tue, 18 Jul 2023 12:55:05 -0400 Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAA4A1BC6 for ; Tue, 18 Jul 2023 09:54:55 -0700 (PDT) Received: from ramsan.of.borg ([84.195.187.55]) by andre.telenet-ops.be with bizsmtp id Ngus2A0021C8whw01gusGv; Tue, 18 Jul 2023 18:54:53 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qLnyD-001nZi-N7; Tue, 18 Jul 2023 18:54:51 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qLnyN-000gdu-OF; Tue, 18 Jul 2023 18:54:51 +0200 From: Geert Uytterhoeven To: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Laurent Pinchart Subject: [PATCH v2 35/41] drm: renesas: shmobile: Cleanup encoder Date: Tue, 18 Jul 2023 18:54:40 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771781314861649296 X-GMAIL-MSGID: 1771781314861649296 Most unused callbacks can be NULL pointers these days. Drop a bunch of empty encoder callbacks. Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- v2: - Add Reviewed-by. --- .../gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 26 ------------------- 1 file changed, 26 deletions(-) diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c index ab42a4999a55c475..365eb3e154130d41 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c @@ -534,11 +534,6 @@ int shmob_drm_crtc_create(struct shmob_drm_device *sdev) * Encoder */ -static void shmob_drm_encoder_dpms(struct drm_encoder *encoder, int mode) -{ - /* No-op, everything is handled in the CRTC code. */ -} - static bool shmob_drm_encoder_mode_fixup(struct drm_encoder *encoder, const struct drm_display_mode *mode, struct drm_display_mode *adjusted_mode) @@ -561,29 +556,8 @@ static bool shmob_drm_encoder_mode_fixup(struct drm_encoder *encoder, return true; } -static void shmob_drm_encoder_mode_prepare(struct drm_encoder *encoder) -{ - /* No-op, everything is handled in the CRTC code. */ -} - -static void shmob_drm_encoder_mode_set(struct drm_encoder *encoder, - struct drm_display_mode *mode, - struct drm_display_mode *adjusted_mode) -{ - /* No-op, everything is handled in the CRTC code. */ -} - -static void shmob_drm_encoder_mode_commit(struct drm_encoder *encoder) -{ - /* No-op, everything is handled in the CRTC code. */ -} - static const struct drm_encoder_helper_funcs encoder_helper_funcs = { - .dpms = shmob_drm_encoder_dpms, .mode_fixup = shmob_drm_encoder_mode_fixup, - .prepare = shmob_drm_encoder_mode_prepare, - .commit = shmob_drm_encoder_mode_commit, - .mode_set = shmob_drm_encoder_mode_set, }; int shmob_drm_encoder_create(struct shmob_drm_device *sdev)