From patchwork Tue Nov 1 21:14:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 13884 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp3213187wru; Tue, 1 Nov 2022 14:17:35 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5JvKSiZ6Rk2yY3lRgyaSsICmjRsaWk/2HF/yq1CTIq+aisf4UsjBeR+hGVefM5rr5qOkqc X-Received: by 2002:a17:90a:8b93:b0:20a:bd84:5182 with SMTP id z19-20020a17090a8b9300b0020abd845182mr40607910pjn.161.1667337454849; Tue, 01 Nov 2022 14:17:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667337454; cv=none; d=google.com; s=arc-20160816; b=IzUGa8t3n0XD71hkZz901Vg5jS1bJAMokwrV0OORPI0RGyisSNXG9C5S/mV5sWMUaS Z0wxvGoxIwgR7KFi31bXBq3bzytidd/7sqHrhd/5R/3d2i9MnyEDP61MAU2AvuI8wc6h m5fzHhgw48OWSEGTnwlwkc/TkvqavNOJ2jM/CkKHzTLveh2Cynwd2wuDI77W2qovEeS6 LtN6fmX2O42bhjYxFlJWBYFKg9cPeJtR7oYKT+qvX0TOEzqzh4/8QIiGtO5qg44FYD5J evJWkDFg6si8Asd2WEJERMscw7S2IHdST4kUavlpQCpWc0C7lH9GrkIVwCWiO3/FF5uL 0mlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=uZ7soKuGrS6VWBM554KYUGBnuGF3lyGUyV4rGA5980c=; b=bOTRTB4HuS/iW/857/ZLdVDF5+6bIiUmQQ+mwsjQThWLU3w6vbMpcV5K9gMLMKnIzr qLVuvfUtKucYKq+j1n75b+rAn2KNW8Gn4FThSJqTh+8C3IUzaeFQ+wH43tregKSDYlBE I/SYNGGop+9UKlpAyualxNsKHXOwJDDBnd8b//DdXCpG7IP287M/ywnV2qXRbT3pKxsA GHrFn4ChADzhqw4dH97MuzkbmlAktRioejP1+EHDxMm9F4KO2a1X1trSOKndgw08UhrE d7fckPJo0SfD0Hf8/Bh+KTT5iZ/ZiPSWzjKNQ4qWNzspP9srZ3Hbzpopbc0M5vmKSSDm YF9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mi7-20020a17090b4b4700b0020354bcfe09si6888009pjb.129.2022.11.01.14.17.22; Tue, 01 Nov 2022 14:17:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230520AbiKAVQ3 (ORCPT + 99 others); Tue, 1 Nov 2022 17:16:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230374AbiKAVPh (ORCPT ); Tue, 1 Nov 2022 17:15:37 -0400 Received: from smtp.smtpout.orange.fr (smtp-15.smtpout.orange.fr [80.12.242.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E2131F61F for ; Tue, 1 Nov 2022 14:15:23 -0700 (PDT) Received: from pop-os.home ([86.243.100.34]) by smtp.orange.fr with ESMTPA id pyanoKD2rsfCIpybRoWfKG; Tue, 01 Nov 2022 22:15:22 +0100 X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Tue, 01 Nov 2022 22:15:22 +0100 X-ME-IP: 86.243.100.34 From: Christophe JAILLET To: Luis Chamberlain Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-modules@vger.kernel.org Subject: [PATCH 18/30] module: Use kstrtobool() instead of strtobool() Date: Tue, 1 Nov 2022 22:14:06 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748330038932106129?= X-GMAIL-MSGID: =?utf-8?q?1748330038932106129?= strtobool() is the same as kstrtobool(). However, the latter is more used within the kernel. In order to remove strtobool() and slightly simplify kstrtox.h, switch to the other function name. While at it, include the corresponding header file () Signed-off-by: Christophe JAILLET Reviewed-by: Luis Chamberlain Reviewed-by: Aaron Tomlin --- This patch is part of a serie that axes all usages of strtobool(). Each patch can be applied independently from the other ones. The last patch of the serie removes the definition of strtobool(). You may not be in copy of the cover letter. So, if needed, it is available at [1]. [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/ --- kernel/module/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/module/main.c b/kernel/module/main.c index ff2dfd1f548d..79e17522e196 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -2649,7 +2650,7 @@ static int unknown_module_param_cb(char *param, char *val, const char *modname, int ret; if (strcmp(param, "async_probe") == 0) { - if (strtobool(val, &mod->async_probe_requested)) + if (kstrtobool(val, &mod->async_probe_requested)) mod->async_probe_requested = true; return 0; }