From patchwork Sun Dec 31 08:42:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 184101 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp3421563dyb; Sun, 31 Dec 2023 00:42:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IGf0CK0HuH7o5KtkIRP/3+TBVKLss7TIAnePTysMQKGVVYGhe6TcAbRecsv4j+8J4SYJBjI X-Received: by 2002:a05:6e02:b29:b0:35f:efee:96a7 with SMTP id e9-20020a056e020b2900b0035fefee96a7mr19183518ilu.40.1704012177006; Sun, 31 Dec 2023 00:42:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704012176; cv=none; d=google.com; s=arc-20160816; b=sCiCID3ZhZiFoxQCUW0GWZEYs6AjsuOrcVdT9o4MmGppwS+qSQqw3oM+Tj/xmm/ITI V44qmMs1/K+A7+0cvnYSlFaZ73EOe18VXWFY7TI6UVxfqfwaxsCPYTtUdmY0Qo1xcNxx p/kfQaL4xxRRrRT8df2o15OXU9F+F70Kaw0PUIw7WN9Nht+BzKhcLQAU/yt3AYrBWP7E 8RZNMBFUrE+CvxYuPC8hNrauFJW7zpeRdY9hrnSAMEEgTvwcobL0eyaAdz1SAK1L/6kb 4U4/RQwzaJ/Pns9Qlz9qk+Cba4UAKz6D/LOw93SFQ4eqgPZ8tMWplGmRRosuH9Zgrs8H eYJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=iznB19w767IVVuZT8nEAu/c5mq3ydn/hH4S70BJCCEM=; fh=mHUc5t111K6blR9l7YFjk4JXmM1O1ZpTKprQuCYlFtM=; b=ovJuJ6/wG6F9hjLNvAzMuUu796GIFvDTfbZlS9n9Pe8JWmCtYajfrwmyFjmIeCh5uv aSCr5J6yaS2G8zb0ojKAsTRF6jMFWM7fKd6MeJIgksmZz2YOpxlJsYYDN3n6Gby6scTY L5t3PE7LmUoFhtS0v1Mfugxfsy1Be7Pj9U+ZseDoKqbLVgxkzQ/pT91299gdKYmQ61eh c0qRzlngVewKL5ZyCgng/icVPKPV+rqgltlWJidMSBi/179ilKpi4O+y+6X0/aOdDQvA 6lHtg2eqivMp5wJBXZpdUpzuLj0l86S8m+nsgRvhP2ArPVBXwDfpGrq4CdfqZCvX58Ta xoCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=TJ6Xc3tu; spf=pass (google.com: domain of linux-kernel+bounces-13659-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13659-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id i10-20020a1709026aca00b001d41999d9b6si11982841plt.541.2023.12.31.00.42.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 Dec 2023 00:42:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-13659-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=TJ6Xc3tu; spf=pass (google.com: domain of linux-kernel+bounces-13659-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-13659-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8F9B5B217E0 for ; Sun, 31 Dec 2023 08:42:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 11D0628FD; Sun, 31 Dec 2023 08:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="TJ6Xc3tu" X-Original-To: linux-kernel@vger.kernel.org Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49469185D; Sun, 31 Dec 2023 08:42:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1704012145; x=1704616945; i=markus.elfring@web.de; bh=qhknSDGJ/5EFhUiXS84uiALl32Ogpu0VDaqNX9XNDOI=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=TJ6Xc3tuT5BWP7DrgY0OAklTPEiHTFgyaKlc0saWRF+9GEaaL4I6iR9aZo4nMM1W VhYyIvgN20v2dCTigXqEf2GsVP0KnA2e4sZFYbE1c6VpBbf1bhBCYHSCcrayRzkCS Gy4yS04lyKn9KBRTsIclrpcUyKDUXIeWkX0ymlWSPr7DXI99wRfdoJybb3MbpQp9+ w4zHvLUdB+Xy9w1hXLf41qQ26fR3+Gc9L3lASmJP8I1yDzzxpVaNYBSd2bVY8h4HO EFwZroV/shsOKIWEK7hVakLc7oy9Aobv87Hwkjh63Q2wBJ+xa9Lk6Vy2dj3zDIA7Z hPKC9Pc8mG7aaG6zrA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.90.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MjxiW-1qvkz30as4-00kXSF; Sun, 31 Dec 2023 09:42:25 +0100 Message-ID: Date: Sun, 31 Dec 2023 09:42:24 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/3] gcov: Return directly after a failed kzalloc() in new_node() Content-Language: en-GB From: Markus Elfring To: Peter Oberparleiter , kernel-janitors@vger.kernel.org Cc: LKML References: In-Reply-To: X-Provags-ID: V03:K1:dblaX9Kqfi7kqmD1MmvGZyBFiMSa+A/t6npRduaddmwJki6rCCl RbORVETR70HNMnFupcJKIf+tvbFJMddVRwjCHvb7XJfq+vy22VtvmzOrj7TS+f2tdwpVng6 fU1+qKMU1APyCAzKNiiXSu3LKh8Glb48vNR94VexFdp8fpI2RIKz1Sypi6h2s1MB8w7BUZn lcHGwmZUY1dJcGhlbYf5A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:2D6hG3Prbpo=;g3s2eWiHgFOxYVWeVF+VljwWxyq c2q3yr+ESxBV1E6YijOOzf/WfamPIUFTzkVOHekJwbeq+Gx+suDNhgcIy4gyY/GeL64v2Gxr4 UQDfFeVtADt0PC8hNwbysKoC1YPQ6R+ThGrzWMOvtYtD5a71J7L//IonyHzQVjkiQCA6j3C+b y7R94ObSvr312sCboO6HOoFQ+fTuzV4dK83jvIRMmWPbn3rj+GBl6/a6QWVwpPN/Llm4GUSq5 H4B2uqoeavUmws4DomnHW4atYwP/rKAMTkFziS4XuBrbwuiKwUb51GfXqcOKq2W7c6qJ7rqgH JrJ855f4+cNo1ZXcjYOcVx4vtrx8Xe4Gl29i6mgAeomcHC6gMSNoIo8kPF2uOJEckCf6V1krX ks3htFXFOeicSdxEWQR5iBk/d1yuXUKsU3i6a/PloeeRDMn5IOpEpzapgwXg3eI4hYShnmX0t 2xrX+qOxYTL30JPhFpqCr6uAekx4c7BY41N2+87QfpPk6Tci5NOQ4QCGsuhlSEtiRjivHHQcC 8Qfx/npNHfO6LwSoSUlfN7N3/vyQzQzGFe8u+uqC/Ut3JEfIoLVfz3FZp09W2glg7TBXxPoYO pxzIhhh+nphBEi/Y0Xk7cqf0X4jIPjOJC9JHHSnv6kFw/mDYScYIL0mk9JB5GYnq6kVEU9Ezn ZdjMvEDNl2VcTvdmfI0uORSkP2SRR0S/sk3WYkhrDXVP2TYC6BhliSydDoOOI4OlFbn59Rwwd ib+r1XvA8MXaU6uuzQDsIzs8tXKxgmkY49YdL6J4Yn/Eymp0LDAi6YhbLGPwjiTL6nJN6lCtK +zDQMUBaomVnr6/X1N/JV0MXIi+DNG/y4OYGZvU+BLxD+h5zpAgKflytDJnFqcuyxpB81vkr/ sw5GN0TqhT1lpFf6igBg/ckX6SsGrbBhEoLw1xoUlntcPV5TrcR7RysweNUwS4zlelgsgmJIC x/ExEw== X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786786272434596722 X-GMAIL-MSGID: 1786786272434596722 From: Markus Elfring Date: Sun, 31 Dec 2023 09:12:44 +0100 The kfree() function was called in one case by the new_node() function during error handling even if the passed variable contained a null pointer. This issue was detected by using the Coccinelle software. Thus return directly after a call of the function “kzalloc” failed at the beginning. Signed-off-by: Markus Elfring --- kernel/gcov/fs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.43.0 diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c index 0fbfa444a388..10916c70fad9 100644 --- a/kernel/gcov/fs.c +++ b/kernel/gcov/fs.c @@ -543,7 +543,8 @@ static struct gcov_node *new_node(struct gcov_node *parent, node = kzalloc(sizeof(struct gcov_node) + strlen(name) + 1, GFP_KERNEL); if (!node) - goto err_nomem; + return NULL; + if (info) { node->loaded_info = kcalloc(1, sizeof(struct gcov_info *), GFP_KERNEL);