From patchwork Mon Jun 12 17:16:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Murphy X-Patchwork-Id: 106735 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp30856vqr; Mon, 12 Jun 2023 10:40:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6BCWv8DfPYj8OvUcWVedx5cgHcSm0pWGChym7oZtXYZRYe79cIVi9x6KiH3m+kj8dobygr X-Received: by 2002:a17:906:6a29:b0:97c:b6e6:f36a with SMTP id qw41-20020a1709066a2900b0097cb6e6f36amr7491052ejc.62.1686591646185; Mon, 12 Jun 2023 10:40:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686591646; cv=none; d=google.com; s=arc-20160816; b=YIYdmd5hYb9lGnmEQBz9z2daQ+jHfey0uZ273ueiWkcxS1zo/hWopum1lv3rK6yBiv GNgHYVNJqhI5QwhreO+dursyagreksbadfVnhGG+sh0SbaRapi3ATtOTALy7tOn4/29W 6KPiSV5C60FMEYQpe9Kbuv10nG2Q82V+pMGwxV1PA67J83x3O3xX5RKrxuusuD0klpjx i3SOHs264RrJMNu6VjgJxtN6pTaMU59Bdw5glcgtHUUXk6aWs8FBRinv7uo0CeleYQmO 0AOhRti6z+Nda614HgomiXXGirs6GcFjTwHJqGZQ3UgqK/pZetzdjPYw/LJgg8PaFpy4 LHkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=iCa2japKWrV75POWR+h/A7CarCWhtlniqbttH95Ttrc=; b=pKaJHwzQG0/dq7utrqpDACLduTRkC/qcfqZBuv78w2kjeQvlY8gZKV1PumZHD3HDB/ 3bq0o/lZJNEtrQkiNgYgUhXn6GAgYLv7wvlIg6Q2/d+VlCbhdeH8bbmHKehq+/HFouPC LuMIpFdh6qubPrWR8og37MAT6HZ0nxzba7Uu4iw4YiE1Bu2ceJCTgTJlZGxn6oqkKupA ihgtPbKO9956t2bFk7dEeeZ9xTisZSlS4hhIeEt4HIlKHV3Y54gayIsVCpSQ7tvB3lL+ aRNgL2O1dHYQRMSn5e4w19AlWpVroPvoUO+DuwY+TdgJYmHUqlPDJWaWWNil+hFcZqAo tGpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kk14-20020a170907766e00b009764f09254esi5239344ejc.766.2023.06.12.10.40.20; Mon, 12 Jun 2023 10:40:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229800AbjFLRQy (ORCPT + 99 others); Mon, 12 Jun 2023 13:16:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231127AbjFLRQt (ORCPT ); Mon, 12 Jun 2023 13:16:49 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 12AFE10FE for ; Mon, 12 Jun 2023 10:16:43 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D119C13D5; Mon, 12 Jun 2023 10:17:27 -0700 (PDT) Received: from e121345-lin.cambridge.arm.com (e121345-lin.cambridge.arm.com [10.1.196.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C61EA3F5A1; Mon, 12 Jun 2023 10:16:41 -0700 (PDT) From: Robin Murphy To: will@kernel.org Cc: mark.rutland@arm.com, ilkka@os.amperecomputing.com, john.g.garry@oracle.com, renyu.zj@linux.alibaba.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] perf/arm-cmn: Add sysfs identifier Date: Mon, 12 Jun 2023 18:16:33 +0100 Message-Id: X-Mailer: git-send-email 2.39.2.101.g768bb238c484.dirty In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768519521990329809?= X-GMAIL-MSGID: =?utf-8?q?1768519521990329809?= Expose a sysfs identifier encapsulating the CMN part number and revision so that jevents can narrow down a fundamental set of possible events for calculating metrics. Configuration-dependent aspects - such as whether a given node type is present, and/or a given node ID is valid - are still not covered, and in general it's hard to see how userspace could handle them, so we won't be removing any data or validation logic from the driver any time soon, but at least it's a step in a useful direction. Signed-off-by: Robin Murphy Tested-by: Jing Zhang --- drivers/perf/arm-cmn.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c index 8cf4ed932950..088dc5c690a4 100644 --- a/drivers/perf/arm-cmn.c +++ b/drivers/perf/arm-cmn.c @@ -1199,19 +1199,31 @@ static ssize_t arm_cmn_cpumask_show(struct device *dev, static struct device_attribute arm_cmn_cpumask_attr = __ATTR(cpumask, 0444, arm_cmn_cpumask_show, NULL); -static struct attribute *arm_cmn_cpumask_attrs[] = { +static ssize_t arm_cmn_identifier_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct arm_cmn *cmn = to_cmn(dev_get_drvdata(dev)); + + return sysfs_emit(buf, "%03x%02x\n", cmn->part, cmn->rev); +} + +static struct device_attribute arm_cmn_identifier_attr = + __ATTR(identifier, 0444, arm_cmn_identifier_show, NULL); + +static struct attribute *arm_cmn_other_attrs[] = { &arm_cmn_cpumask_attr.attr, + &arm_cmn_identifier_attr.attr, NULL, }; -static const struct attribute_group arm_cmn_cpumask_attr_group = { - .attrs = arm_cmn_cpumask_attrs, +static const struct attribute_group arm_cmn_other_attrs_group = { + .attrs = arm_cmn_other_attrs, }; static const struct attribute_group *arm_cmn_attr_groups[] = { &arm_cmn_event_attrs_group, &arm_cmn_format_attrs_group, - &arm_cmn_cpumask_attr_group, + &arm_cmn_other_attrs_group, NULL };