From patchwork Thu Dec 15 12:38:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evgeniy Baskov X-Patchwork-Id: 33638 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp329360wrn; Thu, 15 Dec 2022 04:46:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf7WwTvWGNMAz+ZfEe+/gypI1oj2C9YTqwbYlXdlgbVUwK2TJZUsN3hTWD9HJkLjBDfe/hJz X-Received: by 2002:a05:6402:3609:b0:461:8be6:1ac5 with SMTP id el9-20020a056402360900b004618be61ac5mr22601742edb.3.1671108402336; Thu, 15 Dec 2022 04:46:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671108402; cv=none; d=google.com; s=arc-20160816; b=tXDc/64Ccb13ktSGya0L9AE2yn/zZ5sG0vONb3RgrD7mWZ8xX8cM7Q7NjvA7CqcgWd f3qPCIoXyrFzfmFlIzNpUrb2xqb1YsUPbCVDMu8zIVsUaLLdJJObHrHmr1vEkBnyu+qK NQNferqeoTzFNv2+VIeXsxULHW2PD42ielNN3HHPnpWOXO2IDqJ95mv3HksRwa+tPayL zLDnvDv+FxlYAvltNkQ2Xs9ank/Gszgq5IFMXckh0/K7nEQDz9alMM70oKnz3i07UZaE U/w1EVs2JP7kHE2FupjyCb6KUinU0fxdtktXCj0w6/N+eH7TX+LxTzsXfDMeqTz2OAjY 3jJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=/3aykElKH4pn5SEXDyJ1EneJ0wHiEtYgi6a9UlywDnA=; b=yIl9269Mb2dASfwcqhiz7HxCZ16ZSI36zYMVEgAQNiDFix9Bc3Rj/bNPKnSZhTCUKA 8fX69zHSjvE14CSRHZkYDiD4cHnFZ46BmaeaVyAFuNWXgwax3YGiH9CKxywh2i2T0BLb qydDkhO9XENp1/f6Bqgy7roE43/iALSXZ2kqypcEV/CGHmKKIiVxI289+oR5b3kqc8RF 6BwwsJQ7a5cVkfTBmVjAF6ZISXT0D5Wf5/faIBdfgooqG40KWn0dKFlEazMANBGd1Y+l OEt6mV0M4k/2atDmlk86IUWkVv4vi84v5rAnxbO2yZOL7dy5/OWKd3ivgp53wVC0gpQA wvBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=euKzKEG8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id eb14-20020a0564020d0e00b0046d27438b2fsi17092137edb.514.2022.12.15.04.46.18; Thu, 15 Dec 2022 04:46:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=euKzKEG8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229879AbiLOMnZ (ORCPT + 99 others); Thu, 15 Dec 2022 07:43:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229912AbiLOMnB (ORCPT ); Thu, 15 Dec 2022 07:43:01 -0500 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FDD51F2DB; Thu, 15 Dec 2022 04:42:30 -0800 (PST) Received: from localhost.localdomain (unknown [83.149.199.65]) by mail.ispras.ru (Postfix) with ESMTPSA id D094640737AC; Thu, 15 Dec 2022 12:42:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru D094640737AC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1671108146; bh=/3aykElKH4pn5SEXDyJ1EneJ0wHiEtYgi6a9UlywDnA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=euKzKEG8WaY8e4TbcSYrwQuaFPPQOJzEJNpzhDqKCqsjUaTZxReb8Yt5QZGY1JpFx rFfecsbHF2vp2jxg14K4y/XhNCvwDG3iY5zqRLELY9RUz2QdCdQLoTSKYqG7jaJVbf sMV0XXHNSDKwLjGj/K9d4EOQ1NWo071JDJ1qElkA= From: Evgeniy Baskov To: Ard Biesheuvel Cc: Peter Jones , Borislav Petkov , Andy Lutomirski , Dave Hansen , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Alexey Khoroshilov , "Limonciello, Mario" , joeyli , lvc-project@linuxtesting.org, x86@kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH v4 24/26] efi/libstub: make memory protection warnings include newlines. Date: Thu, 15 Dec 2022 15:38:15 +0300 Message-Id: X-Mailer: git-send-email 2.37.4 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752284164278878523?= X-GMAIL-MSGID: =?utf-8?q?1752284164278878523?= From: Peter Jones efi_warn() doesn't put newlines on messages, and that makes reading warnings without newlines hard to do. Signed-off-by: Peter Jones --- drivers/firmware/efi/libstub/mem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/efi/libstub/mem.c b/drivers/firmware/efi/libstub/mem.c index 07d54c88c62e..b31d1975caa2 100644 --- a/drivers/firmware/efi/libstub/mem.c +++ b/drivers/firmware/efi/libstub/mem.c @@ -297,7 +297,7 @@ efi_status_t efi_adjust_memory_range_protection(unsigned long start, rounded_end - rounded_start, attr_clear); if (status != EFI_SUCCESS) { - efi_warn("Failed to clear memory attributes at [%08lx,%08lx]: %lx", + efi_warn("Failed to clear memory attributes at [%08lx,%08lx]: %lx\n", (unsigned long)rounded_start, (unsigned long)rounded_end, status); @@ -310,7 +310,7 @@ efi_status_t efi_adjust_memory_range_protection(unsigned long start, rounded_end - rounded_start, attributes); if (status != EFI_SUCCESS) { - efi_warn("Failed to set memory attributes at [%08lx,%08lx]: %lx", + efi_warn("Failed to set memory attributes at [%08lx,%08lx]: %lx\n", (unsigned long)rounded_start, (unsigned long)rounded_end, status);