From patchwork Wed Dec 27 16:26:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183521 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1534127dyb; Wed, 27 Dec 2023 08:30:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IG818CXc1cCJ74ySMBsXcxyHOILrrz8+E0KyI4GZj9/KBApSfst1QTITiHzAYedwiLpYsGO X-Received: by 2002:a05:6e02:3881:b0:360:219b:c3d2 with SMTP id cn1-20020a056e02388100b00360219bc3d2mr739466ilb.58.1703694655965; Wed, 27 Dec 2023 08:30:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694655; cv=none; d=google.com; s=arc-20160816; b=jZqqx58b6Y0biQMraxMuB5wmd2BJ39v2NQBIpddlta99ziaGdQYYvpBc0Rs5noPpv7 XERzk3JUcDNEz17D8VqDDlU2+1f0q229CKFGcA4UR/a7XOvhZz/la8MUTUNkd10OlK6s WE1c9RqFRpVuiRvL3DPV0ngcXQjK5ebMAIhArXMf/7HWVc2/FmnvYg1IMAcWfRJG4B2k 6efOxsJW+m0c0Ha0cZTaH9k+d7C6k8JqMoRIzga0ZHOQ4/q0LrIgKE5hx7DXM7Y5M+4k QVVObwqvbwc0txNmYFc8wjr3wv+6FqSe0ePGwrAtcX4T5Op6vCi9girjs7tyTms3ofzj yD+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=I3+UhTyqkFrp94UV7Wlt0QGm87TUvH/sDj07oUQ9dX8=; fh=76Xiati3aEKZCKUz+/8/vT46Dr+i8/HkFKL17oemDII=; b=uNPixd4lWx6WCheACA590tJXVWrt0LiN/ruc3e+674dUMPtfnjOaTtPcf8U7hxj3Rd x1gSqLwKAFpfpIsqGPJFms4WcO2QPQY8ZeEm0Egc/by91hgZqULEl9i6HD1feBaofh8X dKvsrUoL9vmA30nK0FRG9IfhirWtMvie5+31qKOe88llvwqGsA+DdNKig0HfzWRZLXKV vch6LTzXH+MgazjCL/E8f15GjYPybBzjwYsF0vTIeNS2F8ZhE3456jvnv2YXUxBT3fj3 L9F94bECWz9rjAMH/5CZA0ZyLrJypPWyX0rRj9ZOkaGhMDvCpuDqyHFXU/JbQojTnrw6 JNwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12134-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12134-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id n21-20020a634d55000000b005cd84b844e5si8542978pgl.595.2023.12.27.08.30.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 08:30:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12134-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12134-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12134-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B8D73B227A6 for ; Wed, 27 Dec 2023 16:29:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A07F0495DF; Wed, 27 Dec 2023 16:27:04 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5AB448CD9 for ; Wed, 27 Dec 2023 16:27:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWk0-0005Bf-PT; Wed, 27 Dec 2023 17:26:44 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjy-001tZq-Se; Wed, 27 Dec 2023 17:26:43 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjz-001WnN-2r; Wed, 27 Dec 2023 17:26:43 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Michal Simek , Greg Kroah-Hartman , Jay Buddhabhatti , Sai Krishna Potthuri , Linus Walleij , Nava kishore Manne , Rajan Vaja , Rob Herring , Dhaval Shah , Marek Vasut Cc: kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/11] firmware: zynqmp: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:35 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1949; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=5lA5AskgyOWj5RlJyQL/1YZMBAmaOueb91fZw7g7wBk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljFA+SOL/OLAdfMhQjjJrd6i8QwhOba6xFIvvF 9XxF7gr7VqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYxQPgAKCRCPgPtYfRL+ Tr/0B/43t00D3aB2EI/DNiEEuY+18Axew5V9CICgtxrn/vfQ8Yk5ViKo9PuE1Ee5VBjRwbh0bpP JYG7GNO2F7JcSXMEOEgxIs17hku48vv+Qabv4ho0F1TtgwWiOWxaX2n6yTt8FkbKXykKoV8nEW6 vSR53TvZNvtyIpP59/0KAIs7//PMmtpBfP37i+0JUmDvIH1ypp0rlDDZH+tP9Zjg5kwnv0QCtH/ YoBdzx7xDa5QfcjvFmYVuedqXmDX8n1ratrsNABJKYmaVbMnFIO9qWZiZVc7Xollxdmk9JFHXzi M1F+jOJ8BFTCXyiVfelpt9t0eIk7Gcb4yU+IDf4MHG7rR3+N X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786453327329130634 X-GMAIL-MSGID: 1786453327329130634 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Michal Simek --- drivers/firmware/xilinx/zynqmp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c index a55dfd9bae6b..73cae6ef83ec 100644 --- a/drivers/firmware/xilinx/zynqmp.c +++ b/drivers/firmware/xilinx/zynqmp.c @@ -1929,7 +1929,7 @@ static int zynqmp_firmware_probe(struct platform_device *pdev) return of_platform_populate(dev->of_node, NULL, NULL, dev); } -static int zynqmp_firmware_remove(struct platform_device *pdev) +static void zynqmp_firmware_remove(struct platform_device *pdev) { struct pm_api_feature_data *feature_data; struct hlist_node *tmp; @@ -1944,8 +1944,6 @@ static int zynqmp_firmware_remove(struct platform_device *pdev) } platform_device_unregister(em_dev); - - return 0; } static const struct of_device_id zynqmp_firmware_of_match[] = { @@ -1962,6 +1960,6 @@ static struct platform_driver zynqmp_firmware_driver = { .dev_groups = zynqmp_firmware_groups, }, .probe = zynqmp_firmware_probe, - .remove = zynqmp_firmware_remove, + .remove_new = zynqmp_firmware_remove, }; module_platform_driver(zynqmp_firmware_driver);