[2/3] staging: rtl8192e: rename r8192E_hwimg.c/h to table.c/h

Message ID b3f6522959e665f4194764caed30050d7b728b29.1667641211.git.jacob.bai.au@gmail.com
State New
Headers
Series staging: rtl8192e: trivial code cleanup patches |

Commit Message

Jacob Bai Nov. 5, 2022, 10 a.m. UTC
  Same as other rtlwifi frivers, use table.c/h.

Signed-off-by: Jacob Bai <jacob.bai.au@gmail.com>
---
 drivers/staging/rtl8192e/rtl8192e/Makefile                    | 2 +-
 drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c                | 2 +-
 drivers/staging/rtl8192e/rtl8192e/{r8192E_hwimg.c => table.c} | 2 +-
 drivers/staging/rtl8192e/rtl8192e/{r8192E_hwimg.h => table.h} | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)
 rename drivers/staging/rtl8192e/rtl8192e/{r8192E_hwimg.c => table.c} (99%)
 rename drivers/staging/rtl8192e/rtl8192e/{r8192E_hwimg.h => table.h} (94%)
  

Comments

kernel test robot Nov. 5, 2022, 11:49 a.m. UTC | #1
Hi Jacob,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Jacob-Bai/staging-rtl8192e-trivial-code-cleanup-patches/20221105-180428
patch link:    https://lore.kernel.org/r/b3f6522959e665f4194764caed30050d7b728b29.1667641211.git.jacob.bai.au%40gmail.com
patch subject: [PATCH 2/3] staging: rtl8192e: rename r8192E_hwimg.c/h to table.c/h
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/7b00b7dc3c79fff73bda0f623d6677e4fb6cdf3c
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jacob-Bai/staging-rtl8192e-trivial-code-cleanup-patches/20221105-180428
        git checkout 7b00b7dc3c79fff73bda0f623d6677e4fb6cdf3c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/staging/rtl8192e/rtl8192e/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c:9:10: fatal error: r8192E_hwimg.h: No such file or directory
       9 | #include "r8192E_hwimg.h"
         |          ^~~~~~~~~~~~~~~~
   compilation terminated.


vim +9 drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c

94a799425eee82 drivers/staging/rtl8192e/r8192E_firmware.c          Larry Finger       2011-08-23  @9  #include "r8192E_hwimg.h"
94a799425eee82 drivers/staging/rtl8192e/r8192E_firmware.c          Larry Finger       2011-08-23  10  #include "r8192E_firmware.h"
15d140664c94f5 drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c Mateusz Kulikowski 2015-10-19  11  #include "r8192E_cmdpkt.h"
94a799425eee82 drivers/staging/rtl8192e/r8192E_firmware.c          Larry Finger       2011-08-23  12  #include <linux/firmware.h>
94a799425eee82 drivers/staging/rtl8192e/r8192E_firmware.c          Larry Finger       2011-08-23  13
  

Patch

diff --git a/drivers/staging/rtl8192e/rtl8192e/Makefile b/drivers/staging/rtl8192e/rtl8192e/Makefile
index 75e6ec510555..334d92efd4ba 100644
--- a/drivers/staging/rtl8192e/rtl8192e/Makefile
+++ b/drivers/staging/rtl8192e/rtl8192e/Makefile
@@ -4,7 +4,7 @@  r8192e_pci-objs :=		\
 	r8192E_phy.o		\
 	r8192E_firmware.o	\
 	r8192E_cmdpkt.o		\
-	r8192E_hwimg.o		\
+	table.o		\
 	r8190P_rtl8256.o	\
 	rtl_cam.o		\
 	rtl_core.o		\
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index 58da2dab55bd..eabb4187d907 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -12,7 +12,7 @@ 
 #include "r8192E_phy.h"
 #include "rtl_dm.h"
 
-#include "r8192E_hwimg.h"
+#include "table.h"
 
 static u32 RF_CHANNEL_TABLE_ZEBRA[] = {
 	0,
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c b/drivers/staging/rtl8192e/rtl8192e/table.c
similarity index 99%
rename from drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c
rename to drivers/staging/rtl8192e/rtl8192e/table.c
index 8920283f340e..2e75f40db874 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.c
+++ b/drivers/staging/rtl8192e/rtl8192e/table.c
@@ -4,7 +4,7 @@ 
  *
  * Contact Information: wlanfae <wlanfae@realtek.com>
  */
-#include "r8192E_hwimg.h"
+#include "table.h"
 
 u32 RTL8192E_PHY_REG_ARRAY[RTL8192E_PHY_REG_ARRAY_LEN] = {0x0,};
 
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.h b/drivers/staging/rtl8192e/rtl8192e/table.h
similarity index 94%
rename from drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.h
rename to drivers/staging/rtl8192e/rtl8192e/table.h
index a436c089a779..a80176c47127 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.h
+++ b/drivers/staging/rtl8192e/rtl8192e/table.h
@@ -4,8 +4,8 @@ 
  *
  * Contact Information: wlanfae <wlanfae@realtek.com>
  */
-#ifndef __INC_HAL8192PciE_FW_IMG_H
-#define __INC_HAL8192PciE_FW_IMG_H
+#ifndef __RTL8192E_TABLE__H_
+#define __RTL8192E_TABLE__H_
 
 /*Created on  2008/11/18,  3: 7*/