From patchwork Tue Jul 18 16:54:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 122145 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1894387vqt; Tue, 18 Jul 2023 10:17:35 -0700 (PDT) X-Google-Smtp-Source: APBJJlHSG04ijRGDNnYRLFSJg4LPZ2s+R96kN18KI72EepzR6KHNU03a4ZIZpDhrgfBP2M5tZdGn X-Received: by 2002:a17:902:b592:b0:1b3:d606:9214 with SMTP id a18-20020a170902b59200b001b3d6069214mr12244437pls.24.1689700655136; Tue, 18 Jul 2023 10:17:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689700655; cv=none; d=google.com; s=arc-20160816; b=TXpm7+mA5sRF/DG6mJ4sGS71JASRbB+sPfCnhzIVqYyXfIdX7YtIKi8pxd5TKUm/z+ rmUa2sX469rLOyivbZmZArzKFWsLiQ7X/8RmZ0oy6H9N+GwAf+aNd09O6FfV49A2Hd+i EEAmqeRUVPgm+DghWPPVanYWOjvd6DlU9fk761g1emmNZ+Z05Qhp+QQf5+JfUcJjODw/ Cm+1FJcXWYNMpC7K3A6eTt73lIjbjniwMtPiRR5dVbNH/nrzjRmxQVeMzGJjhxnWuTEU 3h6MS/+9jt0BezmW5e0oUiEcNXFbC5But6N16DNlW5wqAWCZjxTGWTW0apflXVQA8ZF+ rkbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=+sa7BhNJ5bxFPVp5DHE1/2MejC5a2zlqyKKDHawSN50=; fh=Ople2ijcDVdvBJwvAg2RvyZp0qNZK7It46SN0LxlrVk=; b=X5sTjxviUdDhJ13SyzoMc/tC2tQ5sYcbiiX97uJrlUbGu2sk9J2j2c7JtVDyD6Eu8g B3vf/Z3ynBDzZgk085cJ973CY4Hjsui5keAxVxhVA3E63sVtS2ZmQneYeX7I30bKyC4K HHo2T8kTDfjkb8M3jv2xG/Rs2dpt/kg8gfiNMEwoDZ2FqQ6ti+xzZSm0iGKMX+nO54Nr BYsD5ak18kCQSwDqBk3bJd8cjEV+DT1IlX2aR/08enaP/F6QbGubp4dW31UvEz34jwPV Q5oTj1s/eanfOVn9TYjd+39mOMRW3rDbMfWqmO6dawf/Qi2PT7yIm8vQ8sBGIvvFx+M+ 17uQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p15-20020a170902e74f00b001b3414a1fa9si2018537plf.175.2023.07.18.10.17.13; Tue, 18 Jul 2023 10:17:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233594AbjGRQzy (ORCPT + 99 others); Tue, 18 Jul 2023 12:55:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232719AbjGRQzB (ORCPT ); Tue, 18 Jul 2023 12:55:01 -0400 Received: from xavier.telenet-ops.be (xavier.telenet-ops.be [IPv6:2a02:1800:120:4::f00:14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A65E19A5 for ; Tue, 18 Jul 2023 09:54:54 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:5803:2d6d:5bbc:e252]) by xavier.telenet-ops.be with bizsmtp id Ngur2A00D0ucMBo01gur1P; Tue, 18 Jul 2023 18:54:52 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qLnyD-001nXm-4N; Tue, 18 Jul 2023 18:54:51 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qLnyN-000gbY-5M; Tue, 18 Jul 2023 18:54:51 +0200 From: Geert Uytterhoeven To: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Laurent Pinchart Subject: [PATCH v2 06/41] drm: renesas: shmobile: Correct encoder/connector types Date: Tue, 18 Jul 2023 18:54:11 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771779554540026714 X-GMAIL-MSGID: 1771779554540026714 The first encoder output on the SH-Mobile LCD Controller is a DPI parallel bus. However, at the time of introduction of the driver, no encoder or connector types were defined yet for the DPI parallel bus, hence the driver used the ones for LVDS instead. Adjust the types accordingly. Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- v2: - Add Reviewed-by. --- drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c index 11dd2bc803e7cb62..fbfd906844da490c 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c @@ -598,7 +598,7 @@ int shmob_drm_encoder_create(struct shmob_drm_device *sdev) encoder->possible_crtcs = 1; ret = drm_simple_encoder_init(sdev->ddev, encoder, - DRM_MODE_ENCODER_LVDS); + DRM_MODE_ENCODER_DPI); if (ret < 0) return ret; @@ -684,7 +684,7 @@ int shmob_drm_connector_create(struct shmob_drm_device *sdev, connector->display_info.height_mm = sdev->pdata->panel.height_mm; ret = drm_connector_init(sdev->ddev, connector, &connector_funcs, - DRM_MODE_CONNECTOR_LVDS); + DRM_MODE_CONNECTOR_DPI); if (ret < 0) return ret;