diff mbox series

[1/2] mm: compaction: use the correct type of list for free pages

Message ID b21cd8e2e32b9a1d9bc9e43ebf8acaf35e87f8df.1688715750.git.baolin.wang@linux.alibaba.com
State New
Headers
Series [1/2] mm: compaction: use the correct type of list for free pages |

Commit Message

Baolin Wang July 7, 2023, 8:51 a.m. UTC 
  Use the page->buddy_list instead of page->lru to clarify the correct type
of list for free pages.

Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
---
 mm/compaction.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

David Hildenbrand July 7, 2023, 11:52 a.m. UTC | #1 
On 07.07.23 10:51, Baolin Wang wrote:
> Use the page->buddy_list instead of page->lru to clarify the correct type
> of list for free pages.
> 
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
>   mm/compaction.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/compaction.c b/mm/compaction.c
> index dbc9f86b1934..43358efdbdc2 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1500,7 +1500,7 @@ static void fast_isolate_freepages(struct compact_control *cc)
>   
>   		spin_lock_irqsave(&cc->zone->lock, flags);
>   		freelist = &area->free_list[MIGRATE_MOVABLE];
> -		list_for_each_entry_reverse(freepage, freelist, lru) {
> +		list_for_each_entry_reverse(freepage, freelist, buddy_list) {
>   			unsigned long pfn;
>   
>   			order_scanned++;
> @@ -1883,7 +1883,7 @@ static unsigned long fast_find_migrateblock(struct compact_control *cc)
>   
>   		spin_lock_irqsave(&cc->zone->lock, flags);
>   		freelist = &area->free_list[MIGRATE_MOVABLE];
> -		list_for_each_entry(freepage, freelist, lru) {
> +		list_for_each_entry(freepage, freelist, buddy_list) {
>   			unsigned long free_pfn;
>   
>   			if (nr_scanned++ >= limit) {

Reviewed-by: David Hildenbrand <david@redhat.com>
diff mbox series

Patch

diff --git a/mm/compaction.c b/mm/compaction.c
index dbc9f86b1934..43358efdbdc2 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1500,7 +1500,7 @@  static void fast_isolate_freepages(struct compact_control *cc)
 
 		spin_lock_irqsave(&cc->zone->lock, flags);
 		freelist = &area->free_list[MIGRATE_MOVABLE];
-		list_for_each_entry_reverse(freepage, freelist, lru) {
+		list_for_each_entry_reverse(freepage, freelist, buddy_list) {
 			unsigned long pfn;
 
 			order_scanned++;
@@ -1883,7 +1883,7 @@  static unsigned long fast_find_migrateblock(struct compact_control *cc)
 
 		spin_lock_irqsave(&cc->zone->lock, flags);
 		freelist = &area->free_list[MIGRATE_MOVABLE];
-		list_for_each_entry(freepage, freelist, lru) {
+		list_for_each_entry(freepage, freelist, buddy_list) {
 			unsigned long free_pfn;
 
 			if (nr_scanned++ >= limit) {