From patchwork Thu Nov 24 16:57:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matija Glavinic Pecotic X-Patchwork-Id: 25635 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3510388wrr; Thu, 24 Nov 2022 09:03:45 -0800 (PST) X-Google-Smtp-Source: AA0mqf4KBFs2jVfh8YF0z89cKDFPQnyPs+6H/Wg38G6X0b2bCYl9XuQkXE/3e6OwBL7AvHJ2IJy7 X-Received: by 2002:a2e:bd82:0:b0:278:e7bb:f68a with SMTP id o2-20020a2ebd82000000b00278e7bbf68amr11874045ljq.117.1669309424857; Thu, 24 Nov 2022 09:03:44 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1669309424; cv=pass; d=google.com; s=arc-20160816; b=pHNWPg3XoEypCy2SsmgGKq5Kio5X0bt4xFqJtxmTyzxqY2FXakjTHz8y9YduN5RDGs wUcuMcJW7aST4Tk9HTDmUtbcQJfuX+ZFfVPs5s4dakzxtEOQejKHt/wf8XC6MMZTPuBz g6cSI9T3WkwjVEe1KuEH9voGZlSonp8cXUgcwC9EvH7kDs1cK67GmLyZzn4IQesq4Jye MtEt8/1FnIlKpEKhN37xQ1oZkBGEopVRKfz8cIsTtJUar+l9f+KZ9kOItq0yH/zcBNNz LAs+WQY/auhr/utnqJol4Vjb5UCL/uUCDOQaHGvyR7BeqyRNOYUaqH8YYoTnDFXUX6h6 YOeg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding:subject :from:to:content-language:user-agent:date:message-id:dkim-signature; bh=ps+MmI7qpyQuhyJADB9Mcwnkj2bX3JzgUnOXFL9zBt0=; b=f0gGwKK5g3jCtfWxxsiRpGL9geEdYIRqNvO6G8enJljFU4700Tym5hqpZk/SpS5ucf jhCr0vPbe2GPcHhn3k5rESKmWtz9PGdBXXZ4Slhuqk9uDKEcrlYQD/vR+/MSutAQzLse U67TSdM33jvOHYXZHenK97aW8CgjUyEoESxd1794fd5tRn9T6SevwccWV6UflKkiTLNz BVVe4qUBe6cvnVfaEt0iSibzMmmYl6gg8lGtxYYZNfqhH+0C/z92y84hPb0whrR8pENT UQFXxFu18dNLhjJZto41bnTgw8v4dNpeqq9uZHXC/X/qKnuDvO3ZtDf3+VnepQW4QA6u bwCA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nokia.onmicrosoft.com header.s=selector1-nokia-onmicrosoft-com header.b=mGe6i84M; arc=pass (i=1 spf=pass spfdomain=nokia.com dkim=pass dkdomain=nokia.com dmarc=pass fromdomain=nokia.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nokia.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xc1-20020a170907074100b0078de51e1c3dsi222123ejb.840.2022.11.24.09.03.19; Thu, 24 Nov 2022 09:03:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nokia.onmicrosoft.com header.s=selector1-nokia-onmicrosoft-com header.b=mGe6i84M; arc=pass (i=1 spf=pass spfdomain=nokia.com dkim=pass dkdomain=nokia.com dmarc=pass fromdomain=nokia.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nokia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229539AbiKXQ5n (ORCPT + 99 others); Thu, 24 Nov 2022 11:57:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbiKXQ5k (ORCPT ); Thu, 24 Nov 2022 11:57:40 -0500 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70138.outbound.protection.outlook.com [40.107.7.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 601CA19025 for ; Thu, 24 Nov 2022 08:57:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M7vvZCd25Fmpgqco4qd7pyEEkoi6c4YSGsUczvini8YuOv6CPKz9qw2Ufu5nXQQvbJ8ktiIYQAn0DrwtIx6ApjuwkSO4LftTrswDzB8ax/N2q2C8nUBNmFAfHEvWrCXWT6uJFtkIdsMe8OXDg9jd2VZIOm0BA9jgJc25TfnCMKo0j4i2ZAg4IWsbTa6VJx5T+V8hKlR9KKnNzjLn5bTmyybfKtPRypCC59T2Xu2YNaCv88GFKD3RecPo+nUaROY2JNH9+Bipt6lJSv39gqYJsy0zeUuXbxFbz/0RpYqZj/zoZOBXerPOZyD4+JxQe0TVDjlUf3kyOO5g0mR5Zvqgcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ps+MmI7qpyQuhyJADB9Mcwnkj2bX3JzgUnOXFL9zBt0=; b=EHJbeSxy9Wu6ts1GSBBTIgYbAZjboJf7phxhKfv221w6hh8EibE3232DqQrgCA33XWnPQjW8JTZXX+d1MGFGp+9hfMm9TgvDI/hNHasclmOyM3Jaxqvd5yE5Oq/qh9qGdybJRXQDJXxWTiNLWyEV9ethmOROiwGn99RB1H7aa+8dlo1YQO09bfOLyytzb/gI3qgmJCpfj6m2CQqlfeXkGnUHCpGEA+D21+2jJhWSF3WNVtnWbb9h07rWzH8UQs1eHUpBgwxiKr0iv44mF/WCE4ErbeBk88ip4O7YKf4rivCjHJ6p4Tu2tgPoFqs6mg2vvuuUQ1vTvhenbK4Sm7iMuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ps+MmI7qpyQuhyJADB9Mcwnkj2bX3JzgUnOXFL9zBt0=; b=mGe6i84Mt3bs/rEqBOLhshHtVBmBT3OlQUGTgDLXVCp6GiCrzTCrgKeCP7Huah4tkn2oLP+4Zn/ToekyYEzP1jrcWSyanZK8ndMRNRgERNdBkhW1R+fE28nhBWyJh9EapfmLZ9o+s9XYAKwhwf5NnxZ+VPwPHo6n6onxd2JGNJw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia.com; Received: from VI1PR0701MB3005.eurprd07.prod.outlook.com (2603:10a6:800:87::19) by DB5PR07MB9514.eurprd07.prod.outlook.com (2603:10a6:10:48f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Thu, 24 Nov 2022 16:57:35 +0000 Received: from VI1PR0701MB3005.eurprd07.prod.outlook.com ([fe80::bacd:11a2:15e2:7339]) by VI1PR0701MB3005.eurprd07.prod.outlook.com ([fe80::bacd:11a2:15e2:7339%11]) with mapi id 15.20.5857.019; Thu, 24 Nov 2022 16:57:34 +0000 Message-ID: Date: Thu, 24 Nov 2022 17:57:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, Linux Kernel Mailing List , Andy Shevchenko , hpa@zytor.com From: Matija Glavinic Pecotic Subject: [PATCH v3] x86/rtc: Remove __init for runtime functions X-ClientProxiedBy: HE1PR0902CA0042.eurprd09.prod.outlook.com (2603:10a6:7:15::31) To VI1PR0701MB3005.eurprd07.prod.outlook.com (2603:10a6:800:87::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR0701MB3005:EE_|DB5PR07MB9514:EE_ X-MS-Office365-Filtering-Correlation-Id: 88386094-14b0-4fd7-ec2d-08dace3cfbb9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oA2G8sbhSCX9qRzNdQJg0UtTJaVe/1Gl6I/x9FpOwoLa8Vjo9X8SN3mHr/s97iabto+u045SZGG0Xj0NjebacYpEha1qNYTU/AD9u+y42HdFnvyfcga8aH6IYIXxcTCOfECQvTDIUTqk70c3rkuIj8ovx+XgoJ6LaMFof/ms/r2e1GFE+PK/bX9medTeqDeC0oDWH1oKMe8s/nNoGHktG+TQ/nkiSWD0qWYdUq9WxWeaG5Nvei/ucFCK5mVhIHKfQwUXdCQH8IbUiEhv7eB03iRmITSy0pU+BwfvvaBwCXJ7rm6Y+2MYkVLbj1akT27LITVKXxX7KGP7/+LUCr6bUafHptTrynH2BbmlxglCuygl2frBSIpVc6C7cQzdB9SxojAk91dSM5kaJDZmeLmarpfWKfdhgfmKnr6HsAnC7uhEIZiFlwWYs6sIcSnSiGI+2cRT2vDHdwxT0xDCbwPGr+vlkhJMIVarg9BroEsYMltQtGFAxy/FgTnGkVIpXLknPglVymMVcW1mboubTetTl0zicY9ExulqQ0PWJ5VdOuSx2tPFHxlJRvsctYO9C13XhtuFsevTGHvLBXPUi23e9aQ6QVuBTGiZYcCmrVhYAYm4M2O5RTm1kfab5HM3I6SOd+phW5sDC5SC4kVw4YAnRZ7YTrHbSFYljJQMZ4LGtp0Ev+z0Vr4LHozX2+CBBNtyQaOftQxH2ehR8h64Gp/lW9jU0DxIss5JJ/P6DMJVjFA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0701MB3005.eurprd07.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(346002)(396003)(376002)(136003)(451199015)(6506007)(26005)(6486002)(36756003)(6666004)(110136005)(41300700001)(2616005)(5660300002)(186003)(2906002)(83380400001)(8936002)(66476007)(6512007)(66556008)(316002)(86362001)(55236004)(8676002)(31696002)(66946007)(82960400001)(478600001)(31686004)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?QgSJ93HL7rkpbTPTCrvYsS4vCLe7?= =?utf-8?q?b3HTtbWygu8SrWvCAWZ1LeARCiXt2q221Ciqc3OV4hgOtw17WFd13gV400rnyVjDk?= =?utf-8?q?54Hd0ulpWyHWKYgGnAxkTmfl6NpBkPAfYZHuNih4O/rawVSAArj3sDdPsF5CN8CfY?= =?utf-8?q?ZDiOMlYUjyBgSs1mi4LilPTqqqzhznYhHl+9Lzz17rgg5uR32onsKUw+EqZ8VmCZ4?= =?utf-8?q?YsvpCpQrP3W1NleFga80/ra+Wg/LQ36K8pFFK8BaePK24c8BHTrqCuG54CF9Z/J/J?= =?utf-8?q?0px82SphTkVdlzw9hY7G1+BSxN/n51urDWl9JSXUB8tX1eFa0zwoylJFQ6JkiPquq?= =?utf-8?q?OuFnRlVrFaQb+cl5wDYgDmiw68yvRM9qdo+swWSeaPpnWXRs+F019WBumYxsR5co8?= =?utf-8?q?0RcIP+/2GpWXO4prvxQOWjPHkXtCdLGo54IMiKL/KoJLU4uI8DkBgrZto6pQiL+WJ?= =?utf-8?q?mN2EI2vMxCD//V/29YK/BQbxdOor0TxY3Yv9+uFJ+ECARKrRPLFygS29koTtr8Jy3?= =?utf-8?q?aH68bpdqnNfOy9ZU/xj0KrJlI9DIFqB7C2eLmGsuBibqvnSGPbL1o4XZrVwxEyu4E?= =?utf-8?q?N26wNUHteH9V/gucoj+aep8D7xToBgrEMZYai3L8JTyx3zK9Pcdu2HnPE/HkuCiM9?= =?utf-8?q?FxDbOZ5m0pY8anZzVgbAtTFUr4tj17thG4wv4+OIucnVXtzzxC33WdalHvbz+z+yb?= =?utf-8?q?2frUDc4IdVVZFA+9zVm2JF1z2PS/EPCHnNFVV+SSB9pdlBVp8OvBywS93kMvhWkeA?= =?utf-8?q?uX9tB6mao1KzbQ0c+tCv47Kt6yz6ZphCREwen4sABABhrHRcl7nl+5cyOhLgZB3HT?= =?utf-8?q?npS6rdv6doUvcpLeDHMExNO9UjEfD8nnQ9sUji+aZojDuCMQlSfF1qFxbX8cwkJVO?= =?utf-8?q?8zYg+wVhdwVWN7jHGHEP9eqafL5US0gsfBp7IXrDA52KlEDfGar0HeC1yOF/M5de2?= =?utf-8?q?EftQqN2Zq1Qzlk+nHJgWSGv1OYLn6/FUtgz48Jyy/zSY0/vn9pNFP8EPyUJ6hUpue?= =?utf-8?q?ZBm+PioI30SfhsVbwuj7CnsgAGF1Ux1F6KwYYeH0GXE2hCteNJLWYY/ZxcpG3/HTj?= =?utf-8?q?LWTY3rV1LQ6B0cuRMKrMq7f1ckADuwlpJprG0HPA1a26G6QPFkshMtWbj6EvMtKXO?= =?utf-8?q?0BdknN1xwUx5UUHwKfS6f4+qydpzI98vjXm7BVlUEhGRoVxO7heM2Y2ACuTXOkrrJ?= =?utf-8?q?q8bsIS7DJtlShGsMlwyQ1AkyahGOk8U+ACncBoOKlLJmR3fICZGo+sHDCye282B7v?= =?utf-8?q?0k8HnTdHnpk37kG/7toa5gZBkn1KqWQkqG32tAGIn5PP+ip/kYA768Su3ofhJobnG?= =?utf-8?q?Lz9SdxVTzfJFY+Di9vP23AYdOidDAkN5Qp7l9Rx5lXDIEWCngnHP/fWJD+8Ca8RQK?= =?utf-8?q?wA3e2KtZ4Pqq2TmTBi2ItCkr+h90OSmhIC0JahoE92PWtKvdNVOmHaaN6kC0pFDa4?= =?utf-8?q?byWK4o1UD7HR1/gyh4WW+fJmalX1fHsmIebtsi37a+lIayTTUrkZG4C4JSinIoslc?= =?utf-8?q?2a9zm35UC4sQDFKsUnmCt2QHygP4HWz9QNOdrkxLd54x0A1PYxPy3QM=3D?= X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88386094-14b0-4fd7-ec2d-08dace3cfbb9 X-MS-Exchange-CrossTenant-AuthSource: VI1PR0701MB3005.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 16:57:34.4378 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Lx++tWupuyoO07+JSzLaO9CLef3Z5ij0t+fHAMvb3wWjwT04wbgxHv6CrMo1MuaTItpVjPgeOFyp7eKkvthrqxht7tLrCQcFknGBHiiF8gcw0qIMFnPIKrEiNiWW6aZb X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR07MB9514 X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750397799285462459?= X-GMAIL-MSGID: =?utf-8?q?1750397799285462459?= set_rtc_noop, get_rtc_noop are used runtime, therefore need init removed. Crash was observed on x86 platform where cmos rtc is unused and disabled via device tree. Function was triggered from ntp: sync_hw_clock, although CONFIG_RTC_SYSTOHC=n, however sync_cmos_clock doesn't honour that. Workqueue: events_power_efficient sync_hw_clock RIP: 0010:set_rtc_noop Call Trace: update_persistent_clock64 sync_hw_clock Fix by dropping __init and making set/get_rtc_noop available runtime. Fixes: c311ed6183f4 ("x86/init: Allow DT configured systems to disable RTC at boot time") Reviewed-by: Andy Shevchenko Signed-off-by: Matija Glavinic Pecotic --- v3: Update commit message based on Andy's comments (further trim to backtrace, proper tag) v2: Update commit message based on Andy's comments arch/x86/kernel/x86_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c index 57353519bc11..0ab707bbefe2 100644 --- a/arch/x86/kernel/x86_init.c +++ b/arch/x86/kernel/x86_init.c @@ -32,8 +32,8 @@ static int __init iommu_init_noop(void) { return 0; } static void iommu_shutdown_noop(void) { } bool __init bool_x86_init_noop(void) { return false; } void x86_op_int_noop(int cpu) { } -static __init int set_rtc_noop(const struct timespec64 *now) { return -EINVAL; } -static __init void get_rtc_noop(struct timespec64 *now) { } +static int set_rtc_noop(const struct timespec64 *now) { return -EINVAL; } +static void get_rtc_noop(struct timespec64 *now) { } static __initconst const struct of_device_id of_cmos_match[] = { { .compatible = "motorola,mc146818" },