From patchwork Fri Dec 8 00:15:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 175481 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5148975vqy; Thu, 7 Dec 2023 16:17:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IG5n9N1OtG2mpbnGZh3sqgBt/XN1I4L8UrkUCMBrXk2hsEqJkp7ymut2hbrg1stOP7HNnjG X-Received: by 2002:a05:6a00:10c3:b0:6ce:93bf:b778 with SMTP id d3-20020a056a0010c300b006ce93bfb778mr3046841pfu.44.1701994643704; Thu, 07 Dec 2023 16:17:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701994643; cv=none; d=google.com; s=arc-20160816; b=exU3G+Efuifc/XbeF9ene6sQJC0P+CHaaxk1aR+0jOOyOTx449tqaMj8SQ3yuflmgf n/OtcUzNO3PJ+UMVXVYTqehGvS/uAymhXqLpCecvDF8shoLEJrfuP9BtOcPiGJ6QXb5g bdaC3YjO/ZT1CXw4s3lNRuezBv3IB05lQ/mJxAEBTie3/j77O85h309ePfyDIP+1uADZ siRmktgFypAZSZ3GV07pYF9IcKxjnNTr1D8bsrHrYuImc+JRz6gWyaEnukSIMS3K4T+p 5XT/gMw6XabZA3DSoJU1zbE9zfiK70j5EPC5gP6/horRAlRiFOf7b43fD8/ECXDR5AXy E2lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=c5Gf2fb1AFpGALyaBrBoOEEUKTRvi2Ij2/XB6Namp4w=; fh=Zewmf3wThiipMhDjR96yol5QxF5bGjQ0muN6YDM9mM0=; b=00qEFVv/QhdPYCYkFQIuYwy3YabarCrNroGu1mQPSeHJTvIFqs51hO9xmq9juvYzBi 5OloJVIiOV3VlJEX8s1UIzLLmCLMCjF1Jq+8M0kwsk+5vpajneSFN5mxElcOoiS88869 bPHej9eL1dkuYRA3BeLN8VQk4u0Tt9Q2uiAbL0YSIsAowRwTsUyi37ajBEZEQXesdoBK oHl71UHhBPiWCv6AF2GaXTfOwW7/MkOzHfRtesMC9geVRc1SIRe59dsJe9FtM6ppt2nN vbtcBdNK8yrQ0S/fRE0dgNm+Pdw3gs7MlIihUIRrA5J7XPpohmW/cnVwGLJhFBxumG3E 4nLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=PZFVODvz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id b6-20020a6541c6000000b0056fbf85c743si474937pgq.790.2023.12.07.16.17.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 16:17:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=PZFVODvz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 8B7B4807664F; Thu, 7 Dec 2023 16:16:06 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444177AbjLHAPz (ORCPT + 99 others); Thu, 7 Dec 2023 19:15:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235579AbjLHAP2 (ORCPT ); Thu, 7 Dec 2023 19:15:28 -0500 Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EED9172A for ; Thu, 7 Dec 2023 16:15:34 -0800 (PST) Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-7b3a8366e13so53452739f.1 for ; Thu, 07 Dec 2023 16:15:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701994533; x=1702599333; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c5Gf2fb1AFpGALyaBrBoOEEUKTRvi2Ij2/XB6Namp4w=; b=PZFVODvzYgrLhq932SkBVLwXo37XO99HeUsVrzAH5yVGx8DK3EYG2DuRWxhAcod3qP UKiTvna+W3NJJPBrRsBAOXiUz1MYueRrM9yO25kvFDqjXlk+R9eMsIFggA9V1uzPM5Ps zQK3xAGMJQFrULocoZ8UmXGcMkeKb++fyX10ZDH++0JsNEwNa/h4rVYRpNsnySTRGsWl Y6G1FCwGPSyBW/lf+HL7cde3yzr/jEeCSNuu0FZcSw4rvnPV2HmUjLC52T6yYDNGw0Iw HAzo/0D2UJb/xoV6Ew/sCfit1R15y2ED31e0BgTT2fclItPhN8KshnwmJ54V44nIkR8j BA8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701994533; x=1702599333; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c5Gf2fb1AFpGALyaBrBoOEEUKTRvi2Ij2/XB6Namp4w=; b=phH+gc1jnppNLW0gcHQQO4TzlASbBkY3bxY/wlzzHDVwlASr41PQvGieXIdRRnuWFk tzysGXWytXivOsy44y/3eynjXt8moz451vwuAQZjgd0qDhnyxQwPblgw1/Xoc42u1RqR uRqgosWWxAed84RS/X9X9YvuOAEuOyJJt9yMs9CdtAxyn2+C9O/asmvEJbO7dsvCO1Vs Qnk1vMMYm8IR9OUm4cDG/IS4HqEAM9qdMPdiOWeFqCKvplFZlV6MkXbWBGxDr9HrHy5u eV/URNdMpllMiImoIIYCRWRDyD0BMkzhLqQloWKklyjoNZW/5QZ0yfrrL1z/TQYkW1ey ealA== X-Gm-Message-State: AOJu0YxHy201cQt6/RCpmhIVIHyBaIDM+nDpA6xrAh/Z5oZYJccZnv5j d0L2AKoJtVNet8HEwvBV54Q= X-Received: by 2002:a05:6602:15d4:b0:7b4:28f8:1dfd with SMTP id f20-20020a05660215d400b007b428f81dfdmr3772175iow.28.1701994533712; Thu, 07 Dec 2023 16:15:33 -0800 (PST) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id z18-20020a056638241200b004664a0a7f2csm184652jat.177.2023.12.07.16.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 16:15:33 -0800 (PST) From: Jim Cromie To: lb@semihalf.com, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, bleung@google.com, contact@emersion.fr, daniel@ffwll.ch, dianders@chromium.org, groeck@google.com, jbaron@akamai.com, jim.cromie@gmail.com, john.ogness@linutronix.de, keescook@chromium.org, pmladek@suse.com, ppaalanen@gmail.com, rostedt@goodmis.org, seanpaul@chromium.org, sergey.senozhatsky@gmail.com, upstream@semihalf.com, vincent.whitchurch@axis.com, yanivt@google.com, gregkh@linuxfoundation.org Subject: [re: PATCH v2 00/15 - 09/11] dyndbg: reduce verbose/debug clutter Date: Thu, 7 Dec 2023 17:15:12 -0700 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 07 Dec 2023 16:16:07 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784670735371869165 X-GMAIL-MSGID: 1784670735371869165 currently, for verbose=3, these are logged for each query dyndbg: query 0: mod: <*> dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' dyndbg: flags=0x1 dyndbg: *flagsp=0x1 *maskp=0xffffffff dyndbg: parsed: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: no matches for query dyndbg: no-match: func="" file="" module="" format="" lineno=0-0 class=... dyndbg: processed 1 queries, with 0 matches, 0 errs That is excessive, so this patch shrinks it to 4 lines: dyndbg: query 0: on module: <*> dyndbg: split into words: "class" "D2_CORE" "+T:foo" dyndbg: op='+' flags=0x40 maskp=0xffffffff trace_dest=0x0 dyndbg: applied: func="" file="" module="" format="" lineno=0-0 class=D2_CORE Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 0ca3ba9e2032..fc903e90ea0d 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -845,7 +845,6 @@ static int ddebug_parse_query(char *words[], int nwords, */ query->module = modname; - vpr_info_dq(query, "parsed"); return 0; } @@ -870,7 +869,6 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) pr_err("bad flag-op %c, at start of %s\n", *str, str); return -EINVAL; } - v3pr_info("op='%c'\n", op); for (; *str ; ++str) { for (i = ARRAY_SIZE(opt_array) - 1; i >= 0; i--) { @@ -890,7 +888,6 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) return -EINVAL; } } - v3pr_info("flags=0x%x, trace_dest=0x%x\n", modifiers->flags, modifiers->trace_dst); /* calculate final flags, mask based upon op */ switch (op) { @@ -906,7 +903,8 @@ static int ddebug_parse_flags(const char *str, struct flag_settings *modifiers) modifiers->flags = 0; break; } - v3pr_info("*flagsp=0x%x *maskp=0x%x\n", modifiers->flags, modifiers->mask); + v3pr_info("op='%c' flags=0x%x maskp=0x%x trace_dest=0x%x\n", + op, modifiers->flags, modifiers->mask, modifiers->trace_dst); return 0; }